de1bbe3b78
Do not shadow global RPC table variable (tableRPC)
8 years ago
fa6dc9f0e5
Remove unused variables
8 years ago
fab5ecb771
[wallet] rpc: Drop misleading option
8 years ago
beef966e36
[Wallet] remove unused code/conditions in ReadAtCursor
8 years ago
653bb3d640
Add copyright header to wallet_text_fixture.cpp
...
I created the file but forgot to add this header.
8 years ago
8680d3aa80
Move wallet initialization logic from AppInit2 to CWallet::InitLoadWallet
8 years ago
4207630f5a
trivial: remove unused variable
...
Remove the unused variable "blockTmp" in CMerkleTx::SetMerkleBranch. It
was previously used to read the block from disk if not provided as
argument, but is no longer needed.
8 years ago
fa785d1211
Use __func__ to get function name for output printing
8 years ago
7e5d94df1f
[Wallet] Trivial cleanup of HD wallet changes
8 years ago
914154f0cc
[Qt] add HD enabled/disabled icon to the status bar
8 years ago
fab2e26d20
CDB: fix debug output
...
It doesn't really help to clear a variable before printing it to the debug log.
8 years ago
e86eb71604
Move CWallet::setKeyPool to private section of CWallet
8 years ago
1aacfc2da5
various typos
8 years ago
b3b3c2a562
Reduce cs_main locks during ConnectTip/SyncWithWallets
8 years ago
9578333ec4
Remove rpc_wallet_tests.cpp
8 years ago
21ba407a73
net: narrow include scope after moving to netaddress
...
Net functionality is no longer needed for CAddress/CAddrman/etc. now that
CNetAddr/CService/CSubNet are dumb storage classes.
8 years ago
29c2d99bc9
Make CWallet::fFileBacked private.
8 years ago
5723bb44ce
Remove unused pwalletdb from CWallet::AddToWallet
8 years ago
867f842f1e
Remove CWalletDB* parameter from CWallet::AddToWallet
8 years ago
00f09c920c
Split CWallet::AddToWallet into AddToWallet and LoadToWallet.
...
This removes the fFromLoadWallet flag in AddToWallet. These were already
effectively two methods.
8 years ago
2266b43e33
Port from 0.13: Create a new HD seed after encrypting the wallet
...
Forward-ports two commits from 0.13:
- [0.13] Create a new HD seed after encrypting the wallet
- [Wallet] Add CKeyMetadata record for HDMasterKey(s), factor out HD key generation
Github-Pull: #8389
Rebased-From: f142c11ac6de45c065f0
8 years ago
77c912d21c
[Wallet] add HD xpriv to dumpwallet
8 years ago
b50e1ac298
[Wallet] Correct hdmasterkeyid/masterkeyid name confusion
8 years ago
6523fcaab2
Move SetMinVersion for FEATURE_HD to SetHDMasterKey
8 years ago
a4f137f367
[Wallet] Ensure <0.13 clients can't open HD wallets
9 years ago
2c06bae39e
Rename "block cost" to "block weight"
9 years ago
7945088d41
[Wallet] comsetic non-code changes for the HD feature
9 years ago
68d7682b9f
[Wallet] ensure CKeyMetadata.hdMasterKeyID will be cleared during SetNull()
9 years ago
b993671921
[Wallet] keep HD seed during salvagewallet
9 years ago
986c223214
[Wallet] print hd masterkeyid in getwalletinfo
9 years ago
5b95dd2c25
[Wallet] extend CKeyMetadata with HD keypath
9 years ago
477777f250
[rpcwallet] Don't use floating point
9 years ago
20f3cd75f6
wallet: Revert input selection post-pruning
...
This reverts PR #4906 , "Coinselection prunes extraneous inputs from
ApproximateBestSubset".
Apparently the previous behavior of slightly over-estimating the set of
inputs was useful in cleaning up UTXOs.
See also #7664 , #7657 , as well as 2016-07-01 discussion on #bitcoin-core-dev IRC.
9 years ago
a1c92c29fd
trivial: capitalize BIP32 in option help
...
For consistency, BIP32 should be in uppercase in translation message.
Reported by @pryds on Transifex.
9 years ago
4f7ff00497
[qa] Add rpc test for segwit
...
Amended by Pieter Wuille to use multisig 1-of-1 for P2WSH tests, and BIP9
based switchover logic.
Fixes and py3 conversion by Marco Falke.
9 years ago
f4691ab3a9
[RPC] Add wallet support for witness transactions (using P2SH)
...
Includes support for pushkeyhash wit v0 by Alex Morcos.
9 years ago
605e8473a7
BIP143: Signing logic
9 years ago
2b1f6f9ccf
BIP141: Other consensus critical limits, and BIP145
...
Includes changes by Suhas Daftuar, Luke-jr, and mruddy.
9 years ago
7030d9eb47
BIP144: Serialization, hashes, relay (sender side)
...
Contains refactorings by Eric Lombrozo.
Contains fixup by Nicolas Dorier.
Contains cleanup of CInv::GetCommand by Alex Morcos
9 years ago
faa91b12f7
[wallet] tests: Don't use floating point
9 years ago
afcd77e179
Detect -usehd mismatches when wallet.dat already exists
9 years ago
d096d22446
build: Get rid of `CLIENT_DATE`
...
Putting the build date in the executable is a practice that has no place
in these days, now that deterministic building is increasingly common.
Continues #7732 which did this for the GUI.
9 years ago
77f63a4fcd
Fix two warnings for comparison between signed and unsigned
9 years ago
fa7f4f577c
[rpc] fundrawtransaction feeRate: Use BTC/kB
...
Also introduce UniValueType
UniValueType is a wrapper for UniValue::VType which allows setting
a typeAny flag. This flag indicates the type does not matter.
(Used by RPCTypeCheckObj)
9 years ago
faf82e8fc8
[rpc] fundrawtransaction: Fix help text and interface
9 years ago
152ab236ea
Improve CWallet API with new GetAccountPubkey function.
...
Remove one more caller that is passing CWalletDB.
9 years ago
595b22e5c0
Stop treating importaddress'ed scripts as change
...
Before this, if someone imported a scriptPubKey directly (in hex form) using
importaddress, outputs sending to it would be treated as change, as the
corresponding CTxDestination was not added to the address book.
Fix this by trying to detect scriptPubKeys that are in fact convertible to a
CTxDestination and add them anyway. Add a warning to the RPC help to warn
against importing raw non-standard scripts.
9 years ago
9dfaa1cb70
Improve CWallet API with new AccountMove function.
9 years ago
c022e5b15d
[Wallet] use constant for bip32 hardened key limit
9 years ago
f19025106d
[Wallet] Add simplest BIP32/deterministic key generation implementation
9 years ago
Pavel Janík