|
|
@ -186,7 +186,7 @@ In general, all pull requests must: |
|
|
|
the project (for example refactoring for modularisation); |
|
|
|
the project (for example refactoring for modularisation); |
|
|
|
- Be well peer reviewed; |
|
|
|
- Be well peer reviewed; |
|
|
|
- Have unit tests and functional tests where appropriate; |
|
|
|
- Have unit tests and functional tests where appropriate; |
|
|
|
- Follow code style guidelines; |
|
|
|
- Follow code style guidelines ([C++](doc/developer-notes.md), [functional tests](test/functional/README.md)); |
|
|
|
- Not break the existing test suite; |
|
|
|
- Not break the existing test suite; |
|
|
|
- Where bugs are fixed, where possible, there should be unit tests |
|
|
|
- Where bugs are fixed, where possible, there should be unit tests |
|
|
|
demonstrating the bug and also proving the fix. This helps prevent regression. |
|
|
|
demonstrating the bug and also proving the fix. This helps prevent regression. |
|
|
|