Browse Source

Net: Fix resource leak in ReadBinaryFile(...)

Introduced in 0b6f40d4ca via PR #10408.
0.15
practicalswift 8 years ago
parent
commit
f2fb132cb0
  1. 4
      src/torcontrol.cpp

4
src/torcontrol.cpp

@ -376,8 +376,10 @@ static std::pair<bool,std::string> ReadBinaryFile(const fs::path &filename, size @@ -376,8 +376,10 @@ static std::pair<bool,std::string> ReadBinaryFile(const fs::path &filename, size
while ((n=fread(buffer, 1, sizeof(buffer), f)) > 0) {
// Check for reading errors so we don't return any data if we couldn't
// read the entire file (or up to maxsize)
if (ferror(f))
if (ferror(f)) {
fclose(f);
return std::make_pair(false,"");
}
retval.append(buffer, buffer+n);
if (retval.size() > maxsize)
break;

Loading…
Cancel
Save