From f2fb132cb09efb253df44db09035d4210cc61236 Mon Sep 17 00:00:00 2001 From: practicalswift Date: Wed, 14 Jun 2017 17:32:45 +0200 Subject: [PATCH] Net: Fix resource leak in ReadBinaryFile(...) Introduced in 0b6f40d4cabb3bebf551a49a69ce36d4b0375b6a via PR #10408. --- src/torcontrol.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/torcontrol.cpp b/src/torcontrol.cpp index 188300516..eb0722cd8 100644 --- a/src/torcontrol.cpp +++ b/src/torcontrol.cpp @@ -376,8 +376,10 @@ static std::pair ReadBinaryFile(const fs::path &filename, size while ((n=fread(buffer, 1, sizeof(buffer), f)) > 0) { // Check for reading errors so we don't return any data if we couldn't // read the entire file (or up to maxsize) - if (ferror(f)) + if (ferror(f)) { + fclose(f); return std::make_pair(false,""); + } retval.append(buffer, buffer+n); if (retval.size() > maxsize) break;