Browse Source

Merge #10786: Add PR description to merge commit in github-merge.py

475c08c Add PR description to merge commit in github-merge.py (Pieter Wuille)

Pull request description:

  There is often some context given in PR descriptions that is missing from commits, and it may be worthwhile to retain that information in our history in git. This PR adds that information to the merge commit when created through `github-merge.py`.

  We should also encourage people to provide as much information as possible in the PR commits themselves, but I believe that is an orthogonal issue. Individual commits don't need to have a description of the overall goal of a PR.

Tree-SHA512: cbae46ec24ce911744e11a07e5d51895d3acc79659db306d8124304ef8e422bba99001ee2a741b08c92a5eb39d9c3f6b723622b20d6553ca5cfa0a8de866194c
0.15
Wladimir J. van der Laan 8 years ago
parent
commit
ca4c545cc7
No known key found for this signature in database
GPG Key ID: 1E4AED62986CD25D
  1. 2
      contrib/devtools/github-merge.py

2
contrib/devtools/github-merge.py

@ -175,6 +175,7 @@ def main():
if info is None: if info is None:
exit(1) exit(1)
title = info['title'].strip() title = info['title'].strip()
body = info['body'].strip()
# precedence order for destination branch argument: # precedence order for destination branch argument:
# - command line argument # - command line argument
# - githubmerge.branch setting # - githubmerge.branch setting
@ -229,6 +230,7 @@ def main():
firstline = 'Merge #%s' % (pull,) firstline = 'Merge #%s' % (pull,)
message = firstline + '\n\n' message = firstline + '\n\n'
message += subprocess.check_output([GIT,'log','--no-merges','--topo-order','--pretty=format:%h %s (%an)',base_branch+'..'+head_branch]).decode('utf-8') message += subprocess.check_output([GIT,'log','--no-merges','--topo-order','--pretty=format:%h %s (%an)',base_branch+'..'+head_branch]).decode('utf-8')
message += '\n\nPull request description:\n\n ' + body.replace('\n', '\n ') + '\n'
try: try:
subprocess.check_call([GIT,'merge','-q','--commit','--no-edit','--no-ff','-m',message.encode('utf-8'),head_branch]) subprocess.check_call([GIT,'merge','-q','--commit','--no-edit','--no-ff','-m',message.encode('utf-8'),head_branch])
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:

Loading…
Cancel
Save