kvazar
/
kevacoin
mirror of https://github.com/kvazar-network/kevacoin.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Merge #11577: Fix warnings (-Wsign-compare) when building with DEBUG_ADDRMAN 

6eddd43 Fix warnings when building with DEBUG_ADDRMAN (practicalswift)

Pull request description:

  Fix warnings when building with `DEBUG_ADDRMAN`.

  Warnings prior to this commit:

  ```
  addrman.cpp:390:24: warning: comparison of integers of different signs: 'size_type' (aka 'unsigned long') and 'int' [-Wsign-compare]
      if (vRandom.size() != nTried + nNew)
          ~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~
  addrman.cpp:411:52: warning: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [-Wsign-compare]
          if (info.nRandomPos < 0 || info.nRandomPos >= vRandom.size() || vRandom[info.nRandomPos] != n)
                                     ~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~
  addrman.cpp:419:25: warning: comparison of integers of different signs: 'size_type' (aka 'unsigned long') and 'int' [-Wsign-compare]
      if (setTried.size() != nTried)
          ~~~~~~~~~~~~~~~ ^  ~~~~~~
  addrman.cpp:421:23: warning: comparison of integers of different signs: 'size_type' (aka 'unsigned long') and 'int' [-Wsign-compare]
      if (mapNew.size() != nNew)
          ~~~~~~~~~~~~~ ^  ~~~~
  4 warnings generated.
  ```

Tree-SHA512: 0316faecfe95066d2c9a0b6b3960086e43824f21a67086a895ea45fbce1327f8d6df5945fe923c2dbe4efce430bc1384d515d317c3930d97d24965e507cf734d
0.16
Wladimir J. van der Laan 7 years ago
parent
f3c7062b7b 6eddd43e6d
commit
c0ae864ef5
No known key found for this signature in database
GPG Key ID: 1E4AED62986CD25D
1 changed files with 4 additions and 4 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 8
      src/addrman.cpp

8
src/addrman.cpp
Unescape View File

@ -387,7 +387,7 @@ int CAddrMan::Check_()
std::set<int> setTried; std::set<int> setTried;
std::map<int, int> mapNew; std::map<int, int> mapNew;
if (vRandom.size() != nTried + nNew) if (vRandom.size() != (size_t)(nTried + nNew))
return -7; return -7;
for (const auto& entry : mapInfo) { for (const auto& entry : mapInfo) {
@ -408,7 +408,7 @@ int CAddrMan::Check_()
} }
if (mapAddr[info] != n) if (mapAddr[info] != n)
return -5; return -5;
if (info.nRandomPos < 0 || info.nRandomPos >= vRandom.size() || vRandom[info.nRandomPos] != n) if (info.nRandomPos < 0 || (size_t)info.nRandomPos >= vRandom.size() || vRandom[info.nRandomPos] != n)
return -14; return -14;
if (info.nLastTry < 0) if (info.nLastTry < 0)
return -6; return -6;
@ -416,9 +416,9 @@ int CAddrMan::Check_()
return -8; return -8;
} }
if (setTried.size() != nTried) if (setTried.size() != (size_t)nTried)
return -9; return -9;
if (mapNew.size() != nNew) if (mapNew.size() != (size_t)nNew)
return -10; return -10;
for (int n = 0; n < ADDRMAN_TRIED_BUCKET_COUNT; n++) { for (int n = 0; n < ADDRMAN_TRIED_BUCKET_COUNT; n++) {

Write Preview
Loading…
Cancel
Save