|
|
|
@ -14,6 +14,7 @@ gradually. |
|
|
|
- No indentation for public/protected/private or for namespaces. |
|
|
|
- No indentation for public/protected/private or for namespaces. |
|
|
|
- No extra spaces inside parenthesis; don't do ( this ) |
|
|
|
- No extra spaces inside parenthesis; don't do ( this ) |
|
|
|
- No space after function names; one space after if, for and while. |
|
|
|
- No space after function names; one space after if, for and while. |
|
|
|
|
|
|
|
- `++i` is preferred over `i++`. |
|
|
|
|
|
|
|
|
|
|
|
Block style example: |
|
|
|
Block style example: |
|
|
|
```c++ |
|
|
|
```c++ |
|
|
|
@ -24,7 +25,7 @@ class Class |
|
|
|
bool Function(char* psz, int n) |
|
|
|
bool Function(char* psz, int n) |
|
|
|
{ |
|
|
|
{ |
|
|
|
// Comment summarising what this section of code does |
|
|
|
// Comment summarising what this section of code does |
|
|
|
for (int i = 0; i < n; i++) { |
|
|
|
for (int i = 0; i < n; ++i) { |
|
|
|
// When something fails, return early |
|
|
|
// When something fails, return early |
|
|
|
if (!Something()) |
|
|
|
if (!Something()) |
|
|
|
return false; |
|
|
|
return false; |
|
|
|
@ -231,9 +232,9 @@ General Bitcoin Core |
|
|
|
- *Rationale*: Makes sure that they pass thorough testing, and that the tester will keep passing |
|
|
|
- *Rationale*: Makes sure that they pass thorough testing, and that the tester will keep passing |
|
|
|
on the master branch. Otherwise all new pull requests will start failing the tests, resulting in |
|
|
|
on the master branch. Otherwise all new pull requests will start failing the tests, resulting in |
|
|
|
confusion and mayhem |
|
|
|
confusion and mayhem |
|
|
|
|
|
|
|
|
|
|
|
- *Explanation*: If the test suite is to be updated for a change, this has to |
|
|
|
- *Explanation*: If the test suite is to be updated for a change, this has to |
|
|
|
be done first |
|
|
|
be done first |
|
|
|
|
|
|
|
|
|
|
|
Wallet |
|
|
|
Wallet |
|
|
|
------- |
|
|
|
------- |
|
|
|
|
Wladimir J. van der Laan
8 years ago