Browse Source

Return txid even if ATMP fails for new transaction

0.14
Pieter Wuille 8 years ago
parent
commit
b3a74100b8
  1. 8
      src/wallet/wallet.cpp

8
src/wallet/wallet.cpp

@ -2580,11 +2580,11 @@ bool CWallet::CommitTransaction(CWalletTx& wtxNew, CReserveKey& reservekey, CCon
{ {
// Broadcast // Broadcast
if (!wtxNew.AcceptToMemoryPool(maxTxFee, state)) { if (!wtxNew.AcceptToMemoryPool(maxTxFee, state)) {
// This must not fail. The transaction has already been signed and recorded. LogPrintf("CommitTransaction(): Transaction cannot be broadcast immediately, %s\n", state.GetRejectReason());
LogPrintf("CommitTransaction(): Error: Transaction not valid, %s\n", state.GetRejectReason()); // TODO: if we expect the failure to be long term or permanent, instead delete wtx from the wallet and return failure.
return false; } else {
wtxNew.RelayWalletTransaction(connman);
} }
wtxNew.RelayWalletTransaction(connman);
} }
} }
return true; return true;

Loading…
Cancel
Save