Merge pull request #5559

e179eb3 Make the command-line-args dialog better (Thomas Zander)

src/qt/forms/helpmessagedialog.ui

@@ -6,8 +6,8 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>800</width>
+    <width>585</width>
-    <height>400</height>
+    <height>225</height>
    </rect>
   </property>
   <property name="font">
@@ -34,6 +34,13 @@
    </item>
    <item>
     <layout class="QVBoxLayout" name="verticalLayout">
+     <item>
+      <widget class="QTextEdit" name="helpMessage">
+       <property name="readOnly">
+        <bool>true</bool>
+       </property>
+      </widget>
+     </item>
      <item>
       <widget class="QScrollArea" name="scrollArea">
        <property name="verticalScrollBarPolicy">
@@ -47,19 +54,22 @@
          <rect>
           <x>0</x>
           <y>0</y>
-          <width>659</width>
+          <width>447</width>
-          <height>348</height>
+          <height>68</height>
          </rect>
         </property>
         <layout class="QVBoxLayout" name="verticalLayout_2">
          <item>
-          <widget class="QLabel" name="helpMessageLabel">
+          <widget class="QLabel" name="aboutMessage">
            <property name="cursor">
             <cursorShape>IBeamCursor</cursorShape>
            </property>
            <property name="textFormat">
             <enum>Qt::PlainText</enum>
            </property>
+           <property name="alignment">
+            <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set>
+           </property>
            <property name="openExternalLinks">
             <bool>true</bool>
            </property>

src/qt/utilitydialog.cpp

@@ -18,6 +18,8 @@
 #include <QCloseEvent>
 #include <QLabel>
 #include <QRegExp>
+#include <QTextTable>
+#include <QTextCursor>
 #include <QVBoxLayout>
 
 /** "Help message" or "About" dialog box */
@@ -52,28 +54,82 @@ HelpMessageDialog::HelpMessageDialog(QWidget *parent, bool about) :
         // Replace newlines with HTML breaks
         licenseInfoHTML.replace("\n\n", "<br><br>");
 
-        ui->helpMessageLabel->setTextFormat(Qt::RichText);
+        ui->aboutMessage->setTextFormat(Qt::RichText);
         ui->scrollArea->setVerticalScrollBarPolicy(Qt::ScrollBarAsNeeded);
         text = version + "\n" + licenseInfo;
-        ui->helpMessageLabel->setText(version + "<br><br>" + licenseInfoHTML);
+        ui->aboutMessage->setText(version + "<br><br>" + licenseInfoHTML);
-        ui->helpMessageLabel->setWordWrap(true);
+        ui->aboutMessage->setWordWrap(true);
+        ui->helpMessage->setVisible(false);
     } else {
         setWindowTitle(tr("Command-line options"));
-        QString header = tr("Usage:") + "\n" +
+        QTextCursor cursor(ui->helpMessage->document());
-            "  bitcoin-qt [" + tr("command-line options") + "]                     " + "\n";
+        cursor.insertText(version);
+        cursor.insertBlock();
+        cursor.insertText(tr("Usage:") + '\n' +
+            "  bitcoin-qt [" + tr("command-line options") + "]\n");
+
+        cursor.insertBlock();
+        QTextTableFormat tf;
+        tf.setBorderStyle(QTextFrameFormat::BorderStyle_None);
+        tf.setCellPadding(2);
+        QVector<QTextLength> widths;
+        widths << QTextLength(QTextLength::PercentageLength, 20);
+        widths << QTextLength(QTextLength::PercentageLength, 80);
+        tf.setColumnWidthConstraints(widths);
+        QTextTable *table = cursor.insertTable(2, 2, tf);
 
         QString coreOptions = QString::fromStdString(HelpMessage(HMM_BITCOIN_QT));
-
+        bool first = true;
-        QString uiOptions = tr("UI options") + ":\n" +
+        QTextCharFormat bold;
-            "  -choosedatadir            " + tr("Choose data directory on startup (default: 0)") + "\n" +
+        bold.setFontWeight(QFont::Bold);
-            "  -lang=<lang>              " + tr("Set language, for example \"de_DE\" (default: system locale)") + "\n" +
+        // note that coreOptions is not translated.
-            "  -min                      " + tr("Start minimized") + "\n" +
+        foreach (const QString &line, coreOptions.split('\n')) {
-            "  -rootcertificates=<file>  " + tr("Set SSL root certificates for payment request (default: -system-)") + "\n" +
+            if (!first) {
-            "  -splash                   " + tr("Show splash screen on startup (default: 1)");
+                table->appendRows(1);
-
+                cursor.movePosition(QTextCursor::NextRow);
-        ui->helpMessageLabel->setFont(GUIUtil::bitcoinAddressFont());
+            }
-        text = version + "\n" + header + "\n" + coreOptions + "\n" + uiOptions;
+            first = false;
-        ui->helpMessageLabel->setText(text);
+
+            if (line.startsWith("  ")) {
+                int index = line.indexOf(' ', 3);
+                if (index > 0) {
+                    cursor.insertText(line.left(index).trimmed());
+                    cursor.movePosition(QTextCursor::NextCell);
+                    cursor.insertText(line.mid(index).trimmed());
+                    continue;
+                }
+            }
+            cursor.movePosition(QTextCursor::NextCell, QTextCursor::KeepAnchor);
+            table->mergeCells(cursor);
+            cursor.insertText(line.trimmed(), bold);
+        }
+
+        table->appendRows(6);
+        cursor.movePosition(QTextCursor::NextRow);
+        cursor.insertText(tr("UI options") + ":", bold);
+        cursor.movePosition(QTextCursor::NextRow);
+        cursor.insertText("-choosedatadir");
+        cursor.movePosition(QTextCursor::NextCell);
+        cursor.insertText(tr("Choose data directory on startup (default: 0)"));
+        cursor.movePosition(QTextCursor::NextCell);
+        cursor.insertText("-lang=<lang>");
+        cursor.movePosition(QTextCursor::NextCell);
+        cursor.insertText(tr("Set language, for example \"de_DE\" (default: system locale)"));
+        cursor.movePosition(QTextCursor::NextCell);
+        cursor.insertText("-min");
+        cursor.movePosition(QTextCursor::NextCell);
+        cursor.insertText(tr("Start minimized"));
+        cursor.movePosition(QTextCursor::NextCell);
+        cursor.insertText("-rootcertificates=<file>");
+        cursor.movePosition(QTextCursor::NextCell);
+        cursor.insertText(tr("Set SSL root certificates for payment request (default: -system-)"));
+        cursor.movePosition(QTextCursor::NextCell);
+        cursor.insertText("-splash");
+        cursor.movePosition(QTextCursor::NextCell);
+        cursor.insertText(tr("Show splash screen on startup (default: 1)"));
+
+        ui->helpMessage->moveCursor(QTextCursor::Start);
+        ui->scrollArea->setVisible(false);
     }
 }