From 61977f956c6bacd6e05e3211bf2a90e5b5672a94 Mon Sep 17 00:00:00 2001 From: Gavin Andresen Date: Sun, 25 Dec 2011 10:32:05 -0500 Subject: [PATCH] Check all prevout.n if one transaction provides multiple inputs --- src/main.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/main.cpp b/src/main.cpp index 0277f5fa7..15f047bf7 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -945,10 +945,18 @@ bool CTransaction::FetchInputs(CTxDB& txdb, const map& mapTes if (!txPrev.ReadFromDisk(txindex.pos)) return error("FetchInputs() : %s ReadFromDisk prev tx %s failed", GetHash().ToString().substr(0,10).c_str(), prevout.hash.ToString().substr(0,10).c_str()); } + } + + // Make sure all prevout.n's are valid: + for (int i = 0; i < vin.size(); i++) + { + const COutPoint prevout = vin[i].prevout; + const CTxIndex& txindex = inputsRet[prevout.hash].first; + const CTransaction& txPrev = inputsRet[prevout.hash].second; if (prevout.n >= txPrev.vout.size() || prevout.n >= txindex.vSpent.size()) return DoS(100, error("FetchInputs() : %s prevout.n out of range %d %d %d prev tx %s\n%s", GetHash().ToString().substr(0,10).c_str(), prevout.n, txPrev.vout.size(), txindex.vSpent.size(), prevout.hash.ToString().substr(0,10).c_str(), txPrev.ToString().c_str())); - } + return true; }