Browse Source

QA: stop nodes after RPC tests, even with --nocleanup

`--nocleanup` should provide a way to preserve test data, but should not have an impact on whether nodes are to be stopped after the test execution.

In particular, when currently running RPC tests with `--nocleanup`, then it may result in several active `bitcoind` processes, which are not terminated properly.
0.13
dexX7 10 years ago
parent
commit
2eadeb27ed
No known key found for this signature in database
GPG Key ID: 7675E31CF5719832
  1. 6
      qa/rpc-tests/test_framework.py

6
qa/rpc-tests/test_framework.py

@ -128,10 +128,12 @@ class BitcoinTestFramework(object):
print("Unexpected exception caught during testing: "+str(e)) print("Unexpected exception caught during testing: "+str(e))
traceback.print_tb(sys.exc_info()[2]) traceback.print_tb(sys.exc_info()[2])
if not self.options.nocleanup: print("Stopping nodes")
print("Cleaning up")
stop_nodes(self.nodes) stop_nodes(self.nodes)
wait_bitcoinds() wait_bitcoinds()
if not self.options.nocleanup:
print("Cleaning up")
shutil.rmtree(self.options.tmpdir) shutil.rmtree(self.options.tmpdir)
if success: if success:

Loading…
Cancel
Save