Browse Source

Merge #10825: net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332

ce3baa193 changed regtest RPCport to 18443 to avoid conflict with testnet 18332 (Ferdinando M. Ametrano)

Pull request description:

  using the same JSON-RPC default port for both testnet and regtest prevents running both at the same time on the same machine. Since RPCport=P2Pport-1 for both mainnet and testnet, and regtest P2Pport being 18444, 18443 is proposed for regtest RPCport

  Documentation has been updated (or created where missing); manpages doc/man/bitcoin*.1 could include information for regtest too

Tree-SHA512: d42185f7ef54dc918ece19b543c8681d08bb9c5a971394e21f2d9a1091734b091b08df69fab622c207b46f402cf9323ded5b7a33fbd0af722388930169124e7f
0.16
Wladimir J. van der Laan 7 years ago
parent
commit
28485c783d
No known key found for this signature in database
GPG Key ID: 1E4AED62986CD25D
  1. 7
      contrib/linearize/example-linearize.cfg
  2. 4
      contrib/rpm/bitcoin.spec
  3. 3
      doc/REST-interface.md
  4. 2
      src/chainparamsbase.cpp

7
contrib/linearize/example-linearize.cfg

@ -3,9 +3,16 @@ rpcuser=someuser
rpcpassword=somepassword rpcpassword=somepassword
#datadir=~/.bitcoin #datadir=~/.bitcoin
host=127.0.0.1 host=127.0.0.1
#mainnet default
port=8332 port=8332
#testnet default
#port=18332 #port=18332
#regtest default
#port=18443
# bootstrap.dat hashlist settings (linearize-hashes) # bootstrap.dat hashlist settings (linearize-hashes)
max_height=313000 max_height=313000

4
contrib/rpm/bitcoin.spec

@ -336,6 +336,8 @@ done
%{_sbindir}/semanage port -a -t bitcoin_port_t -p tcp 8333 %{_sbindir}/semanage port -a -t bitcoin_port_t -p tcp 8333
%{_sbindir}/semanage port -a -t bitcoin_port_t -p tcp 18332 %{_sbindir}/semanage port -a -t bitcoin_port_t -p tcp 18332
%{_sbindir}/semanage port -a -t bitcoin_port_t -p tcp 18333 %{_sbindir}/semanage port -a -t bitcoin_port_t -p tcp 18333
%{_sbindir}/semanage port -a -t bitcoin_port_t -p tcp 18443
%{_sbindir}/semanage port -a -t bitcoin_port_t -p tcp 18444
%{_sbindir}/fixfiles -R bitcoin-server restore &> /dev/null || : %{_sbindir}/fixfiles -R bitcoin-server restore &> /dev/null || :
%{_sbindir}/restorecon -R %{_localstatedir}/lib/bitcoin || : %{_sbindir}/restorecon -R %{_localstatedir}/lib/bitcoin || :
fi fi
@ -355,6 +357,8 @@ if [ $1 -eq 0 ]; then
%{_sbindir}/semanage port -d -p tcp 8333 %{_sbindir}/semanage port -d -p tcp 8333
%{_sbindir}/semanage port -d -p tcp 18332 %{_sbindir}/semanage port -d -p tcp 18332
%{_sbindir}/semanage port -d -p tcp 18333 %{_sbindir}/semanage port -d -p tcp 18333
%{_sbindir}/semanage port -d -p tcp 18443
%{_sbindir}/semanage port -d -p tcp 18444
for selinuxvariant in %{selinux_variants}; do for selinuxvariant in %{selinux_variants}; do
%{_sbindir}/semodule -s ${selinuxvariant} -r bitcoin &> /dev/null || : %{_sbindir}/semodule -s ${selinuxvariant} -r bitcoin &> /dev/null || :
done done

3
doc/REST-interface.md

@ -3,7 +3,8 @@ Unauthenticated REST Interface
The REST API can be enabled with the `-rest` option. The REST API can be enabled with the `-rest` option.
The interface runs on the same port as the JSON-RPC interface, by default port 8332 for mainnet and port 18332 for testnet. The interface runs on the same port as the JSON-RPC interface, by default port 8332 for mainnet, port 18332 for testnet,
and port 18443 for regtest.
Supported API Supported API
------------- -------------

2
src/chainparamsbase.cpp

@ -57,7 +57,7 @@ class CBaseRegTestParams : public CBaseChainParams
public: public:
CBaseRegTestParams() CBaseRegTestParams()
{ {
nRPCPort = 18332; nRPCPort = 18443;
strDataDir = "regtest"; strDataDir = "regtest";
} }
}; };

Loading…
Cancel
Save