From 27617b446b4a469a7228b5a370e2c9dcff9c1a3b Mon Sep 17 00:00:00 2001 From: Jianping Wu Date: Fri, 15 Mar 2019 18:15:38 -0700 Subject: [PATCH] Fixed CN error messages for mining. --- src/Makefile.am | 4 +-- src/Makefile.bench.include | 3 +- src/Makefile.qt.include | 2 +- src/Makefile.qttest.include | 2 +- src/Makefile.test.include | 6 ++-- src/httprpc.cpp | 8 ++++- src/rpc/mining.cpp | 68 ++++++++++++++++++++++++------------- 7 files changed, 59 insertions(+), 34 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index ecbb3b8e4..ac7063ff5 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -54,12 +54,12 @@ $(LIBSECP256K1): $(wildcard secp256k1/src/*) $(wildcard secp256k1/include/*) EXTRA_LIBRARIES += \ $(LIBBITCOIN_CRYPTO) \ $(LIBBITCOIN_UTIL) \ - $(LIBBITCOIN_CNUTILS) \ $(LIBBITCOIN_COMMON) \ $(LIBBITCOIN_CONSENSUS) \ $(LIBBITCOIN_SERVER) \ $(LIBBITCOIN_CLI) \ $(LIBBITCOIN_WALLET) \ + $(LIBBITCOIN_CNUTILS) \ $(LIBBITCOIN_ZMQ) lib_LTLIBRARIES = $(LIBBITCOINCONSENSUS) @@ -457,11 +457,11 @@ kevacoind_LDADD = \ $(LIBBITCOIN_COMMON) \ $(LIBUNIVALUE) \ $(LIBBITCOIN_UTIL) \ - $(LIBBITCOIN_CNUTILS) \ $(LIBBITCOIN_WALLET) \ $(LIBBITCOIN_ZMQ) \ $(LIBBITCOIN_CONSENSUS) \ $(LIBBITCOIN_CRYPTO) \ + $(LIBBITCOIN_CNUTILS) \ $(LIBLEVELDB) \ $(LIBLEVELDB_SSE42) \ $(LIBMEMENV) \ diff --git a/src/Makefile.bench.include b/src/Makefile.bench.include index fd7195458..42a55b078 100644 --- a/src/Makefile.bench.include +++ b/src/Makefile.bench.include @@ -37,7 +37,6 @@ bench_bench_kevacoin_LDADD = \ $(LIBBITCOIN_SERVER) \ $(LIBBITCOIN_COMMON) \ $(LIBBITCOIN_UTIL) \ - $(LIBBITCOIN_CNUTILS) \ $(LIBBITCOIN_CONSENSUS) \ $(LIBBITCOIN_CRYPTO) \ $(LIBLEVELDB) \ @@ -55,7 +54,7 @@ bench_bench_kevacoin_SOURCES += bench/coin_selection.cpp bench_bench_kevacoin_LDADD += $(LIBBITCOIN_WALLET) $(LIBBITCOIN_CONSENSUS) $(LIBBITCOIN_CRYPTO) endif -bench_bench_kevacoin_LDADD += $(BOOST_LIBS) $(BDB_LIBS) $(SSL_LIBS) $(CRYPTO_LIBS) $(MINIUPNPC_LIBS) $(EVENT_PTHREADS_LIBS) $(EVENT_LIBS) +bench_bench_kevacoin_LDADD += $(BOOST_LIBS) $(BDB_LIBS) $(SSL_LIBS) $(CRYPTO_LIBS) $(MINIUPNPC_LIBS) $(EVENT_PTHREADS_LIBS) $(EVENT_LIBS) $(LIBBITCOIN_CNUTILS) bench_bench_kevacoin_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) CLEAN_BITCOIN_BENCH = bench/*.gcda bench/*.gcno $(GENERATED_BENCH_FILES) diff --git a/src/Makefile.qt.include b/src/Makefile.qt.include index c332f362f..7f8bc1c6d 100644 --- a/src/Makefile.qt.include +++ b/src/Makefile.qt.include @@ -436,7 +436,7 @@ endif if ENABLE_ZMQ qt_kevacoin_qt_LDADD += $(LIBBITCOIN_ZMQ) $(ZMQ_LIBS) endif -qt_kevacoin_qt_LDADD += $(LIBBITCOIN_CLI) $(LIBBITCOIN_COMMON) $(LIBBITCOIN_UTIL) $(LIBBITCOIN_CNUTILS) $(LIBBITCOIN_CONSENSUS) $(LIBBITCOIN_CRYPTO) $(LIBUNIVALUE) $(LIBLEVELDB) $(LIBLEVELDB_SSE42) $(LIBMEMENV) \ +qt_kevacoin_qt_LDADD += $(LIBBITCOIN_CLI) $(LIBBITCOIN_COMMON) $(LIBBITCOIN_UTIL) $(LIBBITCOIN_CONSENSUS) $(LIBBITCOIN_CRYPTO) $(LIBUNIVALUE) $(LIBBITCOIN_CNUTILS) $(LIBLEVELDB) $(LIBLEVELDB_SSE42) $(LIBMEMENV) \ $(BOOST_LIBS) $(QT_LIBS) $(QT_DBUS_LIBS) $(QR_LIBS) $(PROTOBUF_LIBS) $(BDB_LIBS) $(SSL_LIBS) $(CRYPTO_LIBS) $(MINIUPNPC_LIBS) $(LIBSECP256K1) \ $(EVENT_PTHREADS_LIBS) $(EVENT_LIBS) qt_kevacoin_qt_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(QT_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) diff --git a/src/Makefile.qttest.include b/src/Makefile.qttest.include index 732662b22..99ce7d571 100644 --- a/src/Makefile.qttest.include +++ b/src/Makefile.qttest.include @@ -57,7 +57,7 @@ endif if ENABLE_ZMQ qt_test_test_kevacoin_qt_LDADD += $(LIBBITCOIN_ZMQ) $(ZMQ_LIBS) endif -qt_test_test_kevacoin_qt_LDADD += $(LIBBITCOIN_CLI) $(LIBBITCOIN_COMMON) $(LIBBITCOIN_UTIL) $(LIBBITCOIN_CNUTILS) $(LIBBITCOIN_CONSENSUS) $(LIBBITCOIN_CRYPTO) $(LIBUNIVALUE) $(LIBLEVELDB) \ +qt_test_test_kevacoin_qt_LDADD += $(LIBBITCOIN_CLI) $(LIBBITCOIN_COMMON) $(LIBBITCOIN_UTIL) $(LIBBITCOIN_CONSENSUS) $(LIBBITCOIN_CRYPTO) $(LIBUNIVALUE) $(LIBLEVELDB) $(LIBBITCOIN_CNUTILS) \ $(LIBLEVELDB_SSE42) $(LIBMEMENV) $(BOOST_LIBS) $(QT_DBUS_LIBS) $(QT_TEST_LIBS) $(QT_LIBS) \ $(QR_LIBS) $(PROTOBUF_LIBS) $(BDB_LIBS) $(SSL_LIBS) $(CRYPTO_LIBS) $(MINIUPNPC_LIBS) $(LIBSECP256K1) \ $(EVENT_PTHREADS_LIBS) $(EVENT_LIBS) diff --git a/src/Makefile.test.include b/src/Makefile.test.include index e03cf7e9a..171df7545 100644 --- a/src/Makefile.test.include +++ b/src/Makefile.test.include @@ -104,7 +104,7 @@ test_test_kevacoin_LDADD = if ENABLE_WALLET test_test_kevacoin_LDADD += $(LIBBITCOIN_WALLET) endif -test_test_kevacoin_LDADD += $(LIBBITCOIN_SERVER) $(LIBBITCOIN_CLI) $(LIBBITCOIN_COMMON) $(LIBBITCOIN_UTIL) $(LIBBITCOIN_CNUTILS) $(LIBBITCOIN_CONSENSUS) $(LIBBITCOIN_CRYPTO) $(LIBUNIVALUE) \ +test_test_kevacoin_LDADD += $(LIBBITCOIN_SERVER) $(LIBBITCOIN_CLI) $(LIBBITCOIN_COMMON) $(LIBBITCOIN_UTIL) $(LIBBITCOIN_CONSENSUS) $(LIBBITCOIN_CRYPTO) $(LIBUNIVALUE) $(LIBBITCOIN_CNUTILS) \ $(LIBLEVELDB) $(LIBLEVELDB_SSE42) $(LIBMEMENV) $(BOOST_LIBS) $(BOOST_UNIT_TEST_FRAMEWORK_LIB) $(LIBSECP256K1) $(EVENT_LIBS) $(EVENT_PTHREADS_LIBS) test_test_kevacoin_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) @@ -127,10 +127,10 @@ test_test_kevacoin_fuzzy_LDADD = \ $(LIBBITCOIN_SERVER) \ $(LIBBITCOIN_COMMON) \ $(LIBBITCOIN_UTIL) \ - $(LIBBITCOIN_CNUTILS) \ $(LIBBITCOIN_CONSENSUS) \ $(LIBBITCOIN_CRYPTO) \ - $(LIBSECP256K1) + $(LIBSECP256K1) \ + $(LIBBITCOIN_CNUTILS) test_test_kevacoin_fuzzy_LDADD += $(BOOST_LIBS) $(CRYPTO_LIBS) # diff --git a/src/httprpc.cpp b/src/httprpc.cpp index 1d0cfcc55..a4da3df87 100644 --- a/src/httprpc.cpp +++ b/src/httprpc.cpp @@ -77,6 +77,12 @@ static void JSONErrorReply(HTTPRequest* req, const UniValue& objError, const Uni else if (code == RPC_METHOD_NOT_FOUND) nStatus = HTTP_NOT_FOUND; + // Cryptonote error message, the status code is OK. + UniValue cn_code = find_value(objError, "cn_code"); + if (!cn_code.isNull()) { + nStatus = HTTP_OK; + } + std::string strReply = JSONRPCReply(NullUniValue, objError, id); req->WriteHeader("Content-Type", "application/json"); @@ -86,7 +92,7 @@ static void JSONErrorReply(HTTPRequest* req, const UniValue& objError, const Uni //This function checks username and password against -rpcauth //entries from config file. static bool multiUserAuthorized(std::string strUserPass) -{ +{ if (strUserPass.find(':') == std::string::npos) { return false; } diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp index 4bab920ff..171ba1c6b 100644 --- a/src/rpc/mining.cpp +++ b/src/rpc/mining.cpp @@ -270,6 +270,32 @@ UniValue prioritisetransaction(const JSONRPCRequest& request) return true; } +//--------------------------------------------------------------- +// Cryptonote error codes + +#define CORE_RPC_ERROR_CODE_WRONG_PARAM -1 +#define CORE_RPC_ERROR_CODE_TOO_BIG_HEIGHT -2 +#define CORE_RPC_ERROR_CODE_TOO_BIG_RESERVE_SIZE -3 +#define CORE_RPC_ERROR_CODE_WRONG_WALLET_ADDRESS -4 +#define CORE_RPC_ERROR_CODE_INTERNAL_ERROR -5 +#define CORE_RPC_ERROR_CODE_WRONG_BLOCKBLOB -6 +#define CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED -7 +#define CORE_RPC_ERROR_CODE_CORE_BUSY -9 +#define CORE_RPC_ERROR_CODE_WRONG_BLOCKBLOB_SIZE -10 +#define CORE_RPC_ERROR_CODE_UNSUPPORTED_RPC -11 +#define CORE_RPC_ERROR_CODE_MINING_TO_SUBADDRESS -12 +#define CORE_RPC_ERROR_CODE_REGTEST_REQUIRED -13 + +// Cryptonote error response +UniValue CN_JSONRPCError(int code, const std::string& message) +{ + UniValue error(UniValue::VOBJ); + // Indicate that this is cryptonote error. + error.push_back(Pair("cn_code", code)); + error.push_back(Pair("code", code)); + error.push_back(Pair("message", message)); + return error; +} // NOTE: Assumes a conclusive result; if result is inconclusive, it must be handled by caller static UniValue BIP22ValidationResult(const CValidationState& state) @@ -279,15 +305,15 @@ static UniValue BIP22ValidationResult(const CValidationState& state) std::string strRejectReason = state.GetRejectReason(); if (state.IsError()) - throw JSONRPCError(RPC_VERIFY_ERROR, strRejectReason); + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED, strRejectReason); if (state.IsInvalid()) { if (strRejectReason.empty()) - return "rejected"; - return strRejectReason; + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED, "rejected"); + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED, strRejectReason); } // Should be impossible - return "valid?"; + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED, "valid?"); } std::string gbt_vb_name(const Consensus::DeploymentPos pos) { @@ -605,40 +631,35 @@ static uint256 CryptoHashToUint256(const crypto::hash& hash) return uint256(prev_id); } -// Cryptonote RPC call, only one parameter allowed. +// Cryptonote RPC call UniValue submitblock(const JSONRPCRequest& request) { if (request.fHelp || request.params.size() != 1) { throw std::runtime_error( "submitblock \"hexdata\"\n" "\nAttempts to submit new block to network.\n" - "See https://en.bitcoin.it/wiki/BIP_0022 for full specification.\n" "\nArguments\n" "1. \"hexdata\" (string, required) the hex-encoded block data to submit\n" - "2. \"dummy\" (optional) dummy value, for compatibility with BIP22. This value is ignored.\n" "\nResult:\n" "\nExamples:\n" + HelpExampleCli("submitblock", "\"mydata\"") - + HelpExampleRpc("submitblock", "\"mydata\"") ); } cryptonote::blobdata blockblob; - if(!epee::string_tools::parse_hexstr_to_binbuff(request.params[0].get_str(), blockblob)) - { - throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "Wrong block blob"); + if(!epee::string_tools::parse_hexstr_to_binbuff(request.params[0].get_str(), blockblob)) { + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_WRONG_BLOCKBLOB, "Wrong block blob"); } cryptonote::block cnblock = AUTO_VAL_INIT(cnblock); - if(!cryptonote::parse_and_validate_block_from_blob(blockblob, cnblock)) - { - throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "Wrong block blob"); + if(!cryptonote::parse_and_validate_block_from_blob(blockblob, cnblock)) { + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_WRONG_BLOCKBLOB, "Wrong block blob"); } cryptonote::tx_extra_keva_block keva_block_blob; if (!cryptonote::get_keva_block_from_extra(cnblock.miner_tx.extra, keva_block_blob)) { - throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "Could not get Kevacoin block"); + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_WRONG_BLOCKBLOB, "Could not get Kevacoin block"); } std::shared_ptr blockptr = std::make_shared(); @@ -649,11 +670,11 @@ UniValue submitblock(const JSONRPCRequest& request) ssBlock >> block; } catch (const std::exception&) { - throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "Failed to deserialize keva block"); + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_WRONG_BLOCKBLOB, "Failed to deserialize keva block"); } if (block.vtx.empty() || !block.vtx[0]->IsCoinBase()) { - throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "Block does not start with a coinbase"); + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_WRONG_BLOCKBLOB, "Block does not start with a coinbase"); } block.cnHeader.major_version = cnblock.major_version; @@ -669,10 +690,9 @@ UniValue submitblock(const JSONRPCRequest& request) uint256 hash = block.GetHash(); // Cryptonote prev_id is used to store the block hash of kevacoin. if (hash != block.cnHeader.prev_id) { - throw JSONRPCError(RPC_VERIFY_ERROR, "Kevacoin block hash does not match cryptnote hash"); + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_WRONG_PARAM, "Kevacoin block hash does not match cryptnote hash"); } - // TODO: fix the return message. bool fBlockPresent = false; { LOCK(cs_main); @@ -680,10 +700,10 @@ UniValue submitblock(const JSONRPCRequest& request) if (mi != mapBlockIndex.end()) { CBlockIndex *pindex = mi->second; if (pindex->IsValid(BLOCK_VALID_SCRIPTS)) { - return "duplicate"; + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED, "duplicate"); } if (pindex->nStatus & BLOCK_FAILED_MASK) { - return "duplicate-invalid"; + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED, "duplicate-invalid"); } // Otherwise, we might only have the header - process the block before returning fBlockPresent = true; @@ -704,12 +724,12 @@ UniValue submitblock(const JSONRPCRequest& request) UnregisterValidationInterface(&sc); if (fBlockPresent) { if (fAccepted && !sc.found) { - return "duplicate-inconclusive"; + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED, "duplicate-inconclusive"); } - return "duplicate"; + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED, "duplicate"); } if (!sc.found) { - return "inconclusive"; + throw CN_JSONRPCError(CORE_RPC_ERROR_CODE_BLOCK_NOT_ACCEPTED, "inconclusive"); } return BIP22ValidationResult(sc.state); }