mirror of
https://github.com/kvazar-network/kevacoin.git
synced 2025-03-09 12:11:16 +00:00
Merge #8915: Add copyright/patent issues to possible NACK reasons
36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)
This commit is contained in:
commit
03dd707dc0
@ -178,7 +178,9 @@ language is used within pull-request comments:
|
|||||||
|
|
||||||
- ACK means "I have tested the code and I agree it should be merged";
|
- ACK means "I have tested the code and I agree it should be merged";
|
||||||
- NACK means "I disagree this should be merged", and must be accompanied by
|
- NACK means "I disagree this should be merged", and must be accompanied by
|
||||||
sound technical justification. NACKs without accompanying reasoning may be disregarded;
|
sound technical justification (or in certain cases of copyright/patent/licensing
|
||||||
|
issues, legal justification). NACKs without accompanying reasoning may be
|
||||||
|
disregarded;
|
||||||
- utACK means "I have not tested the code, but I have reviewed it and it looks
|
- utACK means "I have not tested the code, but I have reviewed it and it looks
|
||||||
OK, I agree it can be merged";
|
OK, I agree it can be merged";
|
||||||
- Concept ACK means "I agree in the general principle of this pull request";
|
- Concept ACK means "I agree in the general principle of this pull request";
|
||||||
|
Loading…
x
Reference in New Issue
Block a user