Browse Source

vphysics: fix saverestore

pull/71/head
nillerusr 2 years ago
parent
commit
94916a20ce
  1. 2
      public/datamap.h
  2. 10
      public/tier0/platform.h
  3. 29
      public/tier1/datamanager.h
  4. 232
      public/tier1/mempool.h
  5. 61
      tier1/datamanager.cpp
  6. 77
      tier1/mempool.cpp
  7. 4
      vphysics/physics_virtualmesh.cpp
  8. 1
      vphysics/vphysics_saverestore.cpp
  9. 2
      vphysics/vphysics_saverestore.h
  10. 4
      vstdlib/KeyValuesSystem.cpp

2
public/datamap.h

@ -110,7 +110,7 @@ DECLARE_FIELD_SIZE( FIELD_MODELNAME, sizeof(void*))
DECLARE_FIELD_SIZE( FIELD_SOUNDNAME, sizeof(void*)) DECLARE_FIELD_SIZE( FIELD_SOUNDNAME, sizeof(void*))
DECLARE_FIELD_SIZE( FIELD_EHANDLE, sizeof(void*)) DECLARE_FIELD_SIZE( FIELD_EHANDLE, sizeof(void*))
DECLARE_FIELD_SIZE( FIELD_CLASSPTR, sizeof(void*)) DECLARE_FIELD_SIZE( FIELD_CLASSPTR, sizeof(void*))
DECLARE_FIELD_SIZE( FIELD_EDICT, sizeof(int)) DECLARE_FIELD_SIZE( FIELD_EDICT, sizeof(void*))
DECLARE_FIELD_SIZE( FIELD_POSITION_VECTOR, 3 * sizeof(float)) DECLARE_FIELD_SIZE( FIELD_POSITION_VECTOR, 3 * sizeof(float))
DECLARE_FIELD_SIZE( FIELD_TIME, sizeof(float)) DECLARE_FIELD_SIZE( FIELD_TIME, sizeof(float))
DECLARE_FIELD_SIZE( FIELD_TICK, sizeof(int)) DECLARE_FIELD_SIZE( FIELD_TICK, sizeof(int))

10
public/tier0/platform.h

@ -525,6 +525,16 @@ typedef void * HINSTANCE;
#error #error
#endif #endif
// !!! NOTE: if you get a compile error here, you are using VALIGNOF on an abstract type :NOTE !!!
#define VALIGNOF_PORTABLE( type ) ( sizeof( AlignOf_t<type> ) - sizeof( type ) )
#if defined( COMPILER_GCC ) || defined( COMPILER_MSVC )
#define VALIGNOF( type ) __alignof( type )
#define VALIGNOF_TEMPLATE_SAFE( type ) VALIGNOF_PORTABLE( type )
#else
#error "PORT: Code only tested with MSVC! Must validate with new compiler, and use built-in keyword if available."
#endif
// Pull in the /analyze code annotations. // Pull in the /analyze code annotations.
#include "annotations.h" #include "annotations.h"

29
public/tier1/datamanager.h

@ -1,4 +1,4 @@
//========= Copyright Valve Corporation, All rights reserved. ============// //========= Copyright © 1996-2005, Valve Corporation, All rights reserved. ============//
// //
// Purpose: // Purpose:
// //
@ -65,6 +65,8 @@ public:
// ----------------------------------------------------------------------------- // -----------------------------------------------------------------------------
void SetFreeOnDestruct( bool value ) { m_freeOnDestruct = value; }
// Debugging only!!!! // Debugging only!!!!
void GetLRUHandleList( CUtlVector< memhandle_t >& list ); void GetLRUHandleList( CUtlVector< memhandle_t >& list );
void GetLockHandleList( CUtlVector< memhandle_t >& list ); void GetLockHandleList( CUtlVector< memhandle_t >& list );
@ -77,6 +79,7 @@ protected:
void *GetResource_NoLock( memhandle_t handle ); void *GetResource_NoLock( memhandle_t handle );
void *GetResource_NoLockNoLRUTouch( memhandle_t handle ); void *GetResource_NoLockNoLRUTouch( memhandle_t handle );
void *LockResource( memhandle_t handle ); void *LockResource( memhandle_t handle );
void *LockResourceReturnCount( int *pCount, memhandle_t handle );
// NOTE: you must call this from the destructor of the derived class! (will assert otherwise) // NOTE: you must call this from the destructor of the derived class! (will assert otherwise)
void FreeAllLists() { FlushAll(); m_listsAreFreed = true; } void FreeAllLists() { FlushAll(); m_listsAreFreed = true; }
@ -123,7 +126,8 @@ protected:
unsigned short m_lockList; unsigned short m_lockList;
unsigned short m_freeList; unsigned short m_freeList;
unsigned short m_listsAreFreed : 1; unsigned short m_listsAreFreed : 1;
unsigned short m_unused : 15; unsigned short m_freeOnDestruct : 1;
unsigned short m_unused : 14;
}; };
@ -139,7 +143,10 @@ public:
~CDataManager<STORAGE_TYPE, CREATE_PARAMS, LOCK_TYPE, MUTEX_TYPE>() ~CDataManager<STORAGE_TYPE, CREATE_PARAMS, LOCK_TYPE, MUTEX_TYPE>()
{ {
// NOTE: This must be called in all implementations of CDataManager // NOTE: This must be called in all implementations of CDataManager
FreeAllLists(); if ( m_freeOnDestruct )
{
FreeAllLists();
}
} }
// Use GetData() to translate pointer to LOCK_TYPE // Use GetData() to translate pointer to LOCK_TYPE
@ -154,6 +161,17 @@ public:
return NULL; return NULL;
} }
LOCK_TYPE LockResourceReturnCount( int *pCount, memhandle_t hMem )
{
void *pLock = BaseClass::LockResourceReturnCount( pCount, hMem );
if ( pLock )
{
return StoragePointer(pLock)->GetData();
}
return NULL;
}
// Use GetData() to translate pointer to LOCK_TYPE // Use GetData() to translate pointer to LOCK_TYPE
LOCK_TYPE GetResource_NoLock( memhandle_t hMem ) LOCK_TYPE GetResource_NoLock( memhandle_t hMem )
{ {
@ -181,8 +199,9 @@ public:
memhandle_t CreateResource( const CREATE_PARAMS &createParams, bool bCreateLocked = false ) memhandle_t CreateResource( const CREATE_PARAMS &createParams, bool bCreateLocked = false )
{ {
BaseClass::EnsureCapacity(STORAGE_TYPE::EstimatedSize(createParams)); BaseClass::EnsureCapacity(STORAGE_TYPE::EstimatedSize(createParams));
unsigned short memoryIndex = BaseClass::CreateHandle( bCreateLocked );
STORAGE_TYPE *pStore = STORAGE_TYPE::CreateResource( createParams ); STORAGE_TYPE *pStore = STORAGE_TYPE::CreateResource( createParams );
AUTO_LOCK_( CDataManagerBase, *this );
unsigned short memoryIndex = BaseClass::CreateHandle( bCreateLocked );
return BaseClass::StoreResourceInHandle( memoryIndex, pStore, pStore->Size() ); return BaseClass::StoreResourceInHandle( memoryIndex, pStore, pStore->Size() );
} }
@ -251,7 +270,7 @@ private:
inline unsigned short CDataManagerBase::FromHandle( memhandle_t handle ) inline unsigned short CDataManagerBase::FromHandle( memhandle_t handle )
{ {
uintp fullWord = (uintp)handle; unsigned int fullWord = (unsigned int)reinterpret_cast<uintp>( handle );
unsigned short serial = fullWord>>16; unsigned short serial = fullWord>>16;
unsigned short index = fullWord & 0xFFFF; unsigned short index = fullWord & 0xFFFF;
index--; index--;

232
public/tier1/mempool.h

@ -1,4 +1,4 @@
//========= Copyright Valve Corporation, All rights reserved. ============// //===== Copyright 1996-2005, Valve Corporation, All rights reserved. ======//
// //
// Purpose: // Purpose:
// //
@ -30,27 +30,19 @@
typedef void (*MemoryPoolReportFunc_t)( PRINTF_FORMAT_STRING char const* pMsg, ... ); typedef void (*MemoryPoolReportFunc_t)( PRINTF_FORMAT_STRING char const* pMsg, ... );
// Ways a memory pool can grow when it needs to make a new blob:
enum MemoryPoolGrowType_t
{
UTLMEMORYPOOL_GROW_NONE=0, // Don't allow new blobs.
UTLMEMORYPOOL_GROW_FAST=1, // New blob size is numElements * (i+1) (ie: the blocks it allocates
// get larger and larger each time it allocates one).
UTLMEMORYPOOL_GROW_SLOW=2 // New blob size is numElements.
};
class CUtlMemoryPool class CUtlMemoryPool
{ {
public: public:
// !KLUDGE! For legacy code support, import the global enum into this scope // Ways the memory pool can grow when it needs to make a new blob.
enum MemoryPoolGrowType_t enum MemoryPoolGrowType_t
{ {
GROW_NONE=UTLMEMORYPOOL_GROW_NONE, GROW_NONE=0, // Don't allow new blobs.
GROW_FAST=UTLMEMORYPOOL_GROW_FAST, GROW_FAST=1, // New blob size is numElements * (i+1) (ie: the blocks it allocates
GROW_SLOW=UTLMEMORYPOOL_GROW_SLOW // get larger and larger each time it allocates one).
GROW_SLOW=2 // New blob size is numElements.
}; };
CUtlMemoryPool( int blockSize, int numElements, int growMode = UTLMEMORYPOOL_GROW_FAST, const char *pszAllocOwner = NULL, int nAlignment = 0 ); CUtlMemoryPool( int blockSize, int numElements, int growMode = GROW_FAST, const char *pszAllocOwner = NULL, int nAlignment = 0 );
~CUtlMemoryPool(); ~CUtlMemoryPool();
void* Alloc(); // Allocate the element size you specified in the constructor. void* Alloc(); // Allocate the element size you specified in the constructor.
@ -66,8 +58,12 @@ public:
static void SetErrorReportFunc( MemoryPoolReportFunc_t func ); static void SetErrorReportFunc( MemoryPoolReportFunc_t func );
// returns number of allocated blocks // returns number of allocated blocks
int Count() { return m_BlocksAllocated; } int Count() const { return m_BlocksAllocated; }
int PeakCount() { return m_PeakAlloc; } int PeakCount() const { return m_PeakAlloc; }
int BlockSize() const { return m_BlockSize; }
int Size() const;
bool IsAllocationWithinPool( void *pMem ) const;
protected: protected:
class CBlob class CBlob
@ -89,14 +85,13 @@ protected:
int m_GrowMode; // GROW_ enum. int m_GrowMode; // GROW_ enum.
// Put m_BlocksAllocated in front of m_pHeadOfFreeList for better
// packing on 64-bit where pointers are 8-byte aligned.
int m_BlocksAllocated; int m_BlocksAllocated;
// FIXME: Change m_ppMemBlob into a growable array?
void *m_pHeadOfFreeList;
int m_PeakAlloc; int m_PeakAlloc;
unsigned short m_nAlignment; unsigned short m_nAlignment;
unsigned short m_NumBlobs; unsigned short m_NumBlobs;
// Group up pointers at the end of the class to avoid padding bloat
// FIXME: Change m_ppMemBlob into a growable array?
void *m_pHeadOfFreeList;
const char * m_pszAllocOwner; const char * m_pszAllocOwner;
// CBlob could be not a multiple of 4 bytes so stuff it at the end here to keep us otherwise aligned // CBlob could be not a multiple of 4 bytes so stuff it at the end here to keep us otherwise aligned
CBlob m_BlobHead; CBlob m_BlobHead;
@ -106,13 +101,12 @@ protected:
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
// // Multi-thread/Thread Safe Memory Class
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
class CMemoryPoolMT : public CUtlMemoryPool class CMemoryPoolMT : public CUtlMemoryPool
{ {
public: public:
// MoeMod : add alignment CMemoryPoolMT( int blockSize, int numElements, int growMode = GROW_FAST, const char *pszAllocOwner = NULL, int nAlignment = 0) : CUtlMemoryPool( blockSize, numElements, growMode, pszAllocOwner, nAlignment ) {}
CMemoryPoolMT(int blockSize, int numElements, int growMode = UTLMEMORYPOOL_GROW_FAST, const char *pszAllocOwner = NULL, int nAlignment = 0) : CUtlMemoryPool( blockSize, numElements, growMode, pszAllocOwner, nAlignment) {}
void* Alloc() { AUTO_LOCK( m_mutex ); return CUtlMemoryPool::Alloc(); } void* Alloc() { AUTO_LOCK( m_mutex ); return CUtlMemoryPool::Alloc(); }
@ -136,15 +130,8 @@ template< class T >
class CClassMemoryPool : public CUtlMemoryPool class CClassMemoryPool : public CUtlMemoryPool
{ {
public: public:
// MoeMod : bad default align here, should be alignof(T) CClassMemoryPool(int numElements, int growMode = GROW_FAST, int nAlignment = 0 ) :
CClassMemoryPool(int numElements, int growMode = GROW_FAST, int nAlignment = alignof(T) ) : CUtlMemoryPool( sizeof(T), numElements, growMode, MEM_ALLOC_CLASSNAME(T), nAlignment ) {}
CUtlMemoryPool( sizeof(T), numElements, growMode, MEM_ALLOC_CLASSNAME(T), nAlignment ) {
#ifdef PLATFORM_64BITS
COMPILE_TIME_ASSERT( sizeof(CUtlMemoryPool) == 64 );
#else
COMPILE_TIME_ASSERT( sizeof(CUtlMemoryPool) == 48 );
#endif
}
T* Alloc(); T* Alloc();
T* AllocZero(); T* AllocZero();
@ -153,16 +140,15 @@ public:
void Clear(); void Clear();
}; };
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
// Specialized pool for aligned data management (e.g., Xbox cubemaps) // Specialized pool for aligned data management (e.g., Xbox textures)
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, int COMPACT_THRESHOLD = 4 > template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, bool GROWMODE = false, int COMPACT_THRESHOLD = 4 >
class CAlignedMemPool class CAlignedMemPool
{ {
enum enum
{ {
BLOCK_SIZE = ALIGN_VALUE( ITEM_SIZE, ALIGNMENT ) > 8 ? ALIGN_VALUE( ITEM_SIZE, ALIGNMENT ) : 8 BLOCK_SIZE = COMPILETIME_MAX( ALIGN_VALUE( ITEM_SIZE, ALIGNMENT ), 8 ),
}; };
public: public:
@ -174,13 +160,13 @@ public:
static int __cdecl CompareChunk( void * const *ppLeft, void * const *ppRight ); static int __cdecl CompareChunk( void * const *ppLeft, void * const *ppRight );
void Compact(); void Compact();
int NumTotal() { return m_Chunks.Count() * ( CHUNK_SIZE / BLOCK_SIZE ); } int NumTotal() { AUTO_LOCK( m_mutex ); return m_Chunks.Count() * ( CHUNK_SIZE / BLOCK_SIZE ); }
int NumAllocated() { return NumTotal() - m_nFree; } int NumAllocated() { AUTO_LOCK( m_mutex ); return NumTotal() - m_nFree; }
int NumFree() { return m_nFree; } int NumFree() { AUTO_LOCK( m_mutex ); return m_nFree; }
int BytesTotal() { return NumTotal() * BLOCK_SIZE; } int BytesTotal() { AUTO_LOCK( m_mutex ); return NumTotal() * BLOCK_SIZE; }
int BytesAllocated() { return NumAllocated() * BLOCK_SIZE; } int BytesAllocated() { AUTO_LOCK( m_mutex ); return NumAllocated() * BLOCK_SIZE; }
int BytesFree() { return NumFree() * BLOCK_SIZE; } int BytesFree() { AUTO_LOCK( m_mutex ); return NumFree() * BLOCK_SIZE; }
int ItemSize() { return ITEM_SIZE; } int ItemSize() { return ITEM_SIZE; }
int BlockSize() { return BLOCK_SIZE; } int BlockSize() { return BLOCK_SIZE; }
@ -197,7 +183,9 @@ private:
FreeBlock_t * m_pFirstFree; FreeBlock_t * m_pFirstFree;
int m_nFree; int m_nFree;
CAllocator m_Allocator; CAllocator m_Allocator;
float m_TimeLastCompact; double m_TimeLastCompact;
CThreadFastMutex m_mutex;
}; };
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
@ -228,7 +216,7 @@ public:
void Purge() void Purge()
{ {
T *p; T *p = NULL;
while ( m_AvailableObjects.PopItem( &p ) ) while ( m_AvailableObjects.PopItem( &p ) )
{ {
delete p; delete p;
@ -237,7 +225,7 @@ public:
T *GetObject( bool bCreateNewIfEmpty = bDefCreateNewIfEmpty ) T *GetObject( bool bCreateNewIfEmpty = bDefCreateNewIfEmpty )
{ {
T *p; T *p = NULL;
if ( !m_AvailableObjects.PopItem( &p ) ) if ( !m_AvailableObjects.PopItem( &p ) )
{ {
p = ( bCreateNewIfEmpty ) ? new T : NULL; p = ( bCreateNewIfEmpty ) ? new T : NULL;
@ -255,6 +243,98 @@ private:
}; };
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
// Fixed budget pool with overflow to malloc
//-----------------------------------------------------------------------------
template <size_t PROVIDED_ITEM_SIZE, int ITEM_COUNT>
class CFixedBudgetMemoryPool
{
public:
CFixedBudgetMemoryPool()
{
m_pBase = m_pLimit = 0;
COMPILE_TIME_ASSERT( ITEM_SIZE % 4 == 0 );
}
bool Owns( void *p )
{
return ( p >= m_pBase && p < m_pLimit );
}
void *Alloc()
{
MEM_ALLOC_CREDIT_CLASS();
#ifndef USE_MEM_DEBUG
if ( !m_pBase )
{
LOCAL_THREAD_LOCK();
if ( !m_pBase )
{
byte *pMemory = m_pBase = (byte *)malloc( ITEM_COUNT * ITEM_SIZE );
m_pLimit = m_pBase + ( ITEM_COUNT * ITEM_SIZE );
for ( int i = 0; i < ITEM_COUNT; i++ )
{
m_freeList.Push( (TSLNodeBase_t *)pMemory );
pMemory += ITEM_SIZE;
}
}
}
void *p = m_freeList.Pop();
if ( p )
return p;
#endif
return malloc( ITEM_SIZE );
}
void Free( void *p )
{
#ifndef USE_MEM_DEBUG
if ( Owns( p ) )
m_freeList.Push( (TSLNodeBase_t *)p );
else
#endif
free( p );
}
void Clear()
{
#ifndef USE_MEM_DEBUG
if ( m_pBase )
{
free( m_pBase );
}
m_pBase = m_pLimit = 0;
Construct( &m_freeList );
#endif
}
bool IsEmpty()
{
#ifndef USE_MEM_DEBUG
if ( m_pBase && m_freeList.Count() != ITEM_COUNT )
return false;
#endif
return true;
}
enum
{
ITEM_SIZE = ALIGN_VALUE( PROVIDED_ITEM_SIZE, TSLIST_NODE_ALIGNMENT )
};
CTSListBase m_freeList;
byte *m_pBase;
byte *m_pLimit;
};
#define BIND_TO_FIXED_BUDGET_POOL( poolName ) \
inline void* operator new( size_t size ) { return poolName.Alloc(); } \
inline void* operator new( size_t size, int nBlockUse, const char *pFileName, int nLine ) { return poolName.Alloc(); } \
inline void operator delete( void* p ) { poolName.Free(p); } \
inline void operator delete( void* p, int nBlockUse, const char *pFileName, int nLine ) { poolName.Free(p); }
//-----------------------------------------------------------------------------
template< class T > template< class T >
@ -263,7 +343,7 @@ inline T* CClassMemoryPool<T>::Alloc()
T *pRet; T *pRet;
{ {
MEM_ALLOC_CREDIT_(MEM_ALLOC_CLASSNAME(T)); MEM_ALLOC_CREDIT_CLASS();
pRet = (T*)CUtlMemoryPool::Alloc(); pRet = (T*)CUtlMemoryPool::Alloc();
} }
@ -280,7 +360,7 @@ inline T* CClassMemoryPool<T>::AllocZero()
T *pRet; T *pRet;
{ {
MEM_ALLOC_CREDIT_(MEM_ALLOC_CLASSNAME(T)); MEM_ALLOC_CREDIT_CLASS();
pRet = (T*)CUtlMemoryPool::AllocZero(); pRet = (T*)CUtlMemoryPool::AllocZero();
} }
@ -305,7 +385,7 @@ inline void CClassMemoryPool<T>::Free(T *pMem)
template< class T > template< class T >
inline void CClassMemoryPool<T>::Clear() inline void CClassMemoryPool<T>::Clear()
{ {
CUtlRBTree<void *> freeBlocks; CUtlRBTree<void *, int> freeBlocks;
SetDefLessFunc( freeBlocks ); SetDefLessFunc( freeBlocks );
void *pCurFree = m_pHeadOfFreeList; void *pCurFree = m_pHeadOfFreeList;
@ -317,9 +397,9 @@ inline void CClassMemoryPool<T>::Clear()
for( CBlob *pCur=m_BlobHead.m_pNext; pCur != &m_BlobHead; pCur=pCur->m_pNext ) for( CBlob *pCur=m_BlobHead.m_pNext; pCur != &m_BlobHead; pCur=pCur->m_pNext )
{ {
// MoeMod : should realign to real data. int nElements = pCur->m_NumBytes / this->m_BlockSize;
T *p = (T *)AlignValue( pCur->m_Data, m_nAlignment ); T *p = ( T * ) AlignValue( pCur->m_Data, this->m_nAlignment );
T *pLimit = (T *)(pCur->m_Data + pCur->m_NumBytes); T *pLimit = p + nElements;
while ( p < pLimit ) while ( p < pLimit )
{ {
if ( freeBlocks.Find( p ) == freeBlocks.InvalidIndex() ) if ( freeBlocks.Find( p ) == freeBlocks.InvalidIndex() )
@ -334,6 +414,9 @@ inline void CClassMemoryPool<T>::Clear()
} }
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
// Macros that make it simple to make a class use a fixed-size allocator // Macros that make it simple to make a class use a fixed-size allocator
// Put DECLARE_FIXEDSIZE_ALLOCATOR in the private section of a class, // Put DECLARE_FIXEDSIZE_ALLOCATOR in the private section of a class,
@ -364,7 +447,7 @@ inline void CClassMemoryPool<T>::Clear()
static CMemoryPoolMT s_Allocator static CMemoryPoolMT s_Allocator
#define DEFINE_FIXEDSIZE_ALLOCATOR_MT( _class, _initsize, _grow ) \ #define DEFINE_FIXEDSIZE_ALLOCATOR_MT( _class, _initsize, _grow ) \
CMemoryPoolMT _class::s_Allocator(sizeof(_class), _initsize, _grow, #_class " pool", alignof(_class)) CMemoryPoolMT _class::s_Allocator(sizeof(_class), _initsize, _grow, #_class " pool")
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
// Macros that make it simple to make a class use a fixed-size allocator // Macros that make it simple to make a class use a fixed-size allocator
@ -385,21 +468,30 @@ inline void CClassMemoryPool<T>::Clear()
CUtlMemoryPool* _class::s_pAllocator = _allocator CUtlMemoryPool* _class::s_pAllocator = _allocator
template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, int COMPACT_THRESHOLD > template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, bool GROWMODE, int COMPACT_THRESHOLD >
inline CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, COMPACT_THRESHOLD>::CAlignedMemPool() inline CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, GROWMODE, COMPACT_THRESHOLD>::CAlignedMemPool()
: m_pFirstFree( 0 ), : m_pFirstFree( 0 ),
m_nFree( 0 ), m_nFree( 0 ),
m_TimeLastCompact( 0 ) m_TimeLastCompact( 0 )
{ {
COMPILE_TIME_ASSERT( sizeof( FreeBlock_t ) >= BLOCK_SIZE ); // These COMPILE_TIME_ASSERT checks need to be in individual scopes to avoid build breaks
COMPILE_TIME_ASSERT( ALIGN_VALUE( sizeof( FreeBlock_t ), ALIGNMENT ) == sizeof( FreeBlock_t ) ); // on MacOS and Linux due to a gcc bug.
{ COMPILE_TIME_ASSERT( sizeof( FreeBlock_t ) >= BLOCK_SIZE ); }
{ COMPILE_TIME_ASSERT( ALIGN_VALUE( sizeof( FreeBlock_t ), ALIGNMENT ) == sizeof( FreeBlock_t ) ); }
} }
template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, int COMPACT_THRESHOLD > template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, bool GROWMODE, int COMPACT_THRESHOLD >
inline void *CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, COMPACT_THRESHOLD>::Alloc() inline void *CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, GROWMODE, COMPACT_THRESHOLD>::Alloc()
{ {
AUTO_LOCK( m_mutex );
if ( !m_pFirstFree ) if ( !m_pFirstFree )
{ {
if ( !GROWMODE && m_Chunks.Count() )
{
return NULL;
}
FreeBlock_t *pNew = (FreeBlock_t *)m_Allocator.Alloc( CHUNK_SIZE ); FreeBlock_t *pNew = (FreeBlock_t *)m_Allocator.Alloc( CHUNK_SIZE );
Assert( (unsigned)pNew % ALIGNMENT == 0 ); Assert( (unsigned)pNew % ALIGNMENT == 0 );
m_Chunks.AddToTail( pNew ); m_Chunks.AddToTail( pNew );
@ -420,9 +512,11 @@ inline void *CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, COMPA
return p; return p;
} }
template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, int COMPACT_THRESHOLD > template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, bool GROWMODE, int COMPACT_THRESHOLD >
inline void CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, COMPACT_THRESHOLD>::Free( void *p ) inline void CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, GROWMODE, COMPACT_THRESHOLD>::Free( void *p )
{ {
AUTO_LOCK( m_mutex );
// Insertion sort to encourage allocation clusters in chunks // Insertion sort to encourage allocation clusters in chunks
FreeBlock_t *pFree = ((FreeBlock_t *)p); FreeBlock_t *pFree = ((FreeBlock_t *)p);
FreeBlock_t *pCur = m_pFirstFree; FreeBlock_t *pCur = m_pFirstFree;
@ -448,9 +542,9 @@ inline void CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, COMPAC
if ( m_nFree >= ( CHUNK_SIZE / BLOCK_SIZE ) * COMPACT_THRESHOLD ) if ( m_nFree >= ( CHUNK_SIZE / BLOCK_SIZE ) * COMPACT_THRESHOLD )
{ {
float time = Plat_FloatTime(); double time = Plat_FloatTime();
float compactTime = ( m_nFree >= ( CHUNK_SIZE / BLOCK_SIZE ) * COMPACT_THRESHOLD * 4 ) ? 15.0 : 30.0; double compactTime = ( m_nFree >= ( CHUNK_SIZE / BLOCK_SIZE ) * COMPACT_THRESHOLD * 4 ) ? 15.0 : 30.0;
if ( m_TimeLastCompact > time || m_TimeLastCompact + compactTime < Plat_FloatTime() ) if ( m_TimeLastCompact > time || m_TimeLastCompact + compactTime < time )
{ {
Compact(); Compact();
m_TimeLastCompact = time; m_TimeLastCompact = time;
@ -458,14 +552,14 @@ inline void CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, COMPAC
} }
} }
template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, int COMPACT_THRESHOLD > template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, bool GROWMODE, int COMPACT_THRESHOLD >
inline int __cdecl CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, COMPACT_THRESHOLD>::CompareChunk( void * const *ppLeft, void * const *ppRight ) inline int __cdecl CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, GROWMODE, COMPACT_THRESHOLD>::CompareChunk( void * const *ppLeft, void * const *ppRight )
{ {
return (int)(((uintp)*ppLeft) - ((uintp)*ppRight)); return static_cast<int>( (intp)*ppLeft - (intp)*ppRight );
} }
template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, int COMPACT_THRESHOLD > template <int ITEM_SIZE, int ALIGNMENT, int CHUNK_SIZE, class CAllocator, bool GROWMODE, int COMPACT_THRESHOLD >
inline void CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, COMPACT_THRESHOLD>::Compact() inline void CAlignedMemPool<ITEM_SIZE, ALIGNMENT, CHUNK_SIZE, CAllocator, GROWMODE, COMPACT_THRESHOLD>::Compact()
{ {
FreeBlock_t *pCur = m_pFirstFree; FreeBlock_t *pCur = m_pFirstFree;
FreeBlock_t *pPrev = NULL; FreeBlock_t *pPrev = NULL;

61
tier1/datamanager.cpp

@ -1,4 +1,4 @@
//========= Copyright © 1996-2005, Valve Corporation, All rights reserved. ============//
// //
// Purpose: // Purpose:
// //
@ -9,8 +9,14 @@
#include "basetypes.h" #include "basetypes.h"
#include "datamanager.h" #include "datamanager.h"
// NOTE: This has to be the last file included!
#include "tier0/memdbgon.h"
DECLARE_POINTER_HANDLE( memhandle_t ); DECLARE_POINTER_HANDLE( memhandle_t );
#define AUTO_LOCK_DM() AUTO_LOCK_( CDataManagerBase, *this )
CDataManagerBase::CDataManagerBase( unsigned int maxSize ) CDataManagerBase::CDataManagerBase( unsigned int maxSize )
{ {
m_targetMemorySize = maxSize; m_targetMemorySize = maxSize;
@ -19,11 +25,12 @@ CDataManagerBase::CDataManagerBase( unsigned int maxSize )
m_lockList = m_memoryLists.CreateList(); m_lockList = m_memoryLists.CreateList();
m_freeList = m_memoryLists.CreateList(); m_freeList = m_memoryLists.CreateList();
m_listsAreFreed = 0; m_listsAreFreed = 0;
m_freeOnDestruct = 1;
} }
CDataManagerBase::~CDataManagerBase() CDataManagerBase::~CDataManagerBase()
{ {
Assert( m_listsAreFreed ); Assert( !m_freeOnDestruct || m_listsAreFreed );
} }
void CDataManagerBase::NotifySizeChanged( memhandle_t handle, unsigned int oldSize, unsigned int newSize ) void CDataManagerBase::NotifySizeChanged( memhandle_t handle, unsigned int oldSize, unsigned int newSize )
@ -43,7 +50,7 @@ unsigned int CDataManagerBase::FlushAllUnlocked()
Lock(); Lock();
int nFlush = m_memoryLists.Count( m_lruList ); int nFlush = m_memoryLists.Count( m_lruList );
void **pScratch = (void **)_alloca( nFlush * sizeof(void *) ); void **pScratch = (void **)stackalloc( nFlush * sizeof(void *) );
CUtlVector<void *> destroyList( pScratch, nFlush ); CUtlVector<void *> destroyList( pScratch, nFlush );
unsigned nBytesInitial = MemUsed_Inline(); unsigned nBytesInitial = MemUsed_Inline();
@ -80,7 +87,7 @@ unsigned int CDataManagerBase::FlushAll()
Lock(); Lock();
int nFlush = m_memoryLists.Count( m_lruList ) + m_memoryLists.Count( m_lockList ); int nFlush = m_memoryLists.Count( m_lruList ) + m_memoryLists.Count( m_lockList );
void **pScratch = (void **)_alloca( nFlush * sizeof(void *) ); void **pScratch = (void **) stackalloc( nFlush * sizeof(void *) );
CUtlVector<void *> destroyList( pScratch, nFlush ); CUtlVector<void *> destroyList( pScratch, nFlush );
unsigned result = MemUsed_Inline(); unsigned result = MemUsed_Inline();
@ -120,8 +127,7 @@ unsigned int CDataManagerBase::FlushAll()
unsigned int CDataManagerBase::Purge( unsigned int nBytesToPurge ) unsigned int CDataManagerBase::Purge( unsigned int nBytesToPurge )
{ {
unsigned int nTargetSize = MemUsed_Inline() - nBytesToPurge; unsigned int nTargetSize = MemUsed_Inline() - nBytesToPurge;
// Check for underflow if ( nBytesToPurge > MemUsed_Inline() )
if ( MemUsed_Inline() < nBytesToPurge )
nTargetSize = 0; nTargetSize = 0;
unsigned int nImpliedCapacity = MemTotal_Inline() - nTargetSize; unsigned int nImpliedCapacity = MemTotal_Inline() - nTargetSize;
return EnsureCapacity( nImpliedCapacity ); return EnsureCapacity( nImpliedCapacity );
@ -151,8 +157,7 @@ void CDataManagerBase::DestroyResource( memhandle_t handle )
void *CDataManagerBase::LockResource( memhandle_t handle ) void *CDataManagerBase::LockResource( memhandle_t handle )
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
unsigned short memoryIndex = FromHandle(handle); unsigned short memoryIndex = FromHandle(handle);
if ( memoryIndex != m_memoryLists.InvalidIndex() ) if ( memoryIndex != m_memoryLists.InvalidIndex() )
{ {
@ -169,9 +174,29 @@ void *CDataManagerBase::LockResource( memhandle_t handle )
return NULL; return NULL;
} }
void *CDataManagerBase::LockResourceReturnCount( int *pCount, memhandle_t handle )
{
AUTO_LOCK_DM();
unsigned short memoryIndex = FromHandle(handle);
if ( memoryIndex != m_memoryLists.InvalidIndex() )
{
if ( m_memoryLists[memoryIndex].lockCount == 0 )
{
m_memoryLists.Unlink( m_lruList, memoryIndex );
m_memoryLists.LinkToTail( m_lockList, memoryIndex );
}
Assert(m_memoryLists[memoryIndex].lockCount != (unsigned short)-1);
*pCount = ++m_memoryLists[memoryIndex].lockCount;
return m_memoryLists[memoryIndex].pStore;
}
*pCount = 0;
return NULL;
}
int CDataManagerBase::UnlockResource( memhandle_t handle ) int CDataManagerBase::UnlockResource( memhandle_t handle )
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
unsigned short memoryIndex = FromHandle(handle); unsigned short memoryIndex = FromHandle(handle);
if ( memoryIndex != m_memoryLists.InvalidIndex() ) if ( memoryIndex != m_memoryLists.InvalidIndex() )
{ {
@ -193,7 +218,7 @@ int CDataManagerBase::UnlockResource( memhandle_t handle )
void *CDataManagerBase::GetResource_NoLockNoLRUTouch( memhandle_t handle ) void *CDataManagerBase::GetResource_NoLockNoLRUTouch( memhandle_t handle )
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
unsigned short memoryIndex = FromHandle(handle); unsigned short memoryIndex = FromHandle(handle);
if ( memoryIndex != m_memoryLists.InvalidIndex() ) if ( memoryIndex != m_memoryLists.InvalidIndex() )
{ {
@ -205,7 +230,7 @@ void *CDataManagerBase::GetResource_NoLockNoLRUTouch( memhandle_t handle )
void *CDataManagerBase::GetResource_NoLock( memhandle_t handle ) void *CDataManagerBase::GetResource_NoLock( memhandle_t handle )
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
unsigned short memoryIndex = FromHandle(handle); unsigned short memoryIndex = FromHandle(handle);
if ( memoryIndex != m_memoryLists.InvalidIndex() ) if ( memoryIndex != m_memoryLists.InvalidIndex() )
{ {
@ -217,13 +242,13 @@ void *CDataManagerBase::GetResource_NoLock( memhandle_t handle )
void CDataManagerBase::TouchResource( memhandle_t handle ) void CDataManagerBase::TouchResource( memhandle_t handle )
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
TouchByIndex( FromHandle(handle) ); TouchByIndex( FromHandle(handle) );
} }
void CDataManagerBase::MarkAsStale( memhandle_t handle ) void CDataManagerBase::MarkAsStale( memhandle_t handle )
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
unsigned short memoryIndex = FromHandle(handle); unsigned short memoryIndex = FromHandle(handle);
if ( memoryIndex != m_memoryLists.InvalidIndex() ) if ( memoryIndex != m_memoryLists.InvalidIndex() )
{ {
@ -237,7 +262,7 @@ void CDataManagerBase::MarkAsStale( memhandle_t handle )
int CDataManagerBase::BreakLock( memhandle_t handle ) int CDataManagerBase::BreakLock( memhandle_t handle )
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
unsigned short memoryIndex = FromHandle(handle); unsigned short memoryIndex = FromHandle(handle);
if ( memoryIndex != m_memoryLists.InvalidIndex() && m_memoryLists[memoryIndex].lockCount ) if ( memoryIndex != m_memoryLists.InvalidIndex() && m_memoryLists[memoryIndex].lockCount )
{ {
@ -253,7 +278,7 @@ int CDataManagerBase::BreakLock( memhandle_t handle )
int CDataManagerBase::BreakAllLocks() int CDataManagerBase::BreakAllLocks()
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
int nBroken = 0; int nBroken = 0;
int node; int node;
int nextNode; int nextNode;
@ -275,7 +300,7 @@ int CDataManagerBase::BreakAllLocks()
unsigned short CDataManagerBase::CreateHandle( bool bCreateLocked ) unsigned short CDataManagerBase::CreateHandle( bool bCreateLocked )
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
int memoryIndex = m_memoryLists.Head(m_freeList); int memoryIndex = m_memoryLists.Head(m_freeList);
unsigned short list = ( bCreateLocked ) ? m_lockList : m_lruList; unsigned short list = ( bCreateLocked ) ? m_lockList : m_lruList;
if ( memoryIndex != m_memoryLists.InvalidIndex() ) if ( memoryIndex != m_memoryLists.InvalidIndex() )
@ -298,7 +323,7 @@ unsigned short CDataManagerBase::CreateHandle( bool bCreateLocked )
memhandle_t CDataManagerBase::StoreResourceInHandle( unsigned short memoryIndex, void *pStore, unsigned int realSize ) memhandle_t CDataManagerBase::StoreResourceInHandle( unsigned short memoryIndex, void *pStore, unsigned int realSize )
{ {
AUTO_LOCK( *this ); AUTO_LOCK_DM();
resource_lru_element_t &mem = m_memoryLists[memoryIndex]; resource_lru_element_t &mem = m_memoryLists[memoryIndex];
mem.pStore = pStore; mem.pStore = pStore;
m_memUsed += realSize; m_memUsed += realSize;
@ -322,7 +347,7 @@ memhandle_t CDataManagerBase::ToHandle( unsigned short index )
unsigned int hiword = m_memoryLists.Element(index).serial; unsigned int hiword = m_memoryLists.Element(index).serial;
hiword <<= 16; hiword <<= 16;
index++; index++;
return (memhandle_t)( hiword|index ); return reinterpret_cast< memhandle_t >( (uintp)( hiword|index ) );
} }
unsigned int CDataManagerBase::TargetSize() unsigned int CDataManagerBase::TargetSize()

77
tier1/mempool.cpp

@ -1,24 +1,23 @@
//========= Copyright Valve Corporation, All rights reserved. ============// //===== Copyright 1996-2005, Valve Corporation, All rights reserved. ======//
// //
// Purpose: // Purpose:
// //
//===========================================================================// //===========================================================================//
#include "mempool.h" #include "tier1/mempool.h"
#include <stdio.h> #include <stdio.h>
#ifdef OSX
#include <malloc/malloc.h>
#else
#include <malloc.h>
#endif
#include <memory.h> #include <memory.h>
#include "tier0/dbg.h" #include "tier0/dbg.h"
#include <ctype.h> #include <ctype.h>
#include "tier1/strtools.h" #include "tier1/strtools.h"
#ifndef _PS3
#include <malloc.h>
#endif
// Should be last include // Should be last include
#include "tier0/memdbgon.h" #include "tier0/memdbgon.h"
MemoryPoolReportFunc_t CUtlMemoryPool::g_ReportFunc = 0; MemoryPoolReportFunc_t CUtlMemoryPool::g_ReportFunc = 0;
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
@ -36,7 +35,7 @@ void CUtlMemoryPool::SetErrorReportFunc( MemoryPoolReportFunc_t func )
CUtlMemoryPool::CUtlMemoryPool( int blockSize, int numElements, int growMode, const char *pszAllocOwner, int nAlignment ) CUtlMemoryPool::CUtlMemoryPool( int blockSize, int numElements, int growMode, const char *pszAllocOwner, int nAlignment )
{ {
#ifdef _X360 #ifdef _X360
if( numElements > 0 && growMode != UTLMEMORYPOOL_GROW_NONE ) if( numElements > 0 && growMode != GROW_NONE )
{ {
numElements = 1; numElements = 1;
} }
@ -100,18 +99,40 @@ void CUtlMemoryPool::Clear()
Init(); Init();
} }
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
// Purpose: Reports memory leaks // Is an allocation within the pool?
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
bool CUtlMemoryPool::IsAllocationWithinPool( void *pMem ) const
{
for( CBlob *pCur = m_BlobHead.m_pNext; pCur != &m_BlobHead; pCur = pCur->m_pNext )
{
// Is the allocation within the blob?
if ( ( pMem < pCur->m_Data ) || ( pMem >= pCur->m_Data + pCur->m_NumBytes ) )
continue;
// Make sure the allocation is on a block boundary
intp pFirstAllocation = AlignValue( ( intp ) pCur->m_Data, m_nAlignment );
intp nOffset = (intp)pMem - pFirstAllocation;
return ( nOffset % m_BlockSize ) == 0;
}
return false;
}
//-----------------------------------------------------------------------------
// Purpose: Reports memory leaks
//-----------------------------------------------------------------------------
void CUtlMemoryPool::ReportLeaks() void CUtlMemoryPool::ReportLeaks()
{ {
#ifdef _DEBUG
if (!g_ReportFunc) if (!g_ReportFunc)
return; return;
g_ReportFunc("Memory leak: mempool blocks left in memory: %d\n", m_BlocksAllocated); g_ReportFunc("Memory leak: mempool blocks left in memory: %d\n", m_BlocksAllocated);
#ifdef _DEBUG
// walk and destroy the free list so it doesn't intefere in the scan // walk and destroy the free list so it doesn't intefere in the scan
while (m_pHeadOfFreeList != NULL) while (m_pHeadOfFreeList != NULL)
{ {
@ -132,7 +153,7 @@ void CUtlMemoryPool::ReportLeaks()
while (scanPoint < scanEnd) while (scanPoint < scanEnd)
{ {
// search for and dump any strings // search for and dump any strings
if ((unsigned)(*scanPoint + 1) <= 256 && isprint(*scanPoint)) if ((unsigned)(*scanPoint + 1) <= 256 && V_isprint(*scanPoint))
{ {
g_ReportFunc("%c", *scanPoint); g_ReportFunc("%c", *scanPoint);
needSpace = true; needSpace = true;
@ -161,18 +182,18 @@ void CUtlMemoryPool::AddNewBlob()
int sizeMultiplier; int sizeMultiplier;
if( m_GrowMode == UTLMEMORYPOOL_GROW_SLOW ) if( m_GrowMode == GROW_SLOW )
{ {
sizeMultiplier = 1; sizeMultiplier = 1;
} }
else else
{ {
if ( m_GrowMode == UTLMEMORYPOOL_GROW_NONE ) if ( m_GrowMode == GROW_NONE )
{ {
// Can only have one allocation when we're in this mode // Can only have one allocation when we're in this mode
if( m_NumBlobs != 0 ) if( m_NumBlobs != 0 )
{ {
Assert( !"CUtlMemoryPool::AddNewBlob: mode == UTLMEMORYPOOL_GROW_NONE" ); Assert( !"CUtlMemoryPool::AddNewBlob: mode == GROW_NONE" );
return; return;
} }
} }
@ -230,15 +251,15 @@ void *CUtlMemoryPool::Alloc( size_t amount )
{ {
void *returnBlock; void *returnBlock;
if ( amount > (unsigned int)m_BlockSize ) if ( amount > (size_t)m_BlockSize )
return NULL; return NULL;
if( !m_pHeadOfFreeList ) if ( !m_pHeadOfFreeList )
{ {
// returning NULL is fine in UTLMEMORYPOOL_GROW_NONE // returning NULL is fine in GROW_NONE
if( m_GrowMode == UTLMEMORYPOOL_GROW_NONE ) if ( m_GrowMode == GROW_NONE && m_NumBlobs > 0 )
{ {
//Assert( !"CUtlMemoryPool::Alloc: tried to make new blob with UTLMEMORYPOOL_GROW_NONE" ); //Assert( !"CUtlMemoryPool::Alloc: tried to make new blob with GROW_NONE" );
return NULL; return NULL;
} }
@ -246,14 +267,14 @@ void *CUtlMemoryPool::Alloc( size_t amount )
AddNewBlob(); AddNewBlob();
// still failure, error out // still failure, error out
if( !m_pHeadOfFreeList ) if ( !m_pHeadOfFreeList )
{ {
Assert( !"CUtlMemoryPool::Alloc: ran out of memory" ); Assert( !"CUtlMemoryPool::Alloc: ran out of memory" );
return NULL; return NULL;
} }
} }
m_BlocksAllocated++; m_BlocksAllocated++;
m_PeakAlloc = max(m_PeakAlloc, m_BlocksAllocated); m_PeakAlloc = MAX(m_PeakAlloc, m_BlocksAllocated);
returnBlock = m_pHeadOfFreeList; returnBlock = m_pHeadOfFreeList;
@ -272,7 +293,7 @@ void *CUtlMemoryPool::AllocZero( size_t amount )
void *mem = Alloc( amount ); void *mem = Alloc( amount );
if ( mem ) if ( mem )
{ {
V_memset( mem, 0x00, amount ); V_memset( mem, 0x00, ( int )amount );
} }
return mem; return mem;
} }
@ -313,4 +334,14 @@ void CUtlMemoryPool::Free( void *memBlock )
m_pHeadOfFreeList = memBlock; m_pHeadOfFreeList = memBlock;
} }
int CUtlMemoryPool::Size() const
{
uint32 size = 0;
for( CBlob *pCur=m_BlobHead.m_pNext; pCur != &m_BlobHead; pCur=pCur->m_pNext )
{
size += pCur->m_NumBytes;
}
return size;
}

4
vphysics/physics_virtualmesh.cpp

@ -443,7 +443,7 @@ CMeshInstance *CPhysCollideVirtualMesh::BuildLedges()
{ {
list.pHull = (byte *)m_pHull; list.pHull = (byte *)m_pHull;
} }
if ( list.triangleCount ) if ( list.triangleCount )
{ {
m_hMemory = g_MeshManager.CreateResource( list ); m_hMemory = g_MeshManager.CreateResource( list );
@ -532,7 +532,6 @@ CPhysCollide *CreateVirtualMesh( const virtualmeshparams_t &params )
void DestroyVirtualMesh( CPhysCollide *pMesh ) void DestroyVirtualMesh( CPhysCollide *pMesh )
{ {
FlushFrameLocks();
delete pMesh; delete pMesh;
} }
@ -547,6 +546,7 @@ IVP_SurfaceManager_VirtualMesh::IVP_SurfaceManager_VirtualMesh( CPhysCollideVirt
IVP_SurfaceManager_VirtualMesh::~IVP_SurfaceManager_VirtualMesh() IVP_SurfaceManager_VirtualMesh::~IVP_SurfaceManager_VirtualMesh()
{ {
FlushFrameLocks();
} }
void IVP_SurfaceManager_VirtualMesh::add_reference_to_ledge(const IVP_Compact_Ledge *ledge) void IVP_SurfaceManager_VirtualMesh::add_reference_to_ledge(const IVP_Compact_Ledge *ledge)

1
vphysics/vphysics_saverestore.cpp

@ -209,7 +209,6 @@ void CVPhysPtrUtlVectorSaveRestoreOps::Restore( const SaveRestoreFieldInfo_t &fi
for ( int i = 0; i < nObjects; i++ ) for ( int i = 0; i < nObjects; i++ )
{ {
void **ppElem = (void**)(&pUtlVector->Element(i)); void **ppElem = (void**)(&pUtlVector->Element(i));
pRestore->ReadData( (char *)ppElem, sizeof(void*), 0 ); pRestore->ReadData( (char *)ppElem, sizeof(void*), 0 );
int iNewVal = s_VPhysPtrMap.Find( *ppElem ); int iNewVal = s_VPhysPtrMap.Find( *ppElem );

2
vphysics/vphysics_saverestore.h

@ -69,7 +69,7 @@ public:
void Restore( const SaveRestoreFieldInfo_t &fieldInfo, IRestore *pRestore ); void Restore( const SaveRestoreFieldInfo_t &fieldInfo, IRestore *pRestore );
private: private:
typedef CUtlVector<int> VPhysPtrVector; typedef CUtlVector<intp> VPhysPtrVector;
}; };
extern CVPhysPtrUtlVectorSaveRestoreOps g_VPhysPtrUtlVectorSaveRestoreOps; extern CVPhysPtrUtlVectorSaveRestoreOps g_VPhysPtrUtlVectorSaveRestoreOps;

4
vstdlib/KeyValuesSystem.cpp

@ -108,8 +108,8 @@ IKeyValuesSystem *KeyValuesSystem()
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
// Purpose: Constructor // Purpose: Constructor
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
CKeyValuesSystem::CKeyValuesSystem() CKeyValuesSystem::CKeyValuesSystem()
: m_HashItemMemPool(sizeof(hash_item_t), 64, UTLMEMORYPOOL_GROW_FAST, "CKeyValuesSystem::m_HashItemMemPool") : m_HashItemMemPool(sizeof(hash_item_t), 64, CUtlMemoryPool::GROW_FAST, "CKeyValuesSystem::m_HashItemMemPool")
, m_KeyValuesTrackingList(0, 0, MemoryLeakTrackerLessFunc) , m_KeyValuesTrackingList(0, 0, MemoryLeakTrackerLessFunc)
, m_KeyValueCache( UtlStringLessFunc ) , m_KeyValueCache( UtlStringLessFunc )
{ {

Loading…
Cancel
Save