1
0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-10 23:07:59 +00:00
qBittorrent/src
Ivan Sorokin 97d08a5b2f Implement sane behavior of space key in torrent content list. Closes #140.
Definitions:

Selection in QTreeView consist of two things:

   currentIndex -- is a (dotted) cell where user clicked last time. Note
                   that it is a cell
   selectedIndexes -- is a set of cells (blue) of current selection.

Checkboxes in torrent content lists are belong to COL_NAME column.

Problem:

The problem is that spacebar toggled checkbox only in currentIndex
index. This has two consequences:

  1. It is impossible to toggle checkboxes on multiple rows
     simultaneously.
  2. If currentIndex is not in COL_NAME column a space key doesn't work
     at all. This problem is amplifyed by the fact that SelectionBehavior
     is set to SelectRows. So visually it is impossible to tell which
     column does it belong to. For end user it looks like "space doesn't
     work sometimes".

This patch addresses the problem by implementing TorrentContentTreeView
derived from QTreeView and overridding keyPressEvent(QKeyEvent*).

The code of TorrentContentTreeView::keyPressEvent is written under
inspiration from QAbstractItemView::keyPressEvent and
QItemDelegate::editorEvent.
2014-11-16 17:19:04 +03:00
..
geoip Replace include of <libtorrent/session.hpp> with forward declaration 2014-10-18 12:19:05 +04:00
Icons Rotate expand image to better suit its use in the UI 2014-11-09 00:28:36 +01:00
lang Sync translations from Transifex and run lupdate. 2014-09-15 00:33:21 +03:00
lineedit Fix indentation in lineedit code. 2013-11-10 04:11:01 +02:00
mac Issue #1251 - Added basic retina support 2014-01-12 08:06:41 -05:00
menuicons
powermanagement Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
preferences WebUI core redesign. 2014-11-02 13:54:48 +03:00
properties Implement sane behavior of space key in torrent content list. Closes #140. 2014-11-16 17:19:04 +03:00
qt-translations
qtlibtorrent Use rgb values to match colors before commit ad116e. Taken from qcolor_p.cpp. 2014-11-09 13:59:36 +02:00
qtnotify
qtsingleapp Update QtSingleApplication. 2014-05-02 00:00:05 +03:00
rss Don't translate file extensions. Closes #1907. 2014-08-30 21:54:57 +03:00
searchengine Use https for Piratebay search plugin. Closes #2093 2014-10-30 21:30:45 +03:00
torrentcreator Merge pull request #2081 from sorokin/split 2014-11-02 16:40:41 +02:00
tracker WebUI core redesign. 2014-11-02 13:54:48 +03:00
webui Show a spinner while torrents are being uploaded 2014-11-09 00:30:37 +01:00
windows Installer correctly associates torrents and magnet links with qBittorrent under non-admin accounts. Closes #291 #527 #579 #614 #964. 2014-07-30 00:09:57 +03:00
about_imp.h Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
about.qrc
about.ui
addnewtorrentdialog.cpp Split src/torrentpersistentdata into .h and .cpp 2014-10-25 16:12:17 +04:00
addnewtorrentdialog.h Show the loaded torrents in the transferlist when qBT is launched with a torrent/magnet and the AddNewTorrentDialog is showing. Closes #1564. 2014-08-09 21:15:17 +03:00
addnewtorrentdialog.ui Implement sane behavior of space key in torrent content list. Closes #140. 2014-11-16 17:19:04 +03:00
autoexpandabledialog.cpp
autoexpandabledialog.h
autoexpandabledialog.ui Remove obsolete translation string (not used anywhere) 2013-10-04 17:55:39 +04:00
bandwidth_limit.ui
confirmdeletiondlg.ui Improve the message of the deletion dialog. Closes #1073. 2013-11-21 18:13:19 +02:00
deletionconfirmationdlg.h Migrate everything to use the new Preferences class and not access directly the qbittorrent.ini file. 2014-08-05 02:34:21 +03:00
dnsupdater.cpp Migrate everything to use the new Preferences class and not access directly the qbittorrent.ini file. 2014-08-05 02:34:21 +03:00
dnsupdater.h
downloadfromurldlg.h
downloadfromurldlg.ui
downloadthread.cpp Work around magnet redirection in feeds 2014-09-16 00:35:46 +04:00
downloadthread.h Work around magnet redirection in feeds 2014-09-16 00:35:46 +04:00
executionlog.cpp
executionlog.h
executionlog.ui
filesystemwatcher.h Fix Qt5 support 2014-09-11 08:44:25 +06:00
fs_utils.cpp Fix Qt5 support 2014-09-11 08:44:25 +06:00
fs_utils.h Speedup compilation speed 2014-10-18 12:19:05 +04:00
gpl.html
headlessloader.h Migrate everything to use the new Preferences class and not access directly the qbittorrent.ini file. 2014-08-05 02:34:21 +03:00
hidabletabwidget.h
ico.cpp Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
ico.h
iconprovider.cpp Increase maximum size of system icons 2014-10-13 18:54:05 +02:00
iconprovider.h Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
icons.qrc Add missing images and fix few paths 2014-11-09 00:28:18 +01:00
lang.qrc Expose new translations and improve language code. 2013-10-20 20:29:32 +03:00
login.ui
loglistwidget.cpp
loglistwidget.h
main.cpp Allow relative torrent paths when qBittorrent is already running 2014-10-18 13:04:18 +02:00
mainwindow.cpp Split trackerlogin into .h and .cpp 2014-11-05 03:10:39 +03:00
mainwindow.h Merge pull request #2051 from pmzqla/filter-input 2014-11-02 15:25:49 +02:00
mainwindow.ui Add option to hibernate computer in Auto-Shutdown menu 2014-07-06 06:13:36 -03:00
messageboxraised.cpp Bring dialog boxes in the front when qbt doesn't have focus. 2014-02-01 14:02:37 +02:00
messageboxraised.h Bring dialog boxes in the front when qbt doesn't have focus. 2014-02-01 14:02:37 +02:00
misc.cpp Cache QRegExp in misc::parseHtmlLinks() 2014-11-09 12:57:14 +03:00
misc.h WEBUI: Protect against timing attacks. Closes #2108. 2014-11-02 21:41:29 +02:00
preview.ui
previewlistdelegate.h Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
previewselect.cpp Migrate everything to use the new Preferences class and not access directly the qbittorrent.ini file. 2014-08-05 02:34:21 +03:00
previewselect.h Preview now correctly uses the selected file. Closes #1222 #1182. 2014-01-02 18:29:05 +02:00
programupdater.cpp Change the program updater's URL for Windows and Mac OS X. Closes #1954. 2014-10-12 16:42:33 +03:00
programupdater.h Improvements on the behavior of the program updater(closes #1282): 2014-01-25 21:03:24 +02:00
qbittorrent_file.ico Make Windows icons suitable for high dpi screens 2014-10-14 17:52:22 +02:00
qbittorrent_mingw.rc
qbittorrent_os2.ico
qbittorrent_os2.rc
qbittorrent.exe.manifest
qbittorrent.ico Make Windows icons suitable for high dpi screens 2014-10-14 17:52:22 +02:00
qbittorrent.rc
qinisettings.h Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
qmacapplication.cpp
qmacapplication.h
reverseresolution.h
scannedfoldersmodel.cpp Migrate everything to use the new Preferences class and not access directly the qbittorrent.ini file. 2014-08-05 02:34:21 +03:00
scannedfoldersmodel.h Migrate everything to use the new Preferences class and not access directly the qbittorrent.ini file. 2014-08-05 02:34:21 +03:00
sessionapplication.cpp Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
sessionapplication.h Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
smtp.cpp SMTP: send the local hostname as FQDN. See discussion in #1845 for more info. 2014-09-13 18:00:51 +03:00
smtp.h add host address parameter to helo smtp request 2014-08-25 14:26:30 +04:00
speedlimitdlg.h
src.pro Implement sane behavior of space key in torrent content list. Closes #140. 2014-11-16 17:19:04 +03:00
stacktrace_win_dlg.h
stacktrace_win_dlg.ui
stacktrace_win.h
stacktrace.h
statsdialog.cpp Speedup compilation speed 2014-10-18 12:19:05 +04:00
statsdialog.h Add dialog to show statistics 2013-11-17 02:16:25 +04:00
statsdialog.ui Add dialog to show statistics 2013-11-17 02:16:25 +04:00
statusbar.cpp Split statusbar into .h and .cpp 2014-11-05 03:10:39 +03:00
statusbar.h Split statusbar into .h and .cpp 2014-11-05 03:10:39 +03:00
torrentcontentfiltermodel.cpp Put directories first when sorting torrent content by name 2014-10-25 21:14:56 +02:00
torrentcontentfiltermodel.h Hide empty folders after filtering. Closes #74. 2013-11-10 03:30:04 +02:00
torrentcontentmodel.cpp Cache icons in TorrentContentModel 2014-11-09 12:57:14 +03:00
torrentcontentmodel.h Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
torrentcontentmodelfile.cpp Drop libtorrent 0.15.x support. 2013-10-23 22:19:58 +03:00
torrentcontentmodelfile.h
torrentcontentmodelfolder.cpp
torrentcontentmodelfolder.h
torrentcontentmodelitem.cpp
torrentcontentmodelitem.h Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
torrentcontenttreeview.cpp Implement sane behavior of space key in torrent content list. Closes #140. 2014-11-16 17:19:04 +03:00
torrentcontenttreeview.h Implement sane behavior of space key in torrent content list. Closes #140. 2014-11-16 17:19:04 +03:00
torrentfilterenum.h Show stalled downloads that are uploading under the 'Active' filter. Closes #1654." 2014-09-13 16:49:11 +03:00
torrentimportdlg.cpp fix import torrent with "Keep incomplete torrents in:" ticked 2014-09-15 00:05:13 +03:00
torrentimportdlg.h Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
torrentimportdlg.ui
torrentpersistentdata.cpp Unused include 2014-11-02 15:37:07 +03:00
torrentpersistentdata.h Remove default argument from TorrentPersistentData::setAddedDate() 2014-10-25 16:12:17 +04:00
trackerlogin.cpp Split trackerlogin into .h and .cpp 2014-11-05 03:10:39 +03:00
trackerlogin.h Split trackerlogin into .h and .cpp 2014-11-05 03:10:39 +03:00
transferlistdelegate.cpp Add "Total Size" column to transfer list 2014-11-02 19:56:03 +01:00
transferlistdelegate.h Split src/transferlistdelegate into .h and .cpp 2014-10-25 16:12:17 +04:00
transferlistfilterswidget.cpp Now user-created labels "all" and "none" works as regular labels 2014-11-09 03:59:49 +03:00
transferlistfilterswidget.h Split src/transferlistfilterswidget into .h and .cpp 2014-10-25 16:12:17 +04:00
transferlistsortmodel.cpp Merge label filter into TransferListSortModel 2014-11-09 03:58:50 +03:00
transferlistsortmodel.h Merge label filter into TransferListSortModel 2014-11-09 03:58:50 +03:00
transferlistwidget.cpp Now user-created labels "all" and "none" works as regular labels 2014-11-09 03:59:49 +03:00
transferlistwidget.h Now user-created labels "all" and "none" works as regular labels 2014-11-09 03:59:49 +03:00
update_qrc_files.py
updownratiodlg.cpp Migrate everything to use the new Preferences class and not access directly the qbittorrent.ini file. 2014-08-05 02:34:21 +03:00
updownratiodlg.h Fix functions and macros using to support both Qt4 and Qt5. 2014-05-02 00:00:03 +03:00
updownratiodlg.ui Allow 2 decimals when setting the share ratio. Closes #1303. 2014-01-23 00:25:09 +02:00