NotTsunami
6748e8d787
Remove redundant null checks
...
Attempting to delete a null pointer is a noop in C++.
Closes #2864 .
[1] https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null
2020-02-03 16:38:51 -05:00
Mike Tzou
e27c9bd020
Merge pull request #11871 from NotTsunami/bitwise
...
WebUI: Use correct operators in logical expressions
2020-01-14 12:54:56 +08:00
Mike Tzou
146e8213a5
Merge pull request #11781 from FranciscoPombal/piece_extent_affinity
...
Add piece_extent_affinity to AdvancedSettings
2020-01-14 12:53:39 +08:00
Vladimir Golovnev
990e451765
Merge pull request #11865 from shemanaev/fix/webui-files-rename
...
WebUI: Fix first row renaming in files tab
2020-01-14 07:14:13 +03:00
FranciscoPombal
df2fbb1edc
Bump Web API version
2020-01-13 11:41:59 +00:00
FranciscoPombal
f4742a98c5
Add stalled filters to GUI and Web API/UI
...
`/api/v2/torrents/info` can now take the following new values for the`filter` parameter: `stalled`, `stalled_uploading` and `stalled_downloading`.
Requires Web API version bump.
Closes #11787
2020-01-13 11:41:37 +00:00
NotTsunami
82047104fc
WebUI: Use correct operators in logical expressions
...
As suggested in https://github.com/qbittorrent/qBittorrent/pull/11825#discussion_r365557626
2020-01-13 01:35:38 -05:00
FranciscoPombal
ed96a07a75
Add piece_extent_affinity to AdvancedSettings
...
Expose option in WebUI settings and WebAPI.
Requires WebAPI version bump.
Closes #11436 .
2020-01-13 00:11:29 +00:00
Denis
a7eb792372
WebUI: Fix first row renaming in files tab
...
Ids started from zero and first row converts to false.
Closes #11826 .
2020-01-12 20:05:38 +03:00
Chocobo1
029795bc19
Bump copyright year
2020-01-11 18:47:33 +08:00
An0n
bf32e90c40
Change placement of stop tracker timeout
2020-01-09 19:01:05 +00:00
Mike Tzou
057860584c
Merge pull request #11834 from an0n666/an0n666-expose-stop-tracker-timeout
...
Expose stop tracker timeout in Advanced Settings (GUI + WebUI)
2020-01-08 17:30:21 +08:00
an0n666
3f223c3a45
Expose stop_tracker_timeout in advanced settings
2020-01-08 08:21:55 +00:00
Chocobo1
c556b20018
Remove unused variable
2020-01-07 02:08:08 +08:00
Chocobo1
c34883f9af
Add explicit semicolon
2020-01-07 02:07:55 +08:00
Chocobo1
0577cf588c
Remove duplicate line
2020-01-07 01:59:02 +08:00
Mike Tzou
e906478a16
Merge pull request #11756 from FranciscoPombal/fix_webui_stats_race
...
WebUI: fix populating statistics window
2019-12-28 10:37:03 +08:00
FranciscoPombal
8be804b6ff
WebUI: fix populating statistics window
...
Closes #11665
2019-12-27 12:10:12 +00:00
Mike Tzou
5c3c1e07df
Merge pull request #11739 from Chocobo1/qt5_14
...
Migrate away from deprecated API in Qt 5.14
2019-12-26 12:43:04 +08:00
Chocobo1
2422d81de1
Migrate away from deprecated API in Qt 5.14
2019-12-25 19:23:37 +08:00
Mike Tzou
e62b550bfe
Merge pull request #11635 from FranciscoPombal/prevent_excessive_sync
...
WebUI: Prevent excessive requests to /api/v2/sync/maindata
2019-12-25 13:15:13 +08:00
Mike Tzou
07d4055de5
Merge pull request #11745 from FranciscoPombal/fixup_#11592
...
WebUI: remove unused/deprecated "Listen on IPv6 address" option
2019-12-25 13:07:24 +08:00
Mike Tzou
fea39fbcf2
Merge pull request #11726 from FranciscoPombal/fix_#11724
...
WebUI: Implement "Secure" flag for session cookie. Closes #11724
2019-12-25 13:06:40 +08:00
FranciscoPombal
0f6dfcf8a6
WebUI: Prevent excessive sync requests
...
Don't sync main data if a request to do so is already in progress.
This prevents piling up of requests and bogging down slow/busy machines, since the current implementation of `/api/v2/sync/maindata` is very computationally intensive, especially with lots of torrents.
Everything gets updated on the next scheduled request anyway (via the timeout mechanism).
2019-12-24 12:15:26 +00:00
sledgehammer999
f672df1cf1
Merge pull request #11278 from Piccirello/country_region
...
Rename Country column to "Country / Region"
2019-12-23 21:54:30 +02:00
FranciscoPombal
e693fdeaf9
WebUI: remove unused/deprecated option
...
Fixup 8200ef6
Remove "Listen on IPv6 address" option.
2019-12-23 18:57:46 +00:00
FranciscoPombal
691d5e5d89
WebUI: Implement "Secure" flag for session cookie
...
Closes #11724 .
Option is enabled by default for users using qBittorrent's built-in HTTPS capabilities. This flag will never be set if qBittorrent is using plain HTTP.
Users using HTTPS reverse proxies, like "qbt <-> (http) <-> proxy <-> (https) <-> user" should override the flag in the proxy in order to set it, if they wish to do so.
2019-12-23 17:58:08 +00:00
sledgehammer999
a25ed5f639
Sync translations from Transifex and run lupdate
2019-12-18 00:33:00 +02:00
sledgehammer999
1376e051df
Bump Web API version
2019-12-18 00:20:27 +02:00
sledgehammer999
d09c5e529c
Merge pull request #11592 from sledgehammer999/refactor_listeningAddr
...
Rework the listening IP/interface selection code
2019-12-12 20:24:45 +02:00
sledgehammer999
8200ef6bd5
Rework the listening IP/interface selection code
...
Closes #11561
2019-12-11 09:56:45 +02:00
nl6720
5f5385d4dd
Fix quoting of alert() in client.js
...
Fix alert() I broke in #11615 .
2019-12-10 12:45:55 +02:00
Mike Tzou
a652c39394
Merge pull request #11029 from Piccirello/webui-rename-file
...
Add ability to rename torrent files from the WebUI
2019-12-10 12:39:19 +08:00
Thomas Piccirello
2bce9f6179
Add ability to rename torrent files from the WebUI
...
Renaming folders is not yet supported. Closes #8892 .
2019-12-09 02:57:32 -08:00
Thomas Piccirello
9fecd18293
Fix incorrect function being used
2019-12-09 02:53:36 -08:00
nl6720
c1ef846c3d
Mention lack of HTTPS in WebUI magnet link warning
...
According to Mozilla docs, registerProtocolHandler() is only
available when using secure contexts (i.e. HTTPS for everything
outside localhost).
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/registerProtocolHandler
The message "Your browser does not support this feature" does not
make this obvious and can lead to confusion if the user is using a
modern browser.
2019-12-08 11:41:30 +02:00
Chocobo1
5f165c4c00
Fix HTML elements size in search tab
...
Specifying a height/width value might cut the displayed text or
obstruct centering the text in the button, so let it auto decide
instead.
Closes #11553 .
2019-12-04 18:25:14 +08:00
Thomas Piccirello
33a3624652
Rename Country column to "Country / Region"
...
Not all flags displayed strictly belong to countries.
2019-12-03 23:05:38 -08:00
Chocobo1
04f270b9bc
Fix missing translations in search plugins dialog
...
Closes #11551 .
2019-12-04 12:20:11 +08:00
sledgehammer999
f46058bbd6
Sync translations from Transifex and run lupdate
2019-12-02 23:37:06 +02:00
sledgehammer999
bd3f723ebf
Merge pull request #11474 from sledgehammer999/webui_bump
...
Bump Web API version
2019-11-27 22:37:40 +02:00
sledgehammer999
c27457efda
Sync translations from Transifex and run lupdate
2019-11-21 21:21:58 +02:00
Chocobo1
8fe8cbd3d1
Reuse code path in switch cases
2019-11-14 12:14:29 +08:00
Chocobo1
9b5df92078
Give better name to parameter checking function
...
This function will throw exceptions if the required parameters do not
exsit hence a stronger word is more appropriate here.
Also change the function parameter type to QVector. We don't need the
duplicate entries checking as currently we only use 3 fields at max and
can be easily checked by hand. So drop back to QVector which can be
constructed more efficiently.
2019-11-14 12:14:20 +08:00
sledgehammer999
eff0208382
Bump Web API version
...
Closes #11403
2019-11-11 02:18:59 +02:00
sledgehammer999
0ff3b7641d
Correctly update WebUI translations
2019-11-11 02:13:35 +02:00
sledgehammer999
871161310b
Sync translations from Transifex and run lupdate
2019-11-11 02:03:06 +02:00
Chocobo1
6fd678195c
Replace deprecated Qt functions
...
QSet::toList() is replaced by QSet::values()
2019-10-31 12:40:24 +08:00
Chocobo1
e32ef7f5c5
Use implicit sharing when getting categories from Session class
2019-10-30 01:46:57 +08:00
sledgehammer999
009ccbef7f
Bump Web API version
...
Closes #11304
2019-10-27 17:20:28 +02:00