Thomas Piccirello
1f42ab8c4f
Remove unused/superfluous variables
7 years ago
Thomas Piccirello
3f0fbc0810
WebUI rename property to match its definition
7 years ago
sledgehammer999
7e4b62c68d
Merge pull request #8701 from Kolcha/musl-support
...
Allow to disable Stacktrace support
7 years ago
sledgehammer999
784b154228
Merge pull request #8721 from sledgehammer999/fix_string_arg
...
Fix wrong QString::arg() usage that leads to crash
7 years ago
sledgehammer999
ddba79ef3d
Fix wrong QString::arg() usage that leads to crash
...
We need to be careful when using the multi-arg version of
QString::arg() and passing as 2nd, 3rd etc parameter an int.
It doesn't do the same as passing multiple QStrings.
7 years ago
Nick Korotysh
7712d0ada0
Allow to disable Stacktrace support
...
Enable backtrace stuff only if GNU C library used, because current
backtrace implementation based on <execinfo.h> , which is not a
part of standard C library, it is a GNU extension.
This will be usefull when building with custom POSIX-compilant C
library (like musl) and no <execinfo.h> available.
Note: configure script will detect presence of <execinfo.h> and
enable/disable feature depending on it.
Feature is enabled by default.
7 years ago
Mike Tzou
38837db8de
Merge pull request #8699 from Chocobo1/linking
...
Add helper for loading Windows system functions
7 years ago
sledgehammer999
d997d887e5
Merge pull request #8650 from luis-pereira/fix-invalid-iterator-crash
...
Fix crashes due to invalid iterator use
7 years ago
sledgehammer999
341a971cd3
Merge pull request #8711 from sledgehammer999/recheck_paused
...
Avoid data corruption when rechecking paused torrents
7 years ago
Mike Tzou
fa380c8b2c
Merge pull request #8622 from Chocobo1/formatter
...
Unify coding style for WebUI files
7 years ago
Luís Pereira
758c70283f
Fix crashes due to invalid iterator use
...
Although the iterators are constant we are indirectly changing them.
Introduced by commit ac42ccb5e4
.
Closes #8633
7 years ago
sledgehammer999
747c70a58e
Avoid data corruption when rechecking paused torrents
...
Libtorrent can recheck only unpaused torrents. We get around this by
unpausing the torrent, issuing the recheck and pausing again after we
get alerted by libtorrent that the recheck has finished. This alert is
asyncronous. There is a small time frame where the program might start
downloading and writing data to the file before we pause it. This can
lead to data corruption if the file on disk is totally different that
the one expected by the torrent AND the file on disk is a valid file on
its own. OR in case the user points the new torrent to the wrong
directory by mistake.
To get around this the torrent is placed in upload_mode and out of
automanagement.
7 years ago
sledgehammer999
6ca2e42bca
Merge pull request #8715 from glassez/max-ratio
...
Fix setting preferences via WebAPI. Closes #7335
7 years ago
Vladimir Golovnev (Glassez)
cb505a07fe
Fix setting preferences via WebAPI
...
Closes #7335 .
7 years ago
Chocobo1
5819b6dd39
Use Unicode version of InitiateSystemShutdown
7 years ago
Chocobo1
644e7d0450
Use dynamic linking for SetSuspendState function
7 years ago
Chocobo1
b0e3d77975
Add helper for loading Windows system functions
7 years ago
Chocobo1
643a209812
Sort include headers
...
Also add anonymous namespace.
7 years ago
Mike Tzou
c3311e83a0
Merge pull request #8687 from Chocobo1/folder
...
Stop creating Download folder on start
7 years ago
Mike Tzou
3301e9cb69
Merge pull request #8690 from Chocobo1/options
...
Avoid showing an empty row in AdvancedSettings
7 years ago
Chocobo1
cf2c0bd47e
Apply formatting to Web UI files
7 years ago
Mike Tzou
df0c5c41c5
Merge pull request #8681 from dzmat/uncrutify_tinkering
...
Make uncrustify.cfg available to QtCreator IDE
7 years ago
Chocobo1
59e6757242
Avoid showing an empty row in AdvancedSettings
...
Fixup 543cbc6d1c
.
7 years ago
Chocobo1
6bbcf9b3d6
Stop creating Download folder on start
...
The existence of this folder isn't required to run qbt and it can be
created when adding torrent.
Closes #8290 .
7 years ago
Chocobo1
208d21ff73
Add js-beautify config
...
Try to standardize coding style for HTML & JavaScript via this tool
7 years ago
Chocobo1
2df71dbde5
Partially revert "Remove unused JavaScript library"
...
This reverts commit 470e993c2d
.
7 years ago
Mike Tzou
9e4f246c89
Merge pull request #8672 from Chocobo1/js
...
Move JavaScript libraries to its own folder
7 years ago
Mike Tzou
e4fc8e4156
Merge pull request #8669 from Chocobo1/runext
...
Split args manually in runExternalProgram()
7 years ago
dzmat
883d4d81d5
Make uncrustify.cfg available to Qt Creator IDE
7 years ago
Mike Tzou
041b86981f
Merge pull request #8665 from Chocobo1/iostream
...
Use lightweight printf instead of iostream
7 years ago
Chocobo1
470e993c2d
Remove unused JavaScript library
7 years ago
Chocobo1
cbf10ebb7f
Update clipboard.js to v2.0.0
7 years ago
Chocobo1
89f06274bb
Move JavaScript libraries to its own folder
7 years ago
Chocobo1
c07cd440cd
Split args manually in runExternalProgram()
...
Need to split arguments manually because QProcess::startDetached(QString)
will strip off empty parameters.
E.g. `python.exe "1" "" "3"` will become `python.exe "1" "3"`.
Closes #8454 .
7 years ago
Mike Tzou
e90be67fec
Merge pull request #8640 from Chocobo1/guide2
...
Clarify braces usages in CODING_GUIDELINES
7 years ago
Chocobo1
37ea01bd44
Use lightweight printf instead of iostream
...
Using iostream usually adds a lot of other operators (<<, endl), whereas
*printf takes only 1 function call.
Also use qUtf8Printable whenever possible.
7 years ago
Mike Tzou
ccc91e2e52
Merge pull request #8629 from Chocobo1/guide
...
Extend Coding Guidelines to cover other languages
7 years ago
Chocobo1
d31954761f
Clarify braces usages in CODING_GUIDELINES
...
Merge "Curly braces" & "If blocks" sections into "New lines & curly braces" section.
Add note about the list is not exhaustive and style can be determine on code review.
7 years ago
Mike Tzou
aa122b062e
Merge pull request #8615 from Chocobo1/watcher
...
Improve FS watcher
7 years ago
Chocobo1
65921eaf7b
Remove QPointer wrapper
7 years ago
Chocobo1
bfbd978d3f
Move helper function to Utils::Fs
7 years ago
Chocobo1
1876dbd523
Fix typo
7 years ago
Chocobo1
ea7eb7c0ec
Add delay before processing FS changes
...
This prevents file renaming errors in monitored folder on linux, for
example: ABC.torrent.part -> ABC.torrent
7 years ago
Chocobo1
19c733ce95
Use specific name for rejected files
7 years ago
Chocobo1
2ba5dd1344
Reduce debug messages
7 years ago
Chocobo1
61eddfce90
Refactor functions in FileSystemWatcher
...
Use c++11 range-loop
Add const
Better ifdef placement
Inline functions
7 years ago
Chocobo1
0840556f77
Do cleanups in FileSystemWatcher
...
Use Qt5 connect syntax
Sort headers
Add license
Add anonymous namespace
Replace macro defines with const variables
7 years ago
Mike Tzou
f564e8a1c4
Merge pull request #8621 from Chocobo1/html5
...
Update WebUI to be more compliant with HTML5 standard
7 years ago
Chocobo1
315d9835b2
Extend Coding Guidelines to cover other languages
7 years ago
Chocobo1
ed03456999
Update WebUI to be more compliant with HTML5 standard
...
Use modern and shorter "charset" attribute.
Remove "type", "charset" attributes in script/style tags, these are redundant in HTML5.
7 years ago