Chocobo1
e288de7ec1
Forward declare as much as possible
2019-05-19 12:06:18 +08:00
Mike Tzou
3d6dccc689
Merge pull request #10627 from Chocobo1/alg
...
Improve removeIf() to support other types
2019-05-16 10:45:55 +08:00
Evgeny Lensky
62c72091ce
Change "Add new torrent" dialog to horizontal layout
2019-05-14 11:03:56 +08:00
Chocobo1
c6f3da1097
Improve removeIf() to support set types
...
We can now replace QMutable*Iterator by removeIf() which usage is more consistent with other
algorithm functions.
2019-05-14 01:26:01 +08:00
Ekin Dursun
c0c2fe247b
Don't turn screen blank when closed to system tray
...
Closes #9240 and possibly #9121 , as @zeule suggested here: https://github.com/qbittorrent/qBittorrent/issues/9240#issuecomment-408025722 .
2019-05-07 02:08:46 +03:00
Mike Tzou
3a3dec1707
Merge pull request #10445 from Chocobo1/crash
...
Work around crashing in Qt networking library
2019-05-03 22:54:25 +08:00
Mike Tzou
2d7b833ae6
Merge pull request #10537 from Chocobo1/template
...
Minor cleanups
2019-05-01 23:51:23 +08:00
Chocobo1
375de4f8a6
Replace QMap with QHash when sensible
2019-05-01 11:09:25 +08:00
dzmat
7de0f9abed
Change number of time axis divisions from 5 to 6 for convenience
2019-04-22 00:15:13 +07:00
dzmat
0af17bf7e9
Add 12 hour and 24 hour speed graphs
2019-04-22 00:15:13 +07:00
Mike Tzou
19dfec1e0a
Merge pull request #10464 from thalieht/torrent-size-limit
...
Increase the download request size limit from 10 to 100 MiB
2019-04-11 10:14:49 +08:00
thalieht
25102b9c5d
Increase the download size limit to 100 MiB
2019-04-10 11:39:27 +03:00
Chocobo1
4bf4313862
Initialize class variable via constructor
2019-04-08 23:29:14 +08:00
thalieht
371a090cec
Rename "Prefer encryption" to "Allow encryption"
...
Because it actually prefers non-encryption but allows it if requested.
2019-04-05 14:18:49 +03:00
Chocobo1
1ea61db1fb
Disable downloading tracker favicons by default
...
Workaround for a crash in Qt networking library, source:
https://github.com/qbittorrent/qBittorrent/issues/9667#issuecomment-464445025
Closes #9667 .
2019-04-05 13:54:40 +08:00
thalieht
3731a3ea65
Make num enter key work the same as return in searchjobwidget
2019-03-22 20:01:48 +02:00
Vladimir Golovnev (Glassez)
ead078a38e
Add preliminary support of libtorrent v1.2
...
libtorrent v1.2 should be built with deprecated features enabled.
2019-03-18 15:17:03 +03:00
Mike Tzou
d1b0c230ed
Merge pull request #10366 from Chocobo1/logger
...
Avoid performance penalty when logger is full
2019-03-17 15:04:53 +08:00
Chocobo1
cb9a160366
Utilize parent pointer appropriately
2019-03-15 14:29:07 +08:00
Chocobo1
a3019f56b0
Clean up code
2019-03-15 14:29:06 +08:00
thalieht
4c53447d35
Remove the max half-open connections option from GUI
...
Its functionality was deprecated long ago.
2019-03-13 21:08:40 +02:00
thalieht
bcfa62cc76
Rename "#" column to "Tier" in the tracker list
2019-03-13 21:08:40 +02:00
thalieht
cccaca0c01
Center align the section labels in advanced settings
2019-03-13 21:08:40 +02:00
thalieht
3fca49e44d
Add documentation links to some advanced settings
2019-03-13 21:08:40 +02:00
Mike Tzou
c47d6b517a
Merge pull request #10355 from Chocobo1/label
...
Improve AdvancedSettings::addRow()
2019-03-11 00:25:35 +08:00
Vladimir Golovnev
928ce940c9
Merge pull request #10346 from glassez/download-manager
...
Improve "Download manager"
2019-03-10 09:13:07 +03:00
Vladimir Golovnev (Glassez)
746916a963
Use DownloadHandler behind the scenes
2019-03-08 13:00:37 +03:00
sledgehammer999
c2d1af9853
Merge pull request #10338 from sledgehammer999/raise_qt5_ver
...
Raise minimum Qt version to 5.9.0
2019-03-08 00:42:26 +02:00
Chocobo1
f9e10616d0
Improve AdvancedSettings::addRow()
...
1. Add context to connect().
2. Use QLabel in the left table cell, this allows using rich text formatting, such as HTML links.
2019-03-07 16:22:23 +08:00
Mike Tzou
ccd8f3e0f1
Merge pull request #10340 from Chocobo1/move
...
Move helper functions to Utils::Gui namespace
2019-03-07 15:11:58 +08:00
paolo-sz
1ea7907e09
Add default tooltip "Searching..." on tab creation.
2019-03-05 20:36:49 +01:00
paolo-sz
22835c0350
Avoid crashes on torrent search
...
qbittorrent closes itself without any error message when a search tab
should be notified of a status change: fixed bad pointer variable catch
in lambda code.
2019-03-05 20:36:49 +01:00
Chocobo1
78b9eafed2
Replace deprecated qt_mac_set_dock_menu()
2019-03-05 17:17:07 +08:00
Vladimir Golovnev (Glassez)
6cb15706f5
Reduce number of DownloadManager signals
2019-03-05 11:28:29 +03:00
Chocobo1
adbd34c795
Move helper functions to Utils::Gui namespace
2019-03-05 14:55:22 +08:00
sledgehammer999
5c63ad3b95
Raise minimum Qt version to 5.9.0
2019-03-04 16:48:49 +02:00
Mike Tzou
0f1fc7be9d
Merge pull request #10302 from Chocobo1/uptr
...
Replace QScopedPointer with std::unqiue_ptr
2019-03-02 12:26:14 +08:00
Chocobo1
3dd969df64
Replace deprecated QSignalMapper class
2019-02-28 12:03:08 +08:00
Chocobo1
c6ae1aa9d9
Replace deprecated QString::null
2019-02-28 12:02:03 +08:00
Mike Tzou
46bc1d12b9
Merge pull request #10314 from thalieht/const2
...
More const
2019-02-28 11:33:35 +08:00
thalieht
77aea3c59e
Add const to a few pointer arguments
2019-02-25 17:05:15 +02:00
thalieht
ce437817de
Make various minor changes
2019-02-25 17:05:15 +02:00
thalieht
89dce36e98
Use uniform initialization on some default arguments
2019-02-25 17:05:15 +02:00
thalieht
8a19a0d4a0
Remove const in declarations' arguments that are passed by value
2019-02-25 17:05:15 +02:00
thalieht
70f1537d9f
Add const to almost all remaining vars and arguments that qualify
2019-02-25 17:05:15 +02:00
Chocobo1
e5dca50025
Convert to use private pointer for ui object
2019-02-25 01:22:40 +08:00
Mike Tzou
bb041c0eca
Merge pull request #10292 from Chocobo1/rmInvalid
...
Load torrent from data directly
2019-02-21 23:18:02 +08:00
Chocobo1
5c0d9b7eab
Load torrent from data directly
2019-02-20 00:14:41 +08:00
Chocobo1
5e3fddf456
Replace QScopedPointer with std::unqiue_ptr
...
These 2 types are very similar and we should prefer the one from C++
standard library, this reduces the number of types in our code base.
Also see:
https://stackoverflow.com/questions/40346393/should-i-use-qscopedpointer-or-stdunique-ptr#comment67966940_40346991
2019-02-18 16:06:40 +08:00
thalieht
8c944bd4e1
Avoid repeating the return type
2019-02-16 18:54:18 +02:00
thalieht
92a290895b
Convert vars into refs to avoid copy construction from const refs
2019-02-16 18:54:17 +02:00
thalieht
400792d18e
Use isEmpty() instead of size() for emptiness
2019-02-16 18:54:17 +02:00
thalieht
d8cbc9266a
Use 'auto' to avoid duplicating the type name
2019-02-16 18:54:17 +02:00
thalieht
947c7e1d64
Convert to range-based for loop
2019-02-16 16:53:26 +02:00
thalieht
8a3f942385
Don't use 'else' after return/break
2019-02-13 18:23:25 +02:00
Mike Tzou
78ab0e4ba9
Merge pull request #10220 from thalieht/const
...
Add const to many vars and arguments
2019-02-13 12:11:00 +08:00
thalieht
445adb0ab4
Convert pass-by-value arguments to const refs where applicable
2019-02-12 02:45:55 +02:00
thalieht
ca3ce87e06
Add const to many vars and arguments
...
Also remove const in declarations' arguments that are passed by value
2019-02-11 20:19:41 +02:00
Mike Tzou
efed3fc78c
Merge pull request #10256 from Chocobo1/license
...
Add license header
2019-02-08 12:07:08 +08:00
Mike Tzou
6f0a66ce26
Merge pull request #10255 from Chocobo1/algorithm
...
Make use of std algorithms and C++14 features
2019-02-07 10:45:40 +08:00
Chocobo1
6d29a3af60
Make use of std algorithms
2019-02-05 13:35:54 +08:00
Chocobo1
f789df7edf
Add license header
2019-02-04 17:28:55 +08:00
Vladimir Golovnev
e9f3e20e67
Merge pull request #10243 from glassez/content-menu
...
Close context menu when torrent content model is reset. Closes #9522
2019-02-02 21:13:41 +03:00
Vladimir Golovnev (Glassez)
5a86c4ac52
Close context menu when content model is reset
...
Closes #9522 .
2019-02-01 18:44:26 +03:00
Mike Tzou
40eb8a1f4a
Merge pull request #10175 from Chocobo1/cert
...
Load WebUI certificate & key from file path
2019-02-01 13:37:13 +08:00
Vladimir Golovnev (Glassez)
c631dbdaa1
Improve Properties widget
...
Drop redundant dependencies.
Refresh after BitTorrent session refreshing (instead of using timer).
2019-01-28 12:42:12 +03:00
Chocobo1
5cdb3b6a2d
Load WebUI certificate & key from file path
...
This allow users to update certificate & key more easily, i.e. without the need to import them
into qbt.
Closes #6675 , #7547 , #8315 , #8564 .
2019-01-28 16:33:48 +08:00
sledgehammer999
bb3ad8acd3
Merge pull request #10191 from sledgehammer999/drop_google
...
Don't query Google for tracker favicons
2019-01-27 22:19:56 +02:00
sledgehammer999
009fd0e211
Don't query Google for tracker favicons
...
It is a bad idea for user privacy to automatically contact a 3rd party
about tracker domains. Especially when the user isn't informed about
this and the 3rd party is Google.
Reverts 1b9882b3a3
2019-01-21 16:15:09 +02:00
Chocobo1
04227f5a41
Add QBT_APP_64BIT define
...
Now we use QT_POINTER_SIZE to detect CPU bitness, it has the advantage of applicable to all CPU
architectures not limiting to x86 arch.
2019-01-19 10:14:10 +08:00
Mike Tzou
81c09d34ad
Merge pull request #10163 from airium/allow-larger-checking-memory-usage
...
Allow setting larger checking memory usage in GUI
2019-01-19 01:30:55 +08:00
sledgehammer999
2ac7f2defe
Update copyright year
2019-01-17 01:08:51 +02:00
sledgehammer999
6c6d75f607
Mention Swedish translator
...
Closes #10103
2019-01-17 00:53:38 +02:00
airium
dbca4346aa
Allow setting larger checking memory usage in GUI
2019-01-16 14:23:21 +08:00
Vladimir Golovnev (Glassez)
302c99d7d5
Drop support of libtorrent < 1.1.10
2019-01-11 15:13:17 +03:00
sledgehammer999
88295f8075
Merge pull request #10094 from Kolcha/pb-fix
...
Draw progress bar in Fusion style on macOS systems
2019-01-04 00:31:34 +02:00
Bert Verhelst
9f8f9b6702
Converted remaining icons to svg
2019-01-04 00:24:30 +02:00
Nick Korotysh
bd1856594b
Draw progress bar in Fusion style on macOS systems
...
Qt has a bug QTBUG-72558, which leads to incorrect progress bar
position, when drawing it in delegate.
Also, since OS X 10.10 Yosemite macOS default style was changed,
and progress bars became very tiny and without text (percentage).
These two cases make qBittorrent look pretty awful, but drawing
progress bar in Fusion style solves both issues.
2019-01-02 10:01:32 +03:00
Mike Tzou
b87987ec89
Merge pull request #10074 from Chocobo1/magneturi
...
Drop support for "BC Link" format
2019-01-01 23:13:05 +08:00
Chocobo1
2b903fc3d1
Move Utils::Misc::isUrl() function
...
All usage of this function gets to call Net::DownloadManager eventually.
2018-12-31 20:00:15 +08:00
Chocobo1
6759446639
Cleanup code
...
Also remove redundant code, it is already handled correctly in subsequent function calls.
2018-12-31 20:00:15 +08:00
Mike Tzou
3772968f49
Merge pull request #10076 from Chocobo1/pr_9756
...
Prevent flickering preview dialog
2018-12-31 13:45:55 +08:00
sledgehammer999
6236aee8d5
Merge pull request #10046 from sledgehammer999/translator
...
Mention more translators
2018-12-30 18:20:53 +02:00
Chocobo1
dd2763d725
Forward declare TorrentHandle
2018-12-29 18:39:54 +08:00
silver
0b47021504
Prevent flickering preview dialog
...
Avoid instantiation of a preview dialog, when torrent is not
previewable
2018-12-29 18:39:54 +08:00
Chocobo1
2a84345835
Mark constructors as explicit
2018-12-26 12:04:40 +08:00
sledgehammer999
5b62aaa9f8
Mention more translators
...
Closes #10043
2018-12-25 14:19:07 +02:00
Thomas Piccirello
718f66e6a2
Remove condition for unsupported libtorrent version
2018-12-11 01:37:32 -05:00
Thomas Piccirello
c89e9d4354
Reorder and rename Tracker list context menu option
...
Adds an ellipses to indicate that the Edit option opens a dialog. Also moves Edit to top of the list to convey action's prominence.
2018-12-11 00:41:18 -05:00
Thomas Piccirello
b481787574
Rename Tracker List columns
...
"Received" renamed to "Peers", "Peers" renamed to "Leeches".
2018-12-11 00:41:18 -05:00
Mike Tzou
cf9d903ba9
Merge pull request #9541 from Piccirello/webui-file-priority
...
Set priority for multiple files in one WebAPI request
2018-12-11 13:32:53 +08:00
Thomas Piccirello
57e625494b
Update Copyright email address
2018-12-10 23:21:09 -05:00
Thomas Piccirello
f27dc977e9
Replace prio namespace with FilePriority enum class
2018-12-10 23:21:09 -05:00
Mike Tzou
c093561532
Merge pull request #9980 from Chocobo1/opensslVersion
...
Add OpenSSL version to GUI & stackdump
2018-12-09 15:57:33 +08:00
Chocobo1
f13bcbd772
Add OpenSSL version to GUI & stackdump
2018-12-08 12:46:50 +08:00
Thomas Piccirello
3aeaf6a054
Disallow setting a blank alternative WebUI location
2018-12-07 00:57:59 -05:00
Thomas Piccirello
d05cf47169
Add WebUI Auto TMM options
2018-12-07 00:55:29 -05:00
Mike Tzou
6bb4eb825b
Merge pull request #9942 from Chocobo1/pbkdf2
...
Do password hashing properly
2018-12-06 16:22:22 +08:00
Mike Tzou
1eef5b6876
Merge pull request #9373 from FranciscoPombal/checking_mem_usage_adv_settings
...
Add checking_mem_usage option to AdvancedSettings
2018-12-06 16:20:02 +08:00
Mike Tzou
0ab5b8fcba
Merge pull request #9824 from thalieht/style
...
Convert all foreach() to range-based for()
2018-12-06 16:19:17 +08:00
FranciscoPombal
74be5d9030
Add checking_mem_usage option to AdvancedSettings
2018-12-06 03:10:24 +08:00
Chocobo1
2c8890bd06
Apply PBKDF2 to GUI lock
2018-12-05 13:28:42 +08:00
Chocobo1
05d6a29416
Apply PBKDF2 when storing passwords
2018-12-05 13:28:42 +08:00
thalieht
6a21acbf1a
Save option to start minimized in Mac
2018-12-04 11:43:32 +02:00
Chocobo1
297ef52dcb
Fix weekday names translations
...
Closes #9933 .
2018-12-01 20:32:35 +08:00
Chocobo1
0ad831e48a
Fix strings not translated
...
Closes #9934 .
2018-12-01 20:32:34 +08:00
thalieht
1f36b8b89f
Combine qAsConst() with copyAsConst() to asConst()
2018-11-28 23:41:23 +02:00
thalieht
6b1d26d555
Convert all foreach() to range-based for()
2018-11-28 23:40:12 +02:00
thalieht
d668a4fe6d
Fix coding style for various things
2018-11-28 23:37:35 +02:00
Chocobo1
0339e6ee35
Clean up code
2018-11-27 22:01:27 +08:00
Chocobo1
58be2d4bc2
Put WebUI security related options into a groupbox
2018-11-19 11:05:04 +08:00
Chocobo1
344e47dcfb
Add option for WebUI Host header validation
...
Closes #9743 .
2018-11-19 11:05:04 +08:00
Chocobo1
d866033a8e
Fix divide-by-zero crash
...
Previously here was using a cheap method to avoid divisor becoming < 0, but from
the crash stacktrace it seems this is not enough, now the divisor is properly
clamped to have 1 as the minimum.
Also it will now display "Unknown" for invalid calculation results.
Closes #9857 .
2018-11-18 13:50:23 +08:00
Mike Tzou
9090f2d321
Merge pull request #9832 from thalieht/fieldwidth
...
Allow qBt to resize the search filter in search job
2018-11-14 03:58:37 +08:00
thalieht
59fcfdc13b
Allow resizing search filter in search job
...
Allow qBt to resize the search filter in search job because it causes
qBt's width to exceed the screen's width for laptop users.
2018-11-13 11:20:29 +02:00
sledgehammer999
ceb4a0d5fe
Change FossHub RSS url for updates
...
The new RSS format is compatible with our current parser. FossHub will
redirect old URL to the new one so older clients will not be affected.
2018-11-11 18:30:00 +02:00
Mike Tzou
547140ec46
Merge pull request #9822 from Chocobo1/fixCrash
...
Don't double delete a pointer
2018-11-09 00:11:09 +08:00
Chocobo1
626b9eb380
Don't double delete a pointer
...
`m_searchFilterAction` is owned by Qt, so we shouldn't delete it
manually.
2018-11-08 21:02:44 +08:00
Mike Tzou
2ce57b97be
Merge pull request #9799 from Chocobo1/removeCheckbox
...
Remove speed limit checkbox in Options dialog
2018-11-07 13:40:43 +08:00
dzmat
6fa64c81b7
Fix speed graph "high speeds" bug
2018-11-06 15:53:20 +03:00
Chocobo1
266ce1d226
Clean up SpeedLimitDialog class
2018-11-05 11:07:52 +08:00
Chocobo1
3fa5358c3f
Remove speed limit checkbox in Options dialog
...
This unifies speed limit UI elements throughout the program.
2018-11-05 11:07:52 +08:00
Vladimir Golovnev
dea6b3d7e0
Merge pull request #9562 from dzmat/round_speed_labels
...
Improve scaling of speed graphs
2018-11-01 09:46:26 +03:00
Vladimir Golovnev
7e36cc746f
Merge pull request #8584 from Piccirello/new-search-api-2
...
WebUI search API. Closes #2495
2018-10-24 13:13:16 +03:00
dzmat
fabd7e34f5
Improve scaling of speed graphs
...
Make Y axis scale to fix on predetermined nice looking positions
2018-10-21 16:45:32 +07:00
dzmat
23d924643f
Reduce horizontal graphs resolution
...
Rewrite averaging code and reduce horizontal graphs resolution for
30 minutes and 6 hours graphs to decrease CPU usage.
2018-10-13 18:28:38 +07:00
Vladimir Golovnev
72e148e0f1
Merge pull request #9590 from dzmat/disable_graphs_collection
...
Implement option for disabling speed graphs
2018-10-12 08:24:33 +03:00
Vladimir Golovnev
305c1fc851
Merge pull request #8980 from silverqx/clear-on-esc
...
Clear LineEdit on ESC
2018-10-11 17:31:38 +03:00
Stephen Dawkins
d8054f9cb3
Allow to disable downloading REPACK/PROPER matches
2018-10-09 08:14:12 +03:00
dzmat
2d0f0cb372
Allow to disable speed graphs
2018-10-08 23:51:02 +07:00
silverqx
ea404445f6
Clear LineEdit on ESC
2018-10-04 20:01:12 +02:00
Thomas Piccirello
0b6ae68801
Add WebUI search API controller
...
Closes #2495 .
2018-09-30 20:07:27 -04:00
Chocobo1
43fbf8ab3b
Remove default parameter in derived function
...
When derived function have different default value than base, it might cause
unnecessary confusion, see: https://stackoverflow.com/q/3533589
2018-09-27 00:43:24 +08:00
Chocobo1
66ffb01629
Add include guard to headers
2018-09-26 23:49:33 +08:00
Chocobo1
f26a5c3581
Update Python URLs
2018-09-25 11:46:40 +08:00
Chocobo1
7d808cfc99
Fix asking to install Python
...
The dialog asking users to install python is borked since the last refactor, this
commit fixes it.
2018-09-25 11:46:39 +08:00
sledgehammer999
bfb1210c43
Merge pull request #9406 from thalieht/preselecttext
...
Preselect name without extension when renaming files
2018-09-11 14:33:25 +03:00
Vladimir Golovnev
5e35335ad4
Merge pull request #9254 from thalieht/searchStuff
...
Add a shortcut to download selected torrents from search job
2018-09-10 07:19:02 +03:00
Vladimir Golovnev
d18de18128
Merge pull request #9461 from thalieht/tracker
...
Show "N/A" if there is no scrape response
2018-09-10 07:14:28 +03:00
thalieht
94613c2fa2
Fix some warnings
2018-09-07 19:40:08 +03:00
thalieht
e2b46f01bb
Show "N/A" if there is no scrape
...
Disambiguates whether the tracker send a response of 0 peers/seeds/downloaded or didn't send one at all.
2018-09-07 19:39:53 +03:00
sledgehammer999
eb9f07bcc6
Save option about tracker favicons under correct key
2018-09-06 02:45:09 +03:00
thalieht
ffc2193df9
Preselect name without extension when renaming files
...
And preselect the whole string for everything else.
2018-09-05 16:55:42 +03:00
Thomas Piccirello
c10d237f7a
Don't disable DHT when using force proxy
...
Closes #9292
2018-09-02 19:48:03 -04:00
thalieht
ce3e68670d
Refactor in searchjob to always color visited entries
...
Now it colors multiple entries, when visited at once, via the hotkey or
the Download button.
2018-08-31 15:57:07 +03:00
Chocobo1
718b3f0bf5
Reset button text to default
...
This is to avoid Qt auto-generating code like this:
`buttonAdd->setText(QStringLiteral(""));`
Which makes no sense and triggers clazy warning (Wclazy-empty-qstringliteral).
2018-08-28 14:14:01 +08:00
Vladimir Golovnev
9fa78c7b50
Merge pull request #9331 from thalieht/seqfirstlast
...
Allow setting seq & first/last from context menu without metadata
2018-08-22 17:16:44 +03:00
Vladimir Golovnev
93f9b3de8b
Merge pull request #9314 from thalieht/searchregexfilter
...
Add option to use regexps in the search job's search filter's context menu
2018-08-22 17:15:37 +03:00
Chocobo1
d7aa0819d9
Fix values sorted wrong in "Last Activity" column
...
I suspect there could be other negative values.
Closes #9012 .
Also apply the changes to TR_RATIO_LIMIT, avoiding similar problems.
2018-08-16 11:30:26 +08:00
thalieht
7ed0d13de2
Allow setting seq & first/last from context menu without metadata
2018-08-14 13:58:22 +03:00