Browse Source

Properly check if file priority changes

Current item priority is compared against new checkbox state. I believe the intention was to check if the priority changes before performing further actions. This PR fixes the issue - compare priority against new value that is about to be set rather then the checkbox state.

PR #15740.
adaptive-webui-19844
a-sum-duma 3 years ago committed by GitHub
parent
commit
fa1d49add5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 5
      src/gui/torrentcontentmodel.cpp

5
src/gui/torrentcontentmodel.cpp

@ -284,14 +284,15 @@ bool TorrentContentModel::setData(const QModelIndex &index, const QVariant &valu
{ {
auto *item = static_cast<TorrentContentModelItem*>(index.internalPointer()); auto *item = static_cast<TorrentContentModelItem*>(index.internalPointer());
qDebug("setData(%s, %d)", qUtf8Printable(item->name()), value.toInt()); qDebug("setData(%s, %d)", qUtf8Printable(item->name()), value.toInt());
if (static_cast<int>(item->priority()) != value.toInt())
{
BitTorrent::DownloadPriority prio = BitTorrent::DownloadPriority::Normal; BitTorrent::DownloadPriority prio = BitTorrent::DownloadPriority::Normal;
if (value.toInt() == Qt::PartiallyChecked) if (value.toInt() == Qt::PartiallyChecked)
prio = BitTorrent::DownloadPriority::Mixed; prio = BitTorrent::DownloadPriority::Mixed;
else if (value.toInt() == Qt::Unchecked) else if (value.toInt() == Qt::Unchecked)
prio = BitTorrent::DownloadPriority::Ignored; prio = BitTorrent::DownloadPriority::Ignored;
if (item->priority() != prio)
{
item->setPriority(prio); item->setPriority(prio);
// Update folders progress in the tree // Update folders progress in the tree
m_rootItem->recalculateProgress(); m_rootItem->recalculateProgress();

Loading…
Cancel
Save