From f20f479a4beab4dbbff75cef82e0564f3a1bdaec Mon Sep 17 00:00:00 2001 From: Dmitry Vodopyanov Date: Mon, 18 Jul 2022 08:22:30 +0300 Subject: [PATCH] Improve sender field in mail notifications Problem statement: user sees its email address in email notification, while it is better to have sender field app-personalized, like it did in Nextcloud: they send notifications from user's email address and add alias 'Nextcloud' to it. This patch adds alias 'qBittorrent' to qBittorrent email notifications, so user sees more user-friendly email notification. PR #17374. --- src/app/application.cpp | 2 +- src/base/net/smtp.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/application.cpp b/src/app/application.cpp index c1985f9f3..fd0015664 100644 --- a/src/app/application.cpp +++ b/src/app/application.cpp @@ -476,7 +476,7 @@ void Application::sendNotificationEmail(const BitTorrent::Torrent *torrent) auto *smtp = new Net::Smtp(this); smtp->sendMail(pref->getMailNotificationSender(), pref->getMailNotificationEmail(), - tr("[qBittorrent] '%1' has finished downloading").arg(torrent->name()), + tr("Torrent \"%1\" has finished downloading").arg(torrent->name()), content); } diff --git a/src/base/net/smtp.cpp b/src/base/net/smtp.cpp index 4c0149b7b..d34ef9edc 100644 --- a/src/base/net/smtp.cpp +++ b/src/base/net/smtp.cpp @@ -138,7 +138,7 @@ void Smtp::sendMail(const QString &from, const QString &to, const QString &subje { const Preferences *const pref = Preferences::instance(); m_message = "Date: " + getCurrentDateTime().toLatin1() + "\r\n" - + encodeMimeHeader(u"From"_qs, from) + + encodeMimeHeader(u"From"_qs, u"qBittorrent <%1>"_qs.arg(from)) + encodeMimeHeader(u"Subject"_qs, subject) + encodeMimeHeader(u"To"_qs, to) + "MIME-Version: 1.0\r\n"