d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-11 15:27:54 +00:00
Code Issues Projects Releases Wiki Activity

Use boost:circular_buffer instead of QList.

Browse Source 
QList has to store an additional pointer for each element which leads to bad space efficiency.
This commit is contained in:
Chocobo1 2016-05-21 00:55:03 +08:00
parent fc0746eb71
commit f13c604fbe
2 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/base/bittorrent/private/speedmonitor.cpp
View File

@ -27,17 +27,21 @@
* exception statement from your version. * exception statement from your version.
*/ */
#include <QList>
#include "speedmonitor.h" #include "speedmonitor.h"
SpeedMonitor::SpeedMonitor()
: m_speedSamples(MAX_SAMPLES)
{
}
void SpeedMonitor::addSample(const SpeedSample &sample) void SpeedMonitor::addSample(const SpeedSample &sample)
{ {
if (m_speedSamples.size() >= MAX_SAMPLES) {
m_sum -= m_speedSamples.front();
}
m_speedSamples.push_back(sample); m_speedSamples.push_back(sample);
m_sum += sample; m_sum += sample;
if (m_speedSamples.size() > MAX_SAMPLES) {
m_sum -= m_speedSamples.front();
m_speedSamples.pop_front();
}
} }
SpeedSampleAvg SpeedMonitor::average() const SpeedSampleAvg SpeedMonitor::average() const

10
src/base/bittorrent/private/speedmonitor.h
View File

@ -30,7 +30,11 @@
#ifndef SPEEDMONITOR_H #ifndef SPEEDMONITOR_H
#define SPEEDMONITOR_H #define SPEEDMONITOR_H
template<typename T> class QList; #ifndef Q_MOC_RUN
#include <boost/circular_buffer.hpp>
#endif
#include <QtGlobal>
template<typename T> template<typename T>
struct Sample struct Sample
@ -71,13 +75,15 @@ typedef Sample<qreal> SpeedSampleAvg;
class SpeedMonitor class SpeedMonitor
{ {
public: public:
SpeedMonitor();
void addSample(const SpeedSample &sample); void addSample(const SpeedSample &sample);
SpeedSampleAvg average() const; SpeedSampleAvg average() const;
void reset(); void reset();
private: private:
static const int MAX_SAMPLES = 30; static const int MAX_SAMPLES = 30;
QList<SpeedSample> m_speedSamples; boost::circular_buffer<SpeedSample> m_speedSamples;
SpeedSample m_sum; SpeedSample m_sum;
}; };