From e9d3928fe08d330083c2c6a92ad9f1b9b27221b1 Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Wed, 4 May 2022 12:11:17 +0800
Subject: [PATCH] Store WebUI port setting in human readable number

Previously it was wrapped in QVariant type.

PR #16977.
---
 src/base/preferences.cpp        | 5 +++--
 src/webui/api/appcontroller.cpp | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/base/preferences.cpp b/src/base/preferences.cpp
index 1e8e943d3..e59290f74 100644
--- a/src/base/preferences.cpp
+++ b/src/base/preferences.cpp
@@ -592,12 +592,13 @@ void Preferences::setWebUiAddress(const QString &addr)
 
 quint16 Preferences::getWebUiPort() const
 {
-    return value<int>(u"Preferences/WebUI/Port"_qs, 8080);
+    return value<quint16>(u"Preferences/WebUI/Port"_qs, 8080);
 }
 
 void Preferences::setWebUiPort(const quint16 port)
 {
-    setValue(u"Preferences/WebUI/Port"_qs, port);
+    // cast to `int` type so it will show human readable unit in configuration file
+    setValue(u"Preferences/WebUI/Port"_qs, static_cast<int>(port));
 }
 
 bool Preferences::useUPnPForWebUIPort() const
diff --git a/src/webui/api/appcontroller.cpp b/src/webui/api/appcontroller.cpp
index 79b44496a..06c2c9343 100644
--- a/src/webui/api/appcontroller.cpp
+++ b/src/webui/api/appcontroller.cpp
@@ -661,7 +661,7 @@ void AppController::setPreferencesAction()
     if (hasKey(u"web_ui_address"_qs))
         pref->setWebUiAddress(it.value().toString());
     if (hasKey(u"web_ui_port"_qs))
-        pref->setWebUiPort(it.value().toUInt());
+        pref->setWebUiPort(it.value().value<quint16>());
     if (hasKey(u"web_ui_upnp"_qs))
         pref->setUPnPForWebUIPort(it.value().toBool());
     if (hasKey(u"use_https"_qs))