From e96f2d7be091612776afffe209a8741f5eb00638 Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Fri, 8 Oct 2021 20:27:47 +0800 Subject: [PATCH] Simplify comparison From https://doc.qt.io/qt-5/qdatetime.html#operator-eq-eq: >Since 5.14, all invalid datetimes are equal to one another and differ from all other datetimes. --- src/gui/transferlistsortmodel.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gui/transferlistsortmodel.cpp b/src/gui/transferlistsortmodel.cpp index fcf9e31fd..2f442d13a 100644 --- a/src/gui/transferlistsortmodel.cpp +++ b/src/gui/transferlistsortmodel.cpp @@ -51,10 +51,8 @@ namespace const bool isLeftValid = left.isValid(); const bool isRightValid = right.isValid(); - if (isLeftValid && isRightValid) + if (isLeftValid == isRightValid) return threeWayCompare(left, right); - if (!isLeftValid && !isRightValid) - return 0; return isLeftValid ? -1 : 1; }