d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-02-03 18:34:28 +00:00
Code Issues Projects Releases Wiki Activity

Fix potential out-of-bound access of units[i]

Browse Source
This commit is contained in:
Chocobo1 2015-06-17 08:03:51 +08:00
parent 3f8e76ce93
commit e95a017e33
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/utils/misc.cpp
View File

@ -258,8 +258,10 @@ QString Utils::Misc::friendlyUnit(qreal val, bool is_speed)
if (val < 0) if (val < 0)
return QCoreApplication::translate("misc", "Unknown", "Unknown (size)"); return QCoreApplication::translate("misc", "Unknown", "Unknown (size)");
int i = 0; int i = 0;
while(val >= 1024. && i++<6) while(val >= 1024. && i < 4) {
val /= 1024.; val /= 1024.;
++i;
}
QString ret; QString ret;
if (i == 0) if (i == 0)
ret = QString::number((long)val) + " " + QCoreApplication::translate("misc", units[0].source, units[0].comment); ret = QString::number((long)val) + " " + QCoreApplication::translate("misc", units[0].source, units[0].comment);