d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-11 07:18:08 +00:00
Code Issues Projects Releases Wiki Activity

Properly release settings class before further operations

Browse Source 
Fix up d3e7e8a630.

PR #17376.
This commit is contained in:
Chocobo1 2022-07-17 12:41:18 +08:00 committed by GitHub
parent ce0e92e12a
commit e281b667c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/base/settingsstorage.cpp
View File

@ -172,8 +172,12 @@ bool SettingsStorage::writeNativeSettings() const
nativeSettings->setValue(i.key(), i.value()); nativeSettings->setValue(i.key(), i.value());
nativeSettings->sync(); // Important to get error status nativeSettings->sync(); // Important to get error status
const QSettings::Status status = nativeSettings->status();
const Path newPath {nativeSettings->fileName()};
switch (nativeSettings->status()) nativeSettings.reset(); // close QSettings
switch (status)
{ {
case QSettings::NoError: case QSettings::NoError:
break; break;
@ -188,8 +192,7 @@ bool SettingsStorage::writeNativeSettings() const
break; break;
} }
const Path newPath {nativeSettings->fileName()}; if (status != QSettings::NoError)
if (nativeSettings->status() != QSettings::NoError)
{ {
Utils::Fs::removeFile(newPath); Utils::Fs::removeFile(newPath);
return false; return false;