From e0c74c2d39f9995dc17c87edbf1e582a2e934dcd Mon Sep 17 00:00:00 2001
From: Thomas Piccirello <thomas@piccirello.com>
Date: Sun, 26 Nov 2017 16:24:12 -0500
Subject: [PATCH] Remove conditionals

---
 .../www/private/preferences_content.html      | 325 +++++++-----------
 1 file changed, 117 insertions(+), 208 deletions(-)

diff --git a/src/webui/www/private/preferences_content.html b/src/webui/www/private/preferences_content.html
index 0a56c1411..74ba9a91f 100644
--- a/src/webui/www/private/preferences_content.html
+++ b/src/webui/www/private/preferences_content.html
@@ -483,12 +483,9 @@
 var WatchedFoldersTable = new HtmlTable($("watched_folders_tab"));
 
 updateTempDirEnabled = function() {
-  if($('temppath_checkbox').getProperty('checked')) {
-    $('temppath_text').setProperty('disabled', false);
-  } else {
-    $('temppath_text').setProperty('disabled', true);
-  }
-}
+  var isTempDirEnabled = $('temppath_checkbox').getProperty('checked');
+  $('temppath_text').setProperty('disabled', !isTempDirEnabled);
+};
 
 addWatchFolder = function() {
   var new_folder = $('new_watch_folder_txt').getProperty('value').trim();
@@ -508,7 +505,7 @@ addWatchFolder = function() {
   elt.setProperty('value', 'watch_folder');
   var text = elt.options[elt.selectedIndex].innerHTML;
   $('new_watch_folder_other_txt').setProperty('value', text);
-}
+};
 
 changeWatchFolderSelect = function(item) {
   if (item.value == "other") {
@@ -518,11 +515,11 @@ changeWatchFolderSelect = function(item) {
     var text = item.options[item.selectedIndex].innerHTML;
     item.nextElementSibling.value = text;
   }
-}
+};
 
 changeWatchFolderText = function(item) {
   item.previousElementSibling.value = 'other';
-}
+};
 
 pushWatchFolder = function(pos, folder, sel, other) {
   var myinput = "<input id='text_watch_"+ pos +"' type='text' value='" + folder + "'>";
@@ -542,7 +539,7 @@ pushWatchFolder = function(pos, folder, sel, other) {
     other = elt.options[elt.selectedIndex].innerHTML;
   }
   $('cb_watch_txt_'+ pos).setProperty('value', other);
-}
+};
 
 getWatchedFolders = function() {
   var nb_folders = $("watched_folders_tab").getChildren("tbody")[0].getChildren("tr").length;
@@ -561,113 +558,82 @@ getWatchedFolders = function() {
     }
   }
   return folders;
-}
+};
 
 updateExportDirEnabled = function() {
-  if($('exportdir_checkbox').getProperty('checked')) {
-    $('exportdir_text').setProperty('disabled', false);
-  } else {
-    $('exportdir_text').setProperty('disabled', true);
-  }
-}
+  var isExportDirEnabled = $('exportdir_checkbox').getProperty('checked');
+  $('exportdir_text').setProperty('disabled', !isExportDirEnabled);
+};
 
 updateExportDirFinEnabled = function() {
-  if($('exportdirfin_checkbox').getProperty('checked')) {
-    $('exportdirfin_text').setProperty('disabled', false);
-  } else {
-    $('exportdirfin_text').setProperty('disabled', true);
-  }
-}
+  var isExportDirFinEnabled = $('exportdirfin_checkbox').getProperty('checked');
+  $('exportdirfin_text').setProperty('disabled', !isExportDirFinEnabled);
+};
 
 updateMailNotification = function() {
-  if($('mail_notification_checkbox').getProperty('checked')) {
-    $('dest_email_txt').setProperty('disabled', false);
-    $('smtp_server_txt').setProperty('disabled', false);
-    $('mail_auth_checkbox').setProperty('disabled', false);
-    $('mail_ssl_checkbox').setProperty('disabled', false);
-  } else {
-    $('dest_email_txt').setProperty('disabled', true);
-    $('smtp_server_txt').setProperty('disabled', true);
-    $('mail_ssl_checkbox').setProperty('disabled', true);
-    $('mail_auth_checkbox').setProperty('disabled', true);
-    $('mail_auth_checkbox').setProperty('checked', false);
+  var isMailNotificationEnabled = $('mail_notification_checkbox').getProperty('checked');
+  $('dest_email_txt').setProperty('disabled', !isMailNotificationEnabled);
+  $('smtp_server_txt').setProperty('disabled', !isMailNotificationEnabled);
+  $('mail_ssl_checkbox').setProperty('disabled', !isMailNotificationEnabled);
+  $('mail_auth_checkbox').setProperty('disabled', !isMailNotificationEnabled);
+
+  if(!isMailNotificationEnabled) {
+    $('mail_auth_checkbox').setProperty('checked', !isMailNotificationEnabled);
     updateMailAuthSettings();
   }
-}
+};
 
 updateMailAuthSettings = function() {
-  if($('mail_auth_checkbox').getProperty('checked')) {
-    $('mail_username_text').setProperty('disabled', false);
-    $('mail_password_text').setProperty('disabled', false);
-  } else {
-    $('mail_username_text').setProperty('disabled', true);
-    $('mail_password_text').setProperty('disabled', true);
-  }
-}
+  var isMailAuthEnabled = $('mail_auth_checkbox').getProperty('checked');
+  $('mail_username_text').setProperty('disabled', !isMailAuthEnabled);
+  $('mail_password_text').setProperty('disabled', !isMailAuthEnabled);
+};
 
 updateAutoRun = function() {
-  if($('autorun_checkbox').getProperty('checked')) {
-    $('autorunProg_txt').setProperty('disabled', false);
-  } else {
-    $('autorunProg_txt').setProperty('disabled', true);
-  }
-}
+  var isAutoRunEnabled = $('autorun_checkbox').getProperty('checked');
+  $('autorunProg_txt').setProperty('disabled', !isAutoRunEnabled);
+};
 
 // Connection tab
 updateMaxConnecEnabled = function() {
-  if($('max_connec_checkbox').getProperty('checked')) {
-    $('max_connec_value').setProperty('disabled', false);
-  } else {
-    $('max_connec_value').setProperty('disabled', true);
-  }
-}
+  var isMaxConnecEnabled = $('max_connec_checkbox').getProperty('checked');
+  $('max_connec_value').setProperty('disabled', !isMaxConnecEnabled);
+};
 
 updateMaxConnecPerTorrentEnabled = function() {
-  if($('max_connec_per_torrent_checkbox').getProperty('checked')) {
-    $('max_connec_per_torrent_value').setProperty('disabled', false);
-  } else {
-    $('max_connec_per_torrent_value').setProperty('disabled', true);
-  }
-}
+  var isMaxConnecPerTorrentEnabled = $('max_connec_per_torrent_checkbox').getProperty('checked');
+  $('max_connec_per_torrent_value').setProperty('disabled', !isMaxConnecPerTorrentEnabled);
+};
 
 updateMaxUploadsEnabled = function() {
-  if($('max_uploads_checkbox').getProperty('checked')) {
-    $('max_uploads_value').setProperty('disabled', false);
-  } else {
-    $('max_uploads_value').setProperty('disabled', true);
-  }
-}
+  var isMaxUploadsEnabled = $('max_uploads_checkbox').getProperty('checked');
+  $('max_uploads_value').setProperty('disabled', !isMaxUploadsEnabled);
+};
 
 updateMaxUploadsPerTorrentEnabled = function() {
-  if($('max_uploads_per_torrent_checkbox').getProperty('checked')) {
-    $('max_uploads_per_torrent_value').setProperty('disabled', false);
-  } else {
-    $('max_uploads_per_torrent_value').setProperty('disabled', true);
-  }
-}
+  var isMaxUploadsPerTorrentEnabled = $('max_uploads_per_torrent_checkbox').getProperty('checked');
+  $('max_uploads_per_torrent_value').setProperty('disabled', !isMaxUploadsPerTorrentEnabled);
+};
 
 updatePeerProxySettings = function() {
-  if($('peer_proxy_type_select').getProperty('value') != "none") {
-    $('peer_proxy_host_text').setProperty('disabled', false);
-    $('peer_proxy_port_value').setProperty('disabled', false);
-    $('use_peer_proxy_checkbox').setProperty('disabled', false);
-    $('force_proxy_checkbox').setProperty('disabled', false);
-    $('proxy_only_for_torrents_checkbox').setProperty('disabled', false);
-    if($('peer_proxy_type_select').getProperty('value') != "socks5") {
-      $('peer_proxy_auth_checkbox').setProperty('checked', false);
-      $('peer_proxy_auth_checkbox').setProperty('disabled', true);
+  var isPeerProxyTypeSelected = $('peer_proxy_type_select').getProperty('value') != "none";
+  $('peer_proxy_host_text').setProperty('disabled', !isPeerProxyTypeSelected);
+  $('peer_proxy_port_value').setProperty('disabled', !isPeerProxyTypeSelected);
+  $('use_peer_proxy_checkbox').setProperty('disabled', !isPeerProxyTypeSelected);
+  $('force_proxy_checkbox').setProperty('disabled', !isPeerProxyTypeSelected);
+  $('proxy_only_for_torrents_checkbox').setProperty('disabled', !isPeerProxyTypeSelected);
+
+  if(isPeerProxyTypeSelected) {
+    var isPeerProxyTypeSocks5 = $('peer_proxy_type_select').getProperty('value') == "socks5";
+    $('peer_proxy_auth_checkbox').setProperty('disabled', !isPeerProxyTypeSocks5);
+
+    if(!isPeerProxyTypeSocks5) {
+      $('peer_proxy_auth_checkbox').setProperty('checked', isPeerProxyTypeSocks5);
       updatePeerProxyAuthSettings();
-    } else {
-      $('peer_proxy_auth_checkbox').setProperty('disabled', false);
     }
   } else {
-    $('peer_proxy_host_text').setProperty('disabled', true);
-    $('peer_proxy_port_value').setProperty('disabled', true);
-    $('use_peer_proxy_checkbox').setProperty('disabled', true);
-    $('force_proxy_checkbox').setProperty('disabled', true);
-    $('proxy_only_for_torrents_checkbox').setProperty('disabled', true);
-    $('peer_proxy_auth_checkbox').setProperty('disabled', true);
-    $('peer_proxy_auth_checkbox').setProperty('checked', false);
+    $('peer_proxy_auth_checkbox').setProperty('disabled', !isPeerProxyTypeSelected);
+    $('peer_proxy_auth_checkbox').setProperty('checked', isPeerProxyTypeSelected);
     updatePeerProxyAuthSettings();
   }
 
@@ -682,148 +648,91 @@ updateForceProxySettings = function() {
 };
 
 updatePeerProxyAuthSettings = function() {
-  if($('peer_proxy_auth_checkbox').getProperty('checked')) {
-    $('peer_proxy_username_text').setProperty('disabled', false);
-    $('peer_proxy_password_text').setProperty('disabled', false);
-  } else {
-    $('peer_proxy_username_text').setProperty('disabled', true);
-    $('peer_proxy_password_text').setProperty('disabled', true);
-  }
-}
+  var isPeerProxyAuthEnabled = $('peer_proxy_auth_checkbox').getProperty('checked');
+  $('peer_proxy_username_text').setProperty('disabled', !isPeerProxyAuthEnabled);
+  $('peer_proxy_password_text').setProperty('disabled', !isPeerProxyAuthEnabled);
+};
 
 updateFilterSettings = function() {
-  if($('ipfilter_enabled_checkbox').getProperty('checked')) {
-    $('ipfilter_text').setProperty('disabled', false);
-    $('ipfilter_trackers_checkbox').setProperty('disabled', false);
-    $('banned_IPs_textarea').setProperty('disabled', false);
-  } else {
-    $('ipfilter_text').setProperty('disabled', true);
-    $('ipfilter_trackers_checkbox').setProperty('disabled', true);
-    $('banned_IPs_textarea').setProperty('disabled', true);
-  }
-}
+  var isIPFilterEnabled = $('ipfilter_enabled_checkbox').getProperty('checked');
+  $('ipfilter_text').setProperty('disabled', !isIPFilterEnabled);
+  $('ipfilter_trackers_checkbox').setProperty('disabled', !isIPFilterEnabled);
+  $('banned_IPs_textarea').setProperty('disabled', !isIPFilterEnabled);
+};
 
 // Speed tab
 updateUpLimitEnabled = function() {
-  if($('up_limit_checkbox').getProperty('checked')) {
-    $('up_limit_value').setProperty('disabled', false);
-  } else {
-    $('up_limit_value').setProperty('disabled', true);
-  }
-}
+  var isUpLimitEnabled = $('up_limit_checkbox').getProperty('checked');
+  $('up_limit_value').setProperty('disabled', !isUpLimitEnabled);
+};
 
 updateDlLimitEnabled = function() {
-  if($('dl_limit_checkbox').getProperty('checked')) {
-    $('dl_limit_value').setProperty('disabled', false);
-  } else {
-    $('dl_limit_value').setProperty('disabled', true);
-  }
-}
+  var isDlLimitEnabled = $('dl_limit_checkbox').getProperty('checked');
+  $('dl_limit_value').setProperty('disabled', !isDlLimitEnabled);
+};
 
 updateAltUpLimitEnabled = function() {
-  if($('alt_up_limit_checkbox').getProperty('checked')) {
-    $('alt_up_limit_value').setProperty('disabled', false);
-  } else {
-    $('alt_up_limit_value').setProperty('disabled', true);
-  }
-}
+  var isAltUpLimitEnabled = $('alt_up_limit_checkbox').getProperty('checked');
+  $('alt_up_limit_value').setProperty('disabled', !isAltUpLimitEnabled);
+};
 
 updateAltDlLimitEnabled = function() {
-  if($('alt_dl_limit_checkbox').getProperty('checked')) {
-    $('alt_dl_limit_value').setProperty('disabled', false);
-  } else {
-    $('alt_dl_limit_value').setProperty('disabled', true);
-  }
-}
+  var isAltDlLimitEnabled = $('alt_dl_limit_checkbox').getProperty('checked');
+  $('alt_dl_limit_value').setProperty('disabled', !isAltDlLimitEnabled);
+};
 
 updateSchedulingEnabled = function() {
-  if($('limit_sheduling_checkbox').getProperty('checked')) {
-    $('schedule_from_hour').setProperty('disabled', false);
-    $('schedule_from_min').setProperty('disabled', false);
-    $('schedule_to_hour').setProperty('disabled', false);
-    $('schedule_to_min').setProperty('disabled', false);
-    $('schedule_freq_select').setProperty('disabled', false);
-  } else {
-    $('schedule_from_hour').setProperty('disabled', true);
-    $('schedule_from_min').setProperty('disabled', true);
-    $('schedule_to_hour').setProperty('disabled', true);
-    $('schedule_to_min').setProperty('disabled', true);
-    $('schedule_freq_select').setProperty('disabled', true);
-  }
-}
+  var isLimitSchedulingEnabled = $('limit_sheduling_checkbox').getProperty('checked');
+  $('schedule_from_hour').setProperty('disabled', !isLimitSchedulingEnabled);
+  $('schedule_from_min').setProperty('disabled', !isLimitSchedulingEnabled);
+  $('schedule_to_hour').setProperty('disabled', !isLimitSchedulingEnabled);
+  $('schedule_to_min').setProperty('disabled', !isLimitSchedulingEnabled);
+  $('schedule_freq_select').setProperty('disabled', !isLimitSchedulingEnabled);
+};
 
 // Bittorrent tab
 updateQueueingSystem = function() {
-  if($('queueing_checkbox').getProperty('checked')) {
-    $('max_active_dl_value').setProperty('disabled', false);
-    $('max_active_up_value').setProperty('disabled', false);
-    $('max_active_to_value').setProperty('disabled', false);
-    $('dont_count_slow_torrents_checkbox').setProperty('disabled', false);
-  } else {
-    $('max_active_dl_value').setProperty('disabled', true);
-    $('max_active_up_value').setProperty('disabled', true);
-    $('max_active_to_value').setProperty('disabled', true);
-    $('dont_count_slow_torrents_checkbox').setProperty('disabled', true);
-  }
-}
+  var isQueueingEnabled = $('queueing_checkbox').getProperty('checked');
+  $('max_active_dl_value').setProperty('disabled', !isQueueingEnabled);
+  $('max_active_up_value').setProperty('disabled', !isQueueingEnabled);
+  $('max_active_to_value').setProperty('disabled', !isQueueingEnabled);
+  $('dont_count_slow_torrents_checkbox').setProperty('disabled', !isQueueingEnabled);
+};
 
 updateMaxRatioTimeEnabled = function() {
-  if($('max_ratio_checkbox').getProperty('checked')) {
-    $('max_ratio_value').setProperty('disabled', false);
-  } else {
-    $('max_ratio_value').setProperty('disabled', true);
-  }
-  if($('max_seeding_time_checkbox').getProperty('checked')) {
-    $('max_seeding_time_value').setProperty('disabled', false);
-  } else {
-    $('max_seeding_time_value').setProperty('disabled', true);
-  }
-  if($('max_ratio_checkbox').getProperty('checked') || $('max_seeding_time_checkbox').getProperty('checked')) {
-    $('max_ratio_act').setProperty('disabled', false);
-  } else {
-    $('max_ratio_act').setProperty('disabled', true);
-  }
-}
+  var isMaxRatioEnabled = $('max_ratio_checkbox').getProperty('checked');
+  $('max_ratio_value').setProperty('disabled', !isMaxRatioEnabled);
+
+  var isMaxSeedingTimeEnabled = $('max_seeding_time_checkbox').getProperty('checked');
+  $('max_seeding_time_value').setProperty('disabled', !isMaxSeedingTimeEnabled);
+
+  $('max_ratio_act').setProperty('disabled', !(isMaxRatioEnabled || isMaxSeedingTimeEnabled));
+};
 
 updateAddTrackersEnabled = function() {
-  if($('add_trackers_checkbox').getProperty('checked')) {
-    $('add_trackers_textarea').setProperty('disabled', false);
-  } else {
-    $('add_trackers_textarea').setProperty('disabled', true);
-  }
-}
+  var isAddTrackersEnabled = $('add_trackers_checkbox').getProperty('checked');
+  $('add_trackers_textarea').setProperty('disabled', !isAddTrackersEnabled);
+};
 
 // Web UI tab
 updateHttpsSettings = function() {
-  if($('use_https_checkbox').getProperty('checked')) {
-    $('ssl_key_textarea').setProperty('disabled', false);
-    $('ssl_cert_textarea').setProperty('disabled', false);
-  } else {
-    $('ssl_key_textarea').setProperty('disabled', true);
-    $('ssl_cert_textarea').setProperty('disabled', true);
-  }
-}
+  var isAddTrackersEnabled = $('use_https_checkbox').getProperty('checked');
+  $('ssl_key_textarea').setProperty('disabled', !isAddTrackersEnabled);
+  $('ssl_cert_textarea').setProperty('disabled', !isAddTrackersEnabled);
+};
 
 updateBypasssAuthSettings = function() {
-  if ($('bypass_auth_subnet_whitelist_checkbox').getProperty('checked'))
-    $('bypass_auth_subnet_whitelist_textarea').setProperty('disabled', false);
-  else
-    $('bypass_auth_subnet_whitelist_textarea').setProperty('disabled', true);
+  var isBypassAuthSubnetWhitelistEnabled = $('bypass_auth_subnet_whitelist_checkbox').getProperty('checked');
+  $('bypass_auth_subnet_whitelist_textarea').setProperty('disabled', !isBypassAuthSubnetWhitelistEnabled);
 };
 
 updateDynDnsSettings = function() {
-  if($('use_dyndns_checkbox').getProperty('checked')) {
-    $('dyndns_select').setProperty('disabled', false);
-    $('dyndns_domain_text').setProperty('disabled', false);
-    $('dyndns_username_text').setProperty('disabled', false);
-    $('dyndns_password_text').setProperty('disabled', false);
-  } else {
-    $('dyndns_select').setProperty('disabled', true);
-    $('dyndns_domain_text').setProperty('disabled', true);
-    $('dyndns_username_text').setProperty('disabled', true);
-    $('dyndns_password_text').setProperty('disabled', true);
-  }
-}
+  var isDynDnsEnabled = $('use_dyndns_checkbox').getProperty('checked');
+  $('dyndns_select').setProperty('disabled', !isDynDnsEnabled);
+  $('dyndns_domain_text').setProperty('disabled', !isDynDnsEnabled);
+  $('dyndns_username_text').setProperty('disabled', !isDynDnsEnabled);
+  $('dyndns_password_text').setProperty('disabled', !isDynDnsEnabled);
+};
 
 registerDynDns = function() {
   if($('dyndns_select').getProperty('value').toInt() == 1) {
@@ -831,14 +740,14 @@ registerDynDns = function() {
   } else {
     window.open("https://www.dyndns.com/account/services/hosts/add.html", "DynDNS Registration");
   }
-}
+};
 
 time_padding = function(val) {
   ret = val.toString();
   if(ret.length == 1)
-    ret = '0' + ret
+    ret = '0' + ret;
   return ret;
-}
+};
 
 loadPreferences = function() {
   var url = 'api/v2/app/preferences';