d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-02-03 18:34:28 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #8650 from luis-pereira/fix-invalid-iterator-crash

Browse Source 
Fix crashes due to invalid iterator use
This commit is contained in:
sledgehammer999 2018-04-10 16:18:44 +03:00 committed by GitHub
commit d997d887e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/gui/categoryfilterwidget.cpp
View File

@ -35,6 +35,7 @@
#include <QMessageBox> #include <QMessageBox>
#include "base/bittorrent/session.h" #include "base/bittorrent/session.h"
#include "base/global.h"
#include "categoryfiltermodel.h" #include "categoryfiltermodel.h"
#include "categoryfilterproxymodel.h" #include "categoryfilterproxymodel.h"
#include "guiiconprovider.h" #include "guiiconprovider.h"
@ -232,8 +233,7 @@ void CategoryFilterWidget::removeCategory()
void CategoryFilterWidget::removeUnusedCategories() void CategoryFilterWidget::removeUnusedCategories()
{ {
auto session = BitTorrent::Session::instance(); auto session = BitTorrent::Session::instance();
for (auto i = session->categories().cbegin(); i != session->categories().cend(); ++i) { for (const QString &category : copyAsConst(session->categories().keys())) {
const QString &category = i.key();
if (model()->data(static_cast<CategoryFilterProxyModel *>(model())->index(category), Qt::UserRole) == 0) if (model()->data(static_cast<CategoryFilterProxyModel *>(model())->index(category), Qt::UserRole) == 0)
session->removeCategory(category); session->removeCategory(category);
} }