d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-02-10 13:54:23 +00:00
Code Issues Projects Releases Wiki Activity

Fix handling when Content-Length field is absent

Browse Source 
Closes #15754.
PR #15757.
This commit is contained in:
Chocobo1 2021-11-21 11:48:49 +08:00 committed by GitHub
parent ec6c970775
commit d78b2a569f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/base/http/requestparser.cpp
View File

@ -109,9 +109,18 @@ RequestParser::ParseResult RequestParser::doParse(const QByteArray &data)
return {ParseStatus::OK, m_request, headerLength}; return {ParseStatus::OK, m_request, headerLength};
if (m_request.method == HEADER_REQUEST_METHOD_POST) if (m_request.method == HEADER_REQUEST_METHOD_POST)
{ {
bool ok = false; const auto parseContentLength = [this]() -> int
const int contentLength = m_request.headers[HEADER_CONTENT_LENGTH].toInt(&ok); {
if (!ok || (contentLength < 0)) // [rfc7230] 3.3.2. Content-Length
const QString rawValue = m_request.headers.value(HEADER_CONTENT_LENGTH);
if (rawValue.isNull()) // `HEADER_CONTENT_LENGTH` does not exist
return 0;
return Utils::String::parseInt(rawValue).value_or(-1);
};
const int contentLength = parseContentLength();
if (contentLength < 0)
{ {
qWarning() << Q_FUNC_INFO << "bad request: content-length invalid"; qWarning() << Q_FUNC_INFO << "bad request: content-length invalid";
return {ParseStatus::BadRequest, Request(), 0}; return {ParseStatus::BadRequest, Request(), 0};