d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-02-02 09:55:55 +00:00
Code Issues Projects Releases Wiki Activity

Use QVarLengthArray whenever applicable

Browse Source
This commit is contained in:
Chocobo1 2022-02-09 17:24:54 +08:00
parent dd1bd8ad10
commit cf96e6c642
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
1 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/base/bittorrent/ltqbitarray.cpp
View File

@ -28,11 +28,10 @@
#include "ltqbitarray.h"
#include <memory>
#include <libtorrent/bitfield.hpp>
#include <QBitArray>
#include <QVarLengthArray>
namespace
{
@ -52,21 +51,10 @@ namespace BitTorrent::LT
const char *bitsData = bits.data();
const int dataLength = (bits.size() + 7) / 8;
if (dataLength <= STACK_ALLOC_SIZE)
{
// fast path for small bitfields
char tmp[STACK_ALLOC_SIZE]; // uninitialized for faster allocation
for (int i = 0; i < dataLength; ++i)
tmp[i] = reverseByte(bitsData[i]);
return QBitArray::fromBits(tmp, bits.size());
}
// slow path for big bitfields
auto tmp = std::make_unique<char []>(dataLength);
QVarLengthArray<char, STACK_ALLOC_SIZE> tmp(dataLength);
for (int i = 0; i < dataLength; ++i)
tmp[i] = reverseByte(bitsData[i]);
return QBitArray::fromBits(tmp.get(), bits.size());
return QBitArray::fromBits(tmp.data(), tmp.size());
}
}