From 855f727451289c146b0b53b84c43b161e6f73a6e Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Tue, 4 Oct 2022 16:50:03 +0800 Subject: [PATCH 1/2] Set proper focus on widget And also allow keyboard tabbing to the Browse button. Fix up 6ab35512da36796f50dd53ca26524cb0ca1ab1f1. --- src/gui/fspathedit.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/gui/fspathedit.cpp b/src/gui/fspathedit.cpp index de46bfe05..94ac6741d 100644 --- a/src/gui/fspathedit.cpp +++ b/src/gui/fspathedit.cpp @@ -178,6 +178,10 @@ FileSystemPathEdit::FileSystemPathEdit(Private::IFileEditorWithCompletion *edito Q_D(FileSystemPathEdit); editor->widget()->setParent(this); + setFocusProxy(editor->widget()); + // required, otherwise the button cannot be selected via keyboard tab + setTabOrder(editor->widget(), d_ptr->m_browseBtn); + auto *layout = new QHBoxLayout(this); layout->setContentsMargins(0, 0, 0, 0); layout->addWidget(editor->widget()); From d9af207a11c7f657fcc9fffd885eb100ac5536bb Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Tue, 4 Oct 2022 15:48:15 +0800 Subject: [PATCH 2/2] GHA CI: add missing cmake flag for Qt6 --- .github/workflows/coverity-scan.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/coverity-scan.yml b/.github/workflows/coverity-scan.yml index b7effcf5c..a83d9494e 100644 --- a/.github/workflows/coverity-scan.yml +++ b/.github/workflows/coverity-scan.yml @@ -60,6 +60,7 @@ jobs: -G "Ninja" \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DGUI=ON \ + -DQT6=ON \ -DVERBOSE_CONFIGURE=ON export PATH="$(pwd)/coverity_tool/bin:$PATH" cov-build --dir cov-int cmake --build build