diff --git a/.travis.yml b/.travis.yml index 03eeb1f08..48285b2c7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -67,7 +67,7 @@ addons: - libssl-dev - [libboost-dev, libboost-system-dev] - libtorrent-rasterbar-dev - - [qt55base, qt55tools] + - [qt55base, qt55svg, qt55tools] - [gcc-6, g++-6] before_install: diff --git a/cmake/Modules/DeployQt5.cmake b/cmake/Modules/DeployQt5.cmake new file mode 100644 index 000000000..f92e7db2f --- /dev/null +++ b/cmake/Modules/DeployQt5.cmake @@ -0,0 +1,355 @@ +# Borrowed from Avogadro project (https://github.com/OpenChemistry/avogadroapp) + +#.rst: +# DeployQt5 +# --------- +# +# Functions to help assemble a standalone Qt5 executable. +# +# A collection of CMake utility functions useful for deploying Qt5 +# executables. +# +# The following functions are provided by this module: +# +# :: +# +# write_qt5_conf +# resolve_qt5_paths +# fixup_qt5_executable +# install_qt5_plugin_path +# install_qt5_plugin +# install_qt5_executable +# +# Requires CMake 2.8.9 or greater because Qt 5 does. +# Also depends on BundleUtilities.cmake. +# +# :: +# +# WRITE_QT5_CONF( ) +# +# Writes a qt.conf file with the into . +# +# :: +# +# RESOLVE_QT5_PATHS( []) +# +# Loop through list and if any don't exist resolve them +# relative to the (if supplied) or the +# CMAKE_INSTALL_PREFIX. +# +# :: +# +# FIXUP_QT5_EXECUTABLE( [ ]) +# +# Copies Qt plugins, writes a Qt configuration file (if needed) and +# fixes up a Qt5 executable using BundleUtilities so it is standalone +# and can be drag-and-drop copied to another machine as long as all of +# the system libraries are compatible. +# +# should point to the executable to be fixed-up. +# +# should contain a list of the names or paths of any Qt +# plugins to be installed. +# +# will be passed to BundleUtilities and should be a list of any +# already installed plugins, libraries or executables to also be +# fixed-up. +# +# will be passed to BundleUtilities and should contain and +# directories to be searched to find library dependencies. +# +# allows an custom plugins directory to be used. +# +# will force a qt.conf file to be written even if not +# needed. +# +# :: +# +# INSTALL_QT5_PLUGIN_PATH(plugin executable copy installed_plugin_path_var ) +# +# Install (or copy) a resolved to the default plugins directory +# (or ) relative to and store the result in +# . +# +# If is set to TRUE then the plugins will be copied rather than +# installed. This is to allow this module to be used at CMake time +# rather than install time. +# +# If is set then anything installed will use this COMPONENT. +# +# :: +# +# INSTALL_QT5_PLUGIN(plugin executable copy installed_plugin_path_var ) +# +# Install (or copy) an unresolved to the default plugins +# directory (or ) relative to and store the +# result in . See documentation of +# INSTALL_QT5_PLUGIN_PATH. +# +# :: +# +# INSTALL_QT5_EXECUTABLE( [ ]) +# +# Installs Qt plugins, writes a Qt configuration file (if needed) and +# fixes up a Qt5 executable using BundleUtilities so it is standalone +# and can be drag-and-drop copied to another machine as long as all of +# the system libraries are compatible. The executable will be fixed-up +# at install time. is the COMPONENT used for bundle fixup +# and plugin installation. See documentation of FIXUP_QT5_BUNDLE. + +#============================================================================= +# Copyright 2011 Mike McQuaid +# +# Distributed under the OSI-approved BSD License (the "License"); +# see accompanying file Copyright.txt for details. +# +# This software is distributed WITHOUT ANY WARRANTY; without even the +# implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. +# See the License for more information. +#============================================================================= +# (To distribute this file outside of CMake, substitute the full +# License text for the above reference.) + +# The functions defined in this file depend on the fixup_bundle function +# (and others) found in BundleUtilities.cmake + +include(BundleUtilities) +set(DeployQt5_cmake_dir "${CMAKE_CURRENT_LIST_DIR}") +set(DeployQt5_apple_plugins_dir "PlugIns") + +function(write_qt5_conf qt_conf_dir qt_conf_contents) + set(qt_conf_path "${qt_conf_dir}/qt.conf") + message(STATUS "Writing ${qt_conf_path}") + file(WRITE "${qt_conf_path}" "${qt_conf_contents}") +endfunction() + +function(resolve_qt5_paths paths_var) + set(executable_path ${ARGV1}) + + set(paths_resolved) + foreach(path ${${paths_var}}) + if(EXISTS "${path}") + list(APPEND paths_resolved "${path}") + else() + if(${executable_path}) + list(APPEND paths_resolved "${executable_path}/${path}") + else() + list(APPEND paths_resolved "\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${path}") + endif() + endif() + endforeach() + set(${paths_var} ${paths_resolved} PARENT_SCOPE) +endfunction() + +function(fixup_qt5_executable executable) + set(qtplugins ${ARGV1}) + set(libs ${ARGV2}) + set(dirs ${ARGV3}) + set(plugins_dir ${ARGV4}) + set(request_qt_conf ${ARGV5}) + + message(STATUS "fixup_qt5_executable") + message(STATUS " executable='${executable}'") + message(STATUS " qtplugins='${qtplugins}'") + message(STATUS " libs='${libs}'") + message(STATUS " dirs='${dirs}'") + message(STATUS " plugins_dir='${plugins_dir}'") + message(STATUS " request_qt_conf='${request_qt_conf}'") + + if(QT_LIBRARY_DIR) + list(APPEND dirs "${QT_LIBRARY_DIR}") + endif() + if(QT_BINARY_DIR) + list(APPEND dirs "${QT_BINARY_DIR}") + endif() + + if(APPLE) + set(qt_conf_dir "${executable}/Contents/Resources") + set(executable_path "${executable}") + set(write_qt_conf TRUE) + if(NOT plugins_dir) + set(plugins_dir "${DeployQt5_apple_plugins_dir}") + endif() + else() + get_filename_component(executable_path "${executable}" PATH) + if(NOT executable_path) + set(executable_path ".") + endif() + set(qt_conf_dir "${executable_path}") + set(write_qt_conf ${request_qt_conf}) + endif() + + foreach(plugin ${qtplugins}) + set(installed_plugin_path "") + install_qt5_plugin("${plugin}" "${executable}" 1 installed_plugin_path) + list(APPEND libs ${installed_plugin_path}) + endforeach() + + foreach(lib ${libs}) + if(NOT EXISTS "${lib}") + message(FATAL_ERROR "Library does not exist: ${lib}") + endif() + endforeach() + + resolve_qt5_paths(libs "${executable_path}") + + if(write_qt_conf) + set(qt_conf_contents "[Paths]\nPlugins = ${plugins_dir}") + write_qt5_conf("${qt_conf_dir}" "${qt_conf_contents}") + endif() + + fixup_bundle("${executable}" "${libs}" "${dirs}") +endfunction() + +function(install_qt5_plugin_path plugin executable copy installed_plugin_path_var) + set(plugins_dir ${ARGV4}) + set(component ${ARGV5}) + set(configurations ${ARGV6}) + if(EXISTS "${plugin}") + if(APPLE) + if(NOT plugins_dir) + set(plugins_dir "${DeployQt5_apple_plugins_dir}") + endif() + set(plugins_path "${executable}/Contents/${plugins_dir}") + else() + get_filename_component(plugins_path "${executable}" PATH) + if(NOT plugins_path) + set(plugins_path ".") + endif() + if(plugins_dir) + set(plugins_path "${plugins_path}/${plugins_dir}") + endif() + endif() + + set(plugin_group "") + + get_filename_component(plugin_path "${plugin}" PATH) + get_filename_component(plugin_parent_path "${plugin_path}" PATH) + get_filename_component(plugin_parent_dir_name "${plugin_parent_path}" NAME) + get_filename_component(plugin_name "${plugin}" NAME) + string(TOLOWER "${plugin_parent_dir_name}" plugin_parent_dir_name) + + if("${plugin_parent_dir_name}" STREQUAL "plugins") + get_filename_component(plugin_group "${plugin_path}" NAME) + set(${plugin_group_var} "${plugin_group}") + endif() + set(plugins_path "${plugins_path}/${plugin_group}") + + if(${copy}) + file(MAKE_DIRECTORY "${plugins_path}") + file(COPY "${plugin}" DESTINATION "${plugins_path}") + else() + if(configurations AND (CMAKE_CONFIGURATION_TYPES OR CMAKE_BUILD_TYPE)) + set(configurations CONFIGURATIONS ${configurations}) + else() + unset(configurations) + endif() + install(FILES "${plugin}" DESTINATION "${plugins_path}" ${configurations} ${component}) + endif() + set(${installed_plugin_path_var} "${plugins_path}/${plugin_name}" PARENT_SCOPE) + endif() +endfunction() + +function(install_qt5_plugin plugin executable copy installed_plugin_path_var) + set(plugins_dir ${ARGV4}) + set(component ${ARGV5}) + if(EXISTS "${plugin}") + install_qt5_plugin_path("${plugin}" "${executable}" "${copy}" "${installed_plugin_path_var}" "${plugins_dir}" "${component}") + else() + string(TOUPPER "QT_${plugin}_PLUGIN" plugin_var) + set(plugin_release_var "${plugin_var}_RELEASE") + set(plugin_debug_var "${plugin_var}_DEBUG") + set(plugin_release "${${plugin_release_var}}") + set(plugin_debug "${${plugin_debug_var}}") + if(DEFINED "${plugin_release_var}" AND DEFINED "${plugin_debug_var}" AND NOT EXISTS "${plugin_release}" AND NOT EXISTS "${plugin_debug}") + message(WARNING "Qt plugin \"${plugin}\" not recognized or found.") + endif() + if(NOT EXISTS "${${plugin_debug_var}}") + set(plugin_debug "${plugin_release}") + endif() + + if(CMAKE_CONFIGURATION_TYPES OR CMAKE_BUILD_TYPE) + install_qt5_plugin_path("${plugin_release}" "${executable}" "${copy}" "${installed_plugin_path_var}_release" "${plugins_dir}" "${component}" "Release|RelWithDebInfo|MinSizeRel") + install_qt5_plugin_path("${plugin_debug}" "${executable}" "${copy}" "${installed_plugin_path_var}_debug" "${plugins_dir}" "${component}" "Debug") + + if(CMAKE_BUILD_TYPE MATCHES "^Debug$") + set(${installed_plugin_path_var} ${${installed_plugin_path_var}_debug}) + else() + set(${installed_plugin_path_var} ${${installed_plugin_path_var}_release}) + endif() + else() + install_qt5_plugin_path("${plugin_release}" "${executable}" "${copy}" "${installed_plugin_path_var}" "${plugins_dir}" "${component}") + endif() + endif() + set(${installed_plugin_path_var} ${${installed_plugin_path_var}} PARENT_SCOPE) +endfunction() + +function(install_qt5_executable executable) + set(qtplugins ${ARGV1}) + set(libs ${ARGV2}) + set(dirs ${ARGV3}) + set(plugins_dir ${ARGV4}) + set(request_qt_conf ${ARGV5}) + set(component ${ARGV6}) + if(QT_LIBRARY_DIR) + list(APPEND dirs "${QT_LIBRARY_DIR}") + endif() + if(QT_BINARY_DIR) + list(APPEND dirs "${QT_BINARY_DIR}") + endif() + if(TARGET Qt5::Core) + get_property(_locCore TARGET Qt5::Core PROPERTY LOCATION_RELEASE) + get_filename_component(_loc ${_locCore} DIRECTORY) + message(STATUS "Adding Qt 5 directory: ${_loc}") + list(APPEND dirs "${_loc}") + else() + message(FATAL_ERROR "No Qt5::Core target found, ensure it is available") + endif() + if(component) + set(component COMPONENT ${component}) + else() + unset(component) + endif() + + get_filename_component(executable_absolute "${executable}" ABSOLUTE) + if(EXISTS "${QT_QTCORE_LIBRARY_RELEASE}") + gp_file_type("${executable_absolute}" "${QT_QTCORE_LIBRARY_RELEASE}" qtcore_type) + elseif(EXISTS "${QT_QTCORE_LIBRARY_DEBUG}") + gp_file_type("${executable_absolute}" "${QT_QTCORE_LIBRARY_DEBUG}" qtcore_type) + endif() + if(qtcore_type STREQUAL "system") + set(qt_plugins_dir "") + endif() + + if(QT_IS_STATIC) + message(WARNING "Qt built statically: not installing plugins.") + else() + if(APPLE) + get_property(loc TARGET Qt5::QCocoaIntegrationPlugin + PROPERTY LOCATION_RELEASE) + install_qt5_plugin("${loc}" "${executable}" 0 installed_plugin_paths + "PlugIns" "${component}") + list(APPEND libs ${installed_plugin_paths}) + elseif(WIN32) + get_property(loc TARGET Qt5::QWindowsIntegrationPlugin + PROPERTY LOCATION_RELEASE) + install_qt5_plugin("${loc}" "${executable}" 0 installed_plugin_paths + "" "${component}") + list(APPEND libs ${installed_plugin_paths}) + endif() + foreach(plugin ${qtplugins}) + set(installed_plugin_paths "") + install_qt5_plugin("${plugin}" "${executable}" 0 installed_plugin_paths "${plugins_dir}" "${component}") + list(APPEND libs ${installed_plugin_paths}) + endforeach() + endif() + + resolve_qt5_paths(libs "") + + install(CODE + "include(\"${DeployQt5_cmake_dir}/DeployQt5.cmake\") + set(BU_CHMOD_BUNDLE_ITEMS TRUE) + fixup_qt5_executable(\"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${executable}\" \"\" \"${libs}\" \"${dirs}\" \"${plugins_dir}\" \"${request_qt_conf}\")" + ${component} + ) +endfunction() diff --git a/cmake/Modules/QbtTargetSources.cmake b/cmake/Modules/QbtTargetSources.cmake index ced0e4b58..c49fef312 100644 --- a/cmake/Modules/QbtTargetSources.cmake +++ b/cmake/Modules/QbtTargetSources.cmake @@ -1,6 +1,5 @@ # a helper function which appends source to the main qBt target -# the target name is read from QBT_TARGET_NAME variable -# sources file names are relative to the the ${qbt_executable_SOURCE_DIR} +# sources file names are relative to the the ${qBittorrent_SOURCE_DIR} function (qbt_target_sources) set (_sources_rel "") @@ -13,5 +12,5 @@ function (qbt_target_sources) file (RELATIVE_PATH _source_rel "${qbt_executable_SOURCE_DIR}" "${_source_abs}") list (APPEND _sources_rel "${_source_rel}") endforeach() - target_sources (${QBT_TARGET_NAME} PRIVATE "${_sources_rel}") + target_sources (qBittorrent PRIVATE "${_sources_rel}") endfunction (qbt_target_sources) diff --git a/cmake/Modules/bundle.cmake b/cmake/Modules/bundle.cmake new file mode 100644 index 000000000..608dc395d --- /dev/null +++ b/cmake/Modules/bundle.cmake @@ -0,0 +1,21 @@ +set(BU_CHMOD_BUNDLE_ITEMS ON) +include(DeployQt5) + +set(plugins "") + +get_property(svgIconPluginLocation TARGET Qt5::QSvgIconPlugin + PROPERTY LOCATION_RELEASE) +list(APPEND plugins "${svgIconPluginLocation}") +get_property(svgPluginLocation TARGET Qt5::QSvgPlugin + PROPERTY LOCATION_RELEASE) +list(APPEND plugins "${svgPluginLocation}") + +set(sfx "") +if(APPLE) + set(sfx ".app") +elseif(WIN32) + set(sfx "${CMAKE_EXECUTABLE_SUFFIX}") +endif() + +get_target_property(exe qBittorrent OUTPUT_NAME) +install_qt5_executable("${exe}${sfx}" "${plugins}" "" "" "") diff --git a/dist/mac/bundle.cmake b/dist/mac/bundle.cmake deleted file mode 100644 index 4f72b53b6..000000000 --- a/dist/mac/bundle.cmake +++ /dev/null @@ -1,3 +0,0 @@ -set(BU_CHMOD_BUNDLE_ITEMS ON) -include(BundleUtilities) -fixup_bundle("$ENV{DESTDIR}/${CMAKE_INSTALL_PREFIX}/qbittorrent.app" "" "") diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index b8e9cd6d7..090e2cc99 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -13,7 +13,7 @@ find_package(LibtorrentRasterbar REQUIRED) # Qt list(APPEND QBT_QT_COMPONENTS Core Network Xml) if (GUI) - list (APPEND QBT_QT_COMPONENTS Concurrent Gui Widgets) + list (APPEND QBT_QT_COMPONENTS Concurrent Gui Svg Widgets) if (WIN32) list (APPEND QBT_QT_COMPONENTS WinExtras) endif(WIN32) @@ -75,13 +75,6 @@ set(QBT_USE_WEBUI ${WEBUI}) configure_file(config.h.cmakein ${CMAKE_CURRENT_BINARY_DIR}/config.h) -if (GUI) - set(QBT_TARGET_NAME qbittorrent) -else (GUI) - set(QBT_TARGET_NAME qbittorrent-nox) -endif (GUI) - - if (SYSTEM_QTSINGLEAPPLICATION) find_package(QtSingleApplication REQUIRED) else (SYSTEM_QTSINGLEAPPLICATION) diff --git a/src/app/CMakeLists.txt b/src/app/CMakeLists.txt index eee683769..bb5ea43e3 100644 --- a/src/app/CMakeLists.txt +++ b/src/app/CMakeLists.txt @@ -142,39 +142,50 @@ if (APPLE) PROPERTIES MACOSX_PACKAGE_LOCATION translations) endif (APPLE) -add_executable(${QBT_TARGET_NAME} ${QBT_APP_HEADERS} ${QBT_APP_SOURCES} ${QBT_QM_FILES} ${QBT_APP_RESOURCE_SOURCE}) -set_target_properties(${QBT_TARGET_NAME} +add_executable(qBittorrent ${QBT_APP_HEADERS} ${QBT_APP_SOURCES} ${QBT_QM_FILES} ${QBT_APP_RESOURCE_SOURCE}) +if (GUI) + set_target_properties(qBittorrent + PROPERTIES + OUTPUT_NAME qbittorrent + WIN32_EXECUTABLE True + ) +else (GUI) + set_target_properties(qBittorrent + PROPERTIES + OUTPUT_NAME qbittorrent-nox + ) +endif (GUI) + +set_target_properties(qBittorrent PROPERTIES AUTOUIC True AUTORCC True MACOSX_BUNDLE True ) -if (GUI AND WIN32) - set_target_properties(${QBT_TARGET_NAME} PROPERTIES WIN32_EXECUTABLE True) -endif (GUI AND WIN32) +get_target_property(QBT_EXECUTABLE_NAME qBittorrent OUTPUT_NAME) -target_link_libraries(${QBT_TARGET_NAME} ${QBT_TARGET_LIBRARIES} QtSingleApplication::QtSingleApplication) +target_link_libraries(qBittorrent ${QBT_TARGET_LIBRARIES} QtSingleApplication::QtSingleApplication) if (APPLE) - set(qbt_BUNDLE_NAME "${QBT_TARGET_NAME}") + set(qbt_BUNDLE_NAME ${QBT_EXECUTABLE_NAME}) # substitute @EXECUTABLE@ in dist/mac/Info.plist set(EXECUTABLE ${qbt_BUNDLE_NAME}) configure_file(${qBittorrent_SOURCE_DIR}/dist/mac/Info.plist ${qBittorrent_BINARY_DIR}/dist/mac/Info.plist @ONLY) - set_target_properties(${QBT_TARGET_NAME} PROPERTIES + set_target_properties(qBittorrent PROPERTIES MACOSX_BUNDLE_BUNDLE_NAME "${qbt_BUNDLE_NAME}" MACOSX_BUNDLE_INFO_PLIST ${qBittorrent_BINARY_DIR}/dist/mac/Info.plist ) endif (APPLE) # installation -install(TARGETS ${QBT_TARGET_NAME} +install(TARGETS qBittorrent RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} BUNDLE DESTINATION . COMPONENT runtime) -if (APPLE AND GUI) - install(SCRIPT ${OSX_RES_SRC_DIR}/bundle.cmake) -endif (APPLE AND GUI) +if (GUI AND APPLE) + include(bundle) +endif (GUI AND APPLE) diff --git a/src/src.pro b/src/src.pro index 71914081a..b27bde7e5 100644 --- a/src/src.pro +++ b/src/src.pro @@ -23,7 +23,7 @@ nogui { DEFINES += DISABLE_GUI TARGET = qbittorrent-nox } else { - QT += xml concurrent widgets + QT += xml concurrent svg widgets CONFIG(static) { DEFINES += QBT_STATIC_QT QTPLUGIN += qico