d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-11 15:27:54 +00:00
Code Issues Projects Releases Wiki Activity

Avoid log file excessive flushing

Browse Source 
Excessive flushing could happen when a lot of logging happens in a short
time interval.
This commit is contained in:
Chocobo1 2020-03-26 15:57:56 +08:00
parent 12396a7582
commit c52737e07c
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/app/filelogger.cpp
View File

@ -28,6 +28,8 @@
#include "filelogger.h" #include "filelogger.h"
#include <chrono>
#include <QDateTime> #include <QDateTime>
#include <QDir> #include <QDir>
#include <QTextStream> #include <QTextStream>
@ -36,11 +38,16 @@
#include "base/logger.h" #include "base/logger.h"
#include "base/utils/fs.h" #include "base/utils/fs.h"
namespace
{
const std::chrono::seconds FLUSH_INTERVAL {2};
}
FileLogger::FileLogger(const QString &path, const bool backup, const int maxSize, const bool deleteOld, const int age, const FileLogAgeType ageType) FileLogger::FileLogger(const QString &path, const bool backup, const int maxSize, const bool deleteOld, const int age, const FileLogAgeType ageType)
: m_backup(backup) : m_backup(backup)
, m_maxSize(maxSize) , m_maxSize(maxSize)
{ {
m_flusher.setInterval(0); m_flusher.setInterval(FLUSH_INTERVAL);
m_flusher.setSingleShot(true); m_flusher.setSingleShot(true);
connect(&m_flusher, &QTimer::timeout, this, &FileLogger::flushLog); connect(&m_flusher, &QTimer::timeout, this, &FileLogger::flushLog);
@ -131,7 +138,7 @@ void FileLogger::addLogMessage(const Log::Msg &msg)
stream << "(N) "; stream << "(N) ";
} }
stream << QDateTime::fromMSecsSinceEpoch(msg.timestamp).toString(Qt::ISODate) << " - " << msg.message << endl; stream << QDateTime::fromMSecsSinceEpoch(msg.timestamp).toString(Qt::ISODate) << " - " << msg.message << '\n';
if (m_backup && (m_logFile.size() >= m_maxSize)) { if (m_backup && (m_logFile.size() >= m_maxSize)) {
closeLogFile(); closeLogFile();
@ -147,7 +154,8 @@ void FileLogger::addLogMessage(const Log::Msg &msg)
openLogFile(); openLogFile();
} }
else { else {
m_flusher.start(); if (!m_flusher.isActive())
m_flusher.start();
} }
} }