Consider explicitly specified parameters when resolving optional ones

PR #18955.
Closes #18951.

src/base/bittorrent/sessionimpl.cpp

@@ -2611,22 +2611,8 @@ LoadTorrentParams SessionImpl::initLoadTorrentParams(const AddTorrentParams &add
     const auto defaultSavePath = suggestedSavePath(loadTorrentParams.category, addTorrentParams.useAutoTMM);
     const auto defaultDownloadPath = suggestedDownloadPath(loadTorrentParams.category, addTorrentParams.useAutoTMM);
 
-    loadTorrentParams.useAutoTMM = addTorrentParams.useAutoTMM.value_or(!isAutoTMMDisabledByDefault());
+    loadTorrentParams.useAutoTMM = addTorrentParams.useAutoTMM.value_or(
-
+            addTorrentParams.savePath.isEmpty() && addTorrentParams.downloadPath.isEmpty() && !isAutoTMMDisabledByDefault());
-    if (!addTorrentParams.useAutoTMM.has_value())
-    {
-        // Default TMM settings
-
-        if (!loadTorrentParams.useAutoTMM)
-        {
-            loadTorrentParams.savePath = defaultSavePath;
-            if (isDownloadPathEnabled())
-                loadTorrentParams.downloadPath = (!defaultDownloadPath.isEmpty() ? defaultDownloadPath : downloadPath());
-        }
-    }
-    else
-    {
-        // Overridden TMM settings
 
     if (!loadTorrentParams.useAutoTMM)
     {
@@ -2635,14 +2621,9 @@ LoadTorrentParams SessionImpl::initLoadTorrentParams(const AddTorrentParams &add
         else
             loadTorrentParams.savePath = defaultSavePath / addTorrentParams.savePath;
 
-            if (!addTorrentParams.useDownloadPath.has_value())
+        // if useDownloadPath isn't specified but downloadPath is explicitly set we prefer to use it
-            {
+        const bool useDownloadPath = addTorrentParams.useDownloadPath.value_or(!addTorrentParams.downloadPath.isEmpty() || isDownloadPathEnabled());
-                // Default "Download path" settings
+        if (useDownloadPath)
-
-                if (isDownloadPathEnabled())
-                    loadTorrentParams.downloadPath = (!defaultDownloadPath.isEmpty() ? defaultDownloadPath : downloadPath());
-            }
-            else if (addTorrentParams.useDownloadPath.value())
         {
             // Overridden "Download path" settings
 
@@ -2657,7 +2638,6 @@ LoadTorrentParams SessionImpl::initLoadTorrentParams(const AddTorrentParams &add
             }
         }
     }
-    }
 
     for (const QString &tag : addTorrentParams.tags)
     {

src/gui/addnewtorrentdialog.cpp

@@ -860,6 +860,16 @@ void AddNewTorrentDialog::accept()
             m_torrentParams.downloadPath = downloadPath;
             updatePathHistory(KEY_DOWNLOADPATHHISTORY, downloadPath, savePathHistoryLength());
         }
+        else
+        {
+            m_torrentParams.downloadPath = Path();
+        }
+    }
+    else
+    {
+        m_torrentParams.savePath = Path();
+        m_torrentParams.downloadPath = Path();
+        m_torrentParams.useDownloadPath = std::nullopt;
     }
 
     setEnabled(!m_ui->checkBoxNeverShow->isChecked());

src/gui/addtorrentparamswidget.cpp

@@ -48,12 +48,28 @@ namespace
         Q_ASSERT(data.userType() == QMetaType::Bool);
         return data.toBool();
     }
+
+    BitTorrent::AddTorrentParams cleanParams(BitTorrent::AddTorrentParams params)
+    {
+        if (!params.useAutoTMM.has_value() || params.useAutoTMM.value())
+        {
+            params.savePath = Path();
+            params.downloadPath = Path();
+            params.useDownloadPath = std::nullopt;
+        }
+
+        if (!params.useDownloadPath.has_value() || !params.useDownloadPath.value())
+        {
+            params.downloadPath = Path();
+        }
+
+        return params;
+    }
 }
 
 AddTorrentParamsWidget::AddTorrentParamsWidget(BitTorrent::AddTorrentParams addTorrentParams, QWidget *parent)
     : QWidget(parent)
     , m_ui {new Ui::AddTorrentParamsWidget}
-    , m_addTorrentParams {std::move(addTorrentParams)}
 {
     m_ui->setupUi(this);
 
@@ -110,7 +126,7 @@ AddTorrentParamsWidget::AddTorrentParamsWidget(BitTorrent::AddTorrentParams addT
     miscParamsLayout->addWidget(m_ui->stopConditionWidget);
     miscParamsLayout->addWidget(m_ui->addToQueueTopWidget);
 
-    populate();
+    setAddTorrentParams(std::move(addTorrentParams));
 }
 
 AddTorrentParamsWidget::~AddTorrentParamsWidget()
@@ -126,7 +142,7 @@ void AddTorrentParamsWidget::setAddTorrentParams(BitTorrent::AddTorrentParams ad
 
 BitTorrent::AddTorrentParams AddTorrentParamsWidget::addTorrentParams() const
 {
-    return m_addTorrentParams;
+    return cleanParams(m_addTorrentParams);
 }
 
 void AddTorrentParamsWidget::populate()