From ae1634623e7eb026101f5d383b95ccf3410c8d0d Mon Sep 17 00:00:00 2001 From: thalieht Date: Thu, 26 Oct 2017 10:10:30 +0300 Subject: [PATCH] Coding style for many files --- src/gui/properties/downloadedpiecesbar.cpp | 26 +- src/gui/properties/downloadedpiecesbar.h | 10 +- src/gui/properties/peerlistdelegate.h | 1 - src/gui/properties/peerlistwidget.cpp | 12 +- src/gui/properties/peersadditiondlg.cpp | 8 +- src/gui/properties/peersadditiondlg.h | 7 +- src/gui/properties/pieceavailabilitybar.cpp | 14 +- src/gui/properties/pieceavailabilitybar.h | 8 +- src/gui/properties/piecesbar.h | 2 +- src/gui/properties/propertieswidget.cpp | 615 ++++++++++---------- src/gui/properties/propertieswidget.h | 80 ++- src/gui/properties/propertieswidget.ui | 108 ++-- src/gui/properties/proplistdelegate.cpp | 94 ++- src/gui/properties/proplistdelegate.h | 13 +- src/gui/properties/proptabbar.cpp | 169 +++--- src/gui/properties/proptabbar.h | 36 +- src/gui/properties/speedplotview.cpp | 28 +- src/gui/properties/speedplotview.h | 10 +- src/gui/properties/speedwidget.cpp | 2 +- src/gui/properties/speedwidget.h | 4 +- src/gui/properties/trackerlist.cpp | 12 +- src/gui/properties/trackersadditiondlg.cpp | 34 +- src/gui/properties/trackersadditiondlg.h | 6 +- 23 files changed, 637 insertions(+), 662 deletions(-) diff --git a/src/gui/properties/downloadedpiecesbar.cpp b/src/gui/properties/downloadedpiecesbar.cpp index 4ecdb82f9..44625010c 100644 --- a/src/gui/properties/downloadedpiecesbar.cpp +++ b/src/gui/properties/downloadedpiecesbar.cpp @@ -1,6 +1,6 @@ /* - * Bittorrent Client using Qt4 and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Bittorrent Client using Qt and libtorrent. + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #include "downloadedpiecesbar.h" @@ -127,24 +125,24 @@ bool DownloadedPiecesBar::updateImage(QImage &image) return true; } - QVector scaled_pieces = bitfieldToFloatVector(m_pieces, image2.width()); - QVector scaled_pieces_dl = bitfieldToFloatVector(m_downloadedPieces, image2.width()); + QVector scaledPieces = bitfieldToFloatVector(m_pieces, image2.width()); + QVector scaledPiecesDl = bitfieldToFloatVector(m_downloadedPieces, image2.width()); // filling image - for (int x = 0; x < scaled_pieces.size(); ++x) { - float pieces2_val = scaled_pieces.at(x); - float pieces2_val_dl = scaled_pieces_dl.at(x); - if (pieces2_val_dl != 0) { - float fill_ratio = pieces2_val + pieces2_val_dl; - float ratio = pieces2_val_dl / fill_ratio; + for (int x = 0; x < scaledPieces.size(); ++x) { + float piecesToValue = scaledPieces.at(x); + float piecesToValueDl = scaledPiecesDl.at(x); + if (piecesToValueDl != 0) { + float fillRatio = piecesToValue + piecesToValueDl; + float ratio = piecesToValueDl / fillRatio; QRgb mixedColor = mixTwoColors(pieceColor().rgb(), m_dlPieceColor.rgb(), ratio); - mixedColor = mixTwoColors(backgroundColor().rgb(), mixedColor, fill_ratio); + mixedColor = mixTwoColors(backgroundColor().rgb(), mixedColor, fillRatio); image2.setPixel(x, 0, mixedColor); } else { - image2.setPixel(x, 0, pieceColors()[pieces2_val * 255]); + image2.setPixel(x, 0, pieceColors()[piecesToValue * 255]); } } image = image2; diff --git a/src/gui/properties/downloadedpiecesbar.h b/src/gui/properties/downloadedpiecesbar.h index 137c0723d..ee96d45b5 100644 --- a/src/gui/properties/downloadedpiecesbar.h +++ b/src/gui/properties/downloadedpiecesbar.h @@ -1,6 +1,6 @@ /* - * Bittorrent Client using Qt4 and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Bittorrent Client using Qt and libtorrent. + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,20 +24,18 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #ifndef DOWNLOADEDPIECESBAR_H #define DOWNLOADEDPIECESBAR_H -#include #include #include +#include #include "piecesbar.h" -class DownloadedPiecesBar: public PiecesBar +class DownloadedPiecesBar : public PiecesBar { using base = PiecesBar; Q_OBJECT diff --git a/src/gui/properties/peerlistdelegate.h b/src/gui/properties/peerlistdelegate.h index f1b7d4fb8..29db78c9a 100644 --- a/src/gui/properties/peerlistdelegate.h +++ b/src/gui/properties/peerlistdelegate.h @@ -61,7 +61,6 @@ public: COL_COUNT }; -public: PeerListDelegate(QObject *parent) : QItemDelegate(parent) {} ~PeerListDelegate() {} diff --git a/src/gui/properties/peerlistwidget.cpp b/src/gui/properties/peerlistwidget.cpp index 2a1ffcf96..5dd27a7de 100644 --- a/src/gui/properties/peerlistwidget.cpp +++ b/src/gui/properties/peerlistwidget.cpp @@ -231,8 +231,8 @@ void PeerListWidget::showPeerListMenu(const QPoint &) addPeerAct = menu.addAction(GuiIconProvider::instance()->getIcon("user-group-new"), tr("Add a new peer...")); emptyMenu = false; } - QAction *banAct = 0; - QAction *copyPeerAct = 0; + QAction *banAct = nullptr; + QAction *copyPeerAct = nullptr; if (!selectionModel()->selectedRows().isEmpty()) { copyPeerAct = menu.addAction(GuiIconProvider::instance()->getIcon("edit-copy"), tr("Copy IP:port")); menu.addSeparator(); @@ -241,7 +241,8 @@ void PeerListWidget::showPeerListMenu(const QPoint &) } if (emptyMenu) return; QAction *act = menu.exec(QCursor::pos()); - if (act == 0) return; + if (!act) return; + if (act == addPeerAct) { QList peersList = PeersAdditionDlg::askForPeers(this); int peerCount = 0; @@ -249,7 +250,7 @@ void PeerListWidget::showPeerListMenu(const QPoint &) if (torrent->connectPeer(addr)) { qDebug("Adding peer %s...", qUtf8Printable(addr.ip.toString())); Logger::instance()->addMessage(tr("Manually adding peer '%1'...").arg(addr.ip.toString())); - peerCount++; + ++peerCount; } else { Logger::instance()->addMessage(tr("The peer '%1' could not be added to this torrent.").arg(addr.ip.toString()), Log::WARNING); @@ -277,8 +278,7 @@ void PeerListWidget::banSelectedPeers() int ret = QMessageBox::question(this, tr("Ban peer permanently"), tr("Are you sure you want to ban permanently the selected peers?"), tr("&Yes"), tr("&No"), QString(), 0, 1); - if (ret) - return; + if (ret) return; QModelIndexList selectedIndexes = selectionModel()->selectedRows(); foreach (const QModelIndex &index, selectedIndexes) { diff --git a/src/gui/properties/peersadditiondlg.cpp b/src/gui/properties/peersadditiondlg.cpp index ab20674aa..3c869809e 100644 --- a/src/gui/properties/peersadditiondlg.cpp +++ b/src/gui/properties/peersadditiondlg.cpp @@ -1,6 +1,6 @@ /* - * Bittorrent Client using Qt4 and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Bittorrent Client using Qt and libtorrent. + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,14 +24,12 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #include "peersadditiondlg.h" -#include #include +#include #include "ui_peersadditiondlg.h" diff --git a/src/gui/properties/peersadditiondlg.h b/src/gui/properties/peersadditiondlg.h index 8f09c907c..af76d132b 100644 --- a/src/gui/properties/peersadditiondlg.h +++ b/src/gui/properties/peersadditiondlg.h @@ -1,6 +1,6 @@ /* * Bittorrent Client using Qt and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #ifndef PEERADDITION_H @@ -42,7 +40,7 @@ namespace Ui class addPeersDialog; } -class PeersAdditionDlg: public QDialog +class PeersAdditionDlg : public QDialog { Q_OBJECT @@ -60,7 +58,6 @@ private: Ui::addPeersDialog *m_ui; QList m_peersList; - }; #endif // PEERADDITION_H diff --git a/src/gui/properties/pieceavailabilitybar.cpp b/src/gui/properties/pieceavailabilitybar.cpp index 0ce3f2618..38a4a6666 100644 --- a/src/gui/properties/pieceavailabilitybar.cpp +++ b/src/gui/properties/pieceavailabilitybar.cpp @@ -1,6 +1,6 @@ /* - * Bittorrent Client using Qt4 and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Bittorrent Client using Qt and libtorrent. + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #include "pieceavailabilitybar.h" @@ -134,12 +132,12 @@ bool PieceAvailabilityBar::updateImage(QImage &image) return true; } - QVector scaled_pieces = intToFloatVector(m_pieces, image2.width()); + QVector scaledPieces = intToFloatVector(m_pieces, image2.width()); // filling image - for (int x = 0; x < scaled_pieces.size(); ++x) { - float pieces2_val = scaled_pieces.at(x); - image2.setPixel(x, 0, pieceColors()[pieces2_val * 255]); + for (int x = 0; x < scaledPieces.size(); ++x) { + float piecesToValue = scaledPieces.at(x); + image2.setPixel(x, 0, pieceColors()[piecesToValue * 255]); } image = image2; return true; diff --git a/src/gui/properties/pieceavailabilitybar.h b/src/gui/properties/pieceavailabilitybar.h index 98d98a31a..2a1eddbf2 100644 --- a/src/gui/properties/pieceavailabilitybar.h +++ b/src/gui/properties/pieceavailabilitybar.h @@ -1,6 +1,6 @@ /* - * Bittorrent Client using Qt4 and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Bittorrent Client using Qt and libtorrent. + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #ifndef PIECEAVAILABILITYBAR_H @@ -33,7 +31,7 @@ #include "piecesbar.h" -class PieceAvailabilityBar: public PiecesBar +class PieceAvailabilityBar : public PiecesBar { using base = PiecesBar; Q_OBJECT diff --git a/src/gui/properties/piecesbar.h b/src/gui/properties/piecesbar.h index 92f81a80e..ac0575a16 100644 --- a/src/gui/properties/piecesbar.h +++ b/src/gui/properties/piecesbar.h @@ -41,7 +41,7 @@ namespace BitTorrent class TorrentHandle; } -class PiecesBar: public QWidget +class PiecesBar : public QWidget { using base = QWidget; Q_OBJECT diff --git a/src/gui/properties/propertieswidget.cpp b/src/gui/properties/propertieswidget.cpp index 16ed3be33..29b9813bb 100644 --- a/src/gui/properties/propertieswidget.cpp +++ b/src/gui/properties/propertieswidget.cpp @@ -1,6 +1,6 @@ /* - * Bittorrent Client using Qt4 and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Bittorrent Client using Qt and libtorrent. + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #include "propertieswidget.h" @@ -67,23 +65,23 @@ #include "ui_propertieswidget.h" -PropertiesWidget::PropertiesWidget(QWidget *parent, MainWindow *main_window, TransferListWidget *transferList) +PropertiesWidget::PropertiesWidget(QWidget *parent, MainWindow *mainWindow, TransferListWidget *transferList) : QWidget(parent) , m_ui(new Ui::PropertiesWidget()) - , transferList(transferList) - , main_window(main_window) + , m_transferList(transferList) + , m_mainWindow(mainWindow) , m_torrent(nullptr) { m_ui->setupUi(this); setAutoFillBackground(true); - state = VISIBLE; + m_state = VISIBLE; // Set Properties list model - PropListModel = new TorrentContentFilterModel(); - m_ui->filesList->setModel(PropListModel); - PropDelegate = new PropListDelegate(this); - m_ui->filesList->setItemDelegate(PropDelegate); + m_propListModel = new TorrentContentFilterModel(); + m_ui->filesList->setModel(m_propListModel); + m_propListDelegate = new PropListDelegate(this); + m_ui->filesList->setItemDelegate(m_propListDelegate); m_ui->filesList->setSortingEnabled(true); // Torrent content filtering m_contentFilterLine = new LineEdit(this); @@ -94,17 +92,17 @@ PropertiesWidget::PropertiesWidget(QWidget *parent, MainWindow *main_window, Tra // SIGNAL/SLOTS connect(m_ui->filesList, SIGNAL(clicked(const QModelIndex&)), m_ui->filesList, SLOT(edit(const QModelIndex&))); - connect(m_ui->selectAllButton, SIGNAL(clicked()), PropListModel, SLOT(selectAll())); - connect(m_ui->selectNoneButton, SIGNAL(clicked()), PropListModel, SLOT(selectNone())); + connect(m_ui->selectAllButton, SIGNAL(clicked()), m_propListModel, SLOT(selectAll())); + connect(m_ui->selectNoneButton, SIGNAL(clicked()), m_propListModel, SLOT(selectNone())); connect(m_ui->filesList, SIGNAL(customContextMenuRequested(const QPoint&)), this, SLOT(displayFilesListMenu(const QPoint&))); connect(m_ui->filesList, SIGNAL(doubleClicked(const QModelIndex&)), this, SLOT(openDoubleClickedFile(const QModelIndex&))); - connect(PropListModel, SIGNAL(filteredFilesChanged()), this, SLOT(filteredFilesChanged())); + connect(m_propListModel, SIGNAL(filteredFilesChanged()), this, SLOT(filteredFilesChanged())); connect(m_ui->listWebSeeds, SIGNAL(customContextMenuRequested(const QPoint&)), this, SLOT(displayWebSeedListMenu(const QPoint&))); - connect(transferList, SIGNAL(currentTorrentChanged(BitTorrent::TorrentHandle * const)), this, SLOT(loadTorrentInfos(BitTorrent::TorrentHandle * const))); - connect(PropDelegate, SIGNAL(filteredFilesChanged()), this, SLOT(filteredFilesChanged())); + connect(transferList, SIGNAL(currentTorrentChanged(BitTorrent::TorrentHandle *const)), this, SLOT(loadTorrentInfos(BitTorrent::TorrentHandle *const))); + connect(m_propListDelegate, SIGNAL(filteredFilesChanged()), this, SLOT(filteredFilesChanged())); connect(m_ui->stackedProperties, SIGNAL(currentChanged(int)), this, SLOT(loadDynamicData())); - connect(BitTorrent::Session::instance(), SIGNAL(torrentSavePathChanged(BitTorrent::TorrentHandle * const)), this, SLOT(updateSavePath(BitTorrent::TorrentHandle * const))); - connect(BitTorrent::Session::instance(), SIGNAL(torrentMetadataLoaded(BitTorrent::TorrentHandle * const)), this, SLOT(updateTorrentInfos(BitTorrent::TorrentHandle * const))); + connect(BitTorrent::Session::instance(), SIGNAL(torrentSavePathChanged(BitTorrent::TorrentHandle *const)), this, SLOT(updateSavePath(BitTorrent::TorrentHandle *const))); + connect(BitTorrent::Session::instance(), SIGNAL(torrentMetadataLoaded(BitTorrent::TorrentHandle *const)), this, SLOT(updateTorrentInfos(BitTorrent::TorrentHandle *const))); connect(m_ui->filesList->header(), SIGNAL(sectionMoved(int,int,int)), this, SLOT(saveSettings())); connect(m_ui->filesList->header(), SIGNAL(sectionResized(int,int,int)), this, SLOT(saveSettings())); connect(m_ui->filesList->header(), SIGNAL(sortIndicatorChanged(int,Qt::SortOrder)), this, SLOT(saveSettings())); @@ -114,39 +112,39 @@ PropertiesWidget::PropertiesWidget(QWidget *parent, MainWindow *main_window, Tra // Downloaded pieces progress bar m_ui->tempProgressBarArea->setVisible(false); - downloaded_pieces = new DownloadedPiecesBar(this); - m_ui->groupBarLayout->addWidget(downloaded_pieces, 0, 1); - downloaded_pieces->setFixedHeight(barHeight); - downloaded_pieces->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed); + m_downloadedPieces = new DownloadedPiecesBar(this); + m_ui->groupBarLayout->addWidget(m_downloadedPieces, 0, 1); + m_downloadedPieces->setFixedHeight(barHeight); + m_downloadedPieces->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed); // Pieces availability bar m_ui->tempAvailabilityBarArea->setVisible(false); - pieces_availability = new PieceAvailabilityBar(this); - m_ui->groupBarLayout->addWidget(pieces_availability, 1, 1); - pieces_availability->setFixedHeight(barHeight); - pieces_availability->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed); + m_piecesAvailability = new PieceAvailabilityBar(this); + m_ui->groupBarLayout->addWidget(m_piecesAvailability, 1, 1); + m_piecesAvailability->setFixedHeight(barHeight); + m_piecesAvailability->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed); // Tracker list - trackerList = new TrackerList(this); + m_trackerList = new TrackerList(this); m_ui->trackerUpButton->setIcon(GuiIconProvider::instance()->getIcon("go-up")); m_ui->trackerUpButton->setIconSize(Utils::Misc::smallIconSize()); m_ui->trackerDownButton->setIcon(GuiIconProvider::instance()->getIcon("go-down")); m_ui->trackerDownButton->setIconSize(Utils::Misc::smallIconSize()); - connect(m_ui->trackerUpButton, SIGNAL(clicked()), trackerList, SLOT(moveSelectionUp())); - connect(m_ui->trackerDownButton, SIGNAL(clicked()), trackerList, SLOT(moveSelectionDown())); - m_ui->horizontalLayout_trackers->insertWidget(0, trackerList); - connect(trackerList->header(), SIGNAL(sectionMoved(int,int,int)), trackerList, SLOT(saveSettings())); - connect(trackerList->header(), SIGNAL(sectionResized(int,int,int)), trackerList, SLOT(saveSettings())); - connect(trackerList->header(), SIGNAL(sortIndicatorChanged(int,Qt::SortOrder)), trackerList, SLOT(saveSettings())); + connect(m_ui->trackerUpButton, SIGNAL(clicked()), m_trackerList, SLOT(moveSelectionUp())); + connect(m_ui->trackerDownButton, SIGNAL(clicked()), m_trackerList, SLOT(moveSelectionDown())); + m_ui->horizontalLayout_trackers->insertWidget(0, m_trackerList); + connect(m_trackerList->header(), SIGNAL(sectionMoved(int,int,int)), m_trackerList, SLOT(saveSettings())); + connect(m_trackerList->header(), SIGNAL(sectionResized(int,int,int)), m_trackerList, SLOT(saveSettings())); + connect(m_trackerList->header(), SIGNAL(sortIndicatorChanged(int,Qt::SortOrder)), m_trackerList, SLOT(saveSettings())); // Peers list - peersList = new PeerListWidget(this); - m_ui->peerpage_layout->addWidget(peersList); - connect(peersList->header(), SIGNAL(sectionMoved(int,int,int)), peersList, SLOT(saveSettings())); - connect(peersList->header(), SIGNAL(sectionResized(int,int,int)), peersList, SLOT(saveSettings())); - connect(peersList->header(), SIGNAL(sortIndicatorChanged(int,Qt::SortOrder)), peersList, SLOT(saveSettings())); + m_peerList = new PeerListWidget(this); + m_ui->peerpage_layout->addWidget(m_peerList); + connect(m_peerList->header(), SIGNAL(sectionMoved(int,int,int)), m_peerList, SLOT(saveSettings())); + connect(m_peerList->header(), SIGNAL(sectionResized(int,int,int)), m_peerList, SLOT(saveSettings())); + connect(m_peerList->header(), SIGNAL(sortIndicatorChanged(int,Qt::SortOrder)), m_peerList, SLOT(saveSettings())); // Speed widget - speedWidget = new SpeedWidget(this); - m_ui->speed_layout->addWidget(speedWidget); + m_speedWidget = new SpeedWidget(this); + m_ui->speedLayout->addWidget(m_speedWidget); // Tab bar m_tabBar = new PropTabBar(); m_tabBar->setContentsMargins(0, 5, 0, 0); @@ -156,79 +154,79 @@ PropertiesWidget::PropertiesWidget(QWidget *parent, MainWindow *main_window, Tra connect(m_tabBar, SIGNAL(visibilityToggled(bool)), SLOT(setVisibility(bool))); connect(m_tabBar, SIGNAL(visibilityToggled(bool)), this, SLOT(saveSettings())); // Dynamic data refresher - refreshTimer = new QTimer(this); - connect(refreshTimer, SIGNAL(timeout()), this, SLOT(loadDynamicData())); - refreshTimer->start(3000); // 3sec - editHotkeyFile = new QShortcut(Qt::Key_F2, m_ui->filesList, 0, 0, Qt::WidgetShortcut); - connect(editHotkeyFile, SIGNAL(activated()), SLOT(renameSelectedFile())); - editHotkeyWeb = new QShortcut(Qt::Key_F2, m_ui->listWebSeeds, 0, 0, Qt::WidgetShortcut); - connect(editHotkeyWeb, SIGNAL(activated()), SLOT(editWebSeed())); + m_refreshTimer = new QTimer(this); + connect(m_refreshTimer, SIGNAL(timeout()), this, SLOT(loadDynamicData())); + m_refreshTimer->start(3000); // 3sec + m_editHotkeyFile = new QShortcut(Qt::Key_F2, m_ui->filesList, 0, 0, Qt::WidgetShortcut); + connect(m_editHotkeyFile, SIGNAL(activated()), SLOT(renameSelectedFile())); + m_editHotkeyWeb = new QShortcut(Qt::Key_F2, m_ui->listWebSeeds, 0, 0, Qt::WidgetShortcut); + connect(m_editHotkeyWeb, SIGNAL(activated()), SLOT(editWebSeed())); connect(m_ui->listWebSeeds, SIGNAL(doubleClicked(QModelIndex)), SLOT(editWebSeed())); - deleteHotkeyWeb = new QShortcut(QKeySequence::Delete, m_ui->listWebSeeds, 0, 0, Qt::WidgetShortcut); - connect(deleteHotkeyWeb, SIGNAL(activated()), SLOT(deleteSelectedUrlSeeds())); - openHotkeyFile = new QShortcut(Qt::Key_Return, m_ui->filesList, 0, 0, Qt::WidgetShortcut); - connect(openHotkeyFile, SIGNAL(activated()), SLOT(openSelectedFile())); + m_deleteHotkeyWeb = new QShortcut(QKeySequence::Delete, m_ui->listWebSeeds, 0, 0, Qt::WidgetShortcut); + connect(m_deleteHotkeyWeb, SIGNAL(activated()), SLOT(deleteSelectedUrlSeeds())); + m_openHotkeyFile = new QShortcut(Qt::Key_Return, m_ui->filesList, 0, 0, Qt::WidgetShortcut); + connect(m_openHotkeyFile, SIGNAL(activated()), SLOT(openSelectedFile())); } PropertiesWidget::~PropertiesWidget() { qDebug() << Q_FUNC_INFO << "ENTER"; - delete refreshTimer; - delete trackerList; - delete peersList; - delete speedWidget; - delete downloaded_pieces; - delete pieces_availability; - delete PropListModel; - delete PropDelegate; + delete m_refreshTimer; + delete m_trackerList; + delete m_peerList; + delete m_speedWidget; + delete m_downloadedPieces; + delete m_piecesAvailability; + delete m_propListModel; + delete m_propListDelegate; delete m_tabBar; - delete editHotkeyFile; - delete editHotkeyWeb; - delete deleteHotkeyWeb; - delete openHotkeyFile; + delete m_editHotkeyFile; + delete m_editHotkeyWeb; + delete m_deleteHotkeyWeb; + delete m_openHotkeyFile; delete m_ui; qDebug() << Q_FUNC_INFO << "EXIT"; } void PropertiesWidget::showPiecesAvailability(bool show) { - m_ui->avail_pieces_lbl->setVisible(show); - pieces_availability->setVisible(show); - m_ui->avail_average_lbl->setVisible(show); - if (show || !downloaded_pieces->isVisible()) - m_ui->line_2->setVisible(show); + m_ui->labelPiecesAvailability->setVisible(show); + m_piecesAvailability->setVisible(show); + m_ui->labelAverageAvailabilityVal->setVisible(show); + if (show || !m_downloadedPieces->isVisible()) + m_ui->lineBelowBars->setVisible(show); } void PropertiesWidget::showPiecesDownloaded(bool show) { - m_ui->downloaded_pieces_lbl->setVisible(show); - downloaded_pieces->setVisible(show); - m_ui->progress_lbl->setVisible(show); - if (show || !pieces_availability->isVisible()) - m_ui->line_2->setVisible(show); + m_ui->labelDownloadedPieces->setVisible(show); + m_downloadedPieces->setVisible(show); + m_ui->labelProgressVal->setVisible(show); + if (show || !m_piecesAvailability->isVisible()) + m_ui->lineBelowBars->setVisible(show); } void PropertiesWidget::setVisibility(bool visible) { - if (!visible && (state == VISIBLE)) { + if (!visible && (m_state == VISIBLE)) { QSplitter *hSplitter = static_cast(parentWidget()); m_ui->stackedProperties->setVisible(false); - slideSizes = hSplitter->sizes(); + m_slideSizes = hSplitter->sizes(); hSplitter->handle(1)->setVisible(false); hSplitter->handle(1)->setDisabled(true); QList sizes = QList() << hSplitter->geometry().height() - 30 << 30; hSplitter->setSizes(sizes); - state = REDUCED; + m_state = REDUCED; return; } - if (visible && (state == REDUCED)) { + if (visible && (m_state == REDUCED)) { m_ui->stackedProperties->setVisible(true); QSplitter *hSplitter = static_cast(parentWidget()); hSplitter->handle(1)->setDisabled(false); hSplitter->handle(1)->setVisible(true); - hSplitter->setSizes(slideSizes); - state = VISIBLE; + hSplitter->setSizes(m_slideSizes); + m_state = VISIBLE; // Force refresh loadDynamicData(); } @@ -237,39 +235,39 @@ void PropertiesWidget::setVisibility(bool visible) void PropertiesWidget::clear() { qDebug("Clearing torrent properties"); - m_ui->save_path->clear(); - m_ui->lbl_creationDate->clear(); - m_ui->label_total_pieces_val->clear(); - m_ui->hash_lbl->clear(); - m_ui->comment_text->clear(); - m_ui->progress_lbl->clear(); - trackerList->clear(); - downloaded_pieces->clear(); - pieces_availability->clear(); - m_ui->avail_average_lbl->clear(); - m_ui->wasted->clear(); - m_ui->upTotal->clear(); - m_ui->dlTotal->clear(); - peersList->clear(); - m_ui->lbl_uplimit->clear(); - m_ui->lbl_dllimit->clear(); - m_ui->lbl_elapsed->clear(); - m_ui->lbl_connections->clear(); - m_ui->reannounce_lbl->clear(); - m_ui->shareRatio->clear(); + m_ui->labelSavePathVal->clear(); + m_ui->labelCreatedOnVal->clear(); + m_ui->labelTotalPiecesVal->clear(); + m_ui->labelHashVal->clear(); + m_ui->labelCommentVal->clear(); + m_ui->labelProgressVal->clear(); + m_ui->labelAverageAvailabilityVal->clear(); + m_ui->labelWastedVal->clear(); + m_ui->labelUpTotalVal->clear(); + m_ui->labelDlTotalVal->clear(); + m_ui->labelUpLimitVal->clear(); + m_ui->labelDlLimitVal->clear(); + m_ui->labelElapsedVal->clear(); + m_ui->labelConnectionsVal->clear(); + m_ui->labelReannounceInVal->clear(); + m_ui->labelShareRatioVal->clear(); m_ui->listWebSeeds->clear(); + m_ui->labelETAVal->clear(); + m_ui->labelSeedsVal->clear(); + m_ui->labelPeersVal->clear(); + m_ui->labelDlSpeedVal->clear(); + m_ui->labelUpSpeedVal->clear(); + m_ui->labelTotalSizeVal->clear(); + m_ui->labelCompletedOnVal->clear(); + m_ui->labelLastSeenCompleteVal->clear(); + m_ui->labelCreatedByVal->clear(); + m_ui->labelAddedOnVal->clear(); + m_trackerList->clear(); + m_downloadedPieces->clear(); + m_piecesAvailability->clear(); + m_peerList->clear(); m_contentFilterLine->clear(); - PropListModel->model()->clear(); - m_ui->label_eta_val->clear(); - m_ui->label_seeds_val->clear(); - m_ui->label_peers_val->clear(); - m_ui->label_dl_speed_val->clear(); - m_ui->label_upload_speed_val->clear(); - m_ui->label_total_size_val->clear(); - m_ui->label_completed_on_val->clear(); - m_ui->label_last_complete_val->clear(); - m_ui->label_created_by_val->clear(); - m_ui->label_added_on_val->clear(); + m_propListModel->model()->clear(); } BitTorrent::TorrentHandle *PropertiesWidget::getCurrentTorrent() const @@ -277,26 +275,41 @@ BitTorrent::TorrentHandle *PropertiesWidget::getCurrentTorrent() const return m_torrent; } +TrackerList *PropertiesWidget::getTrackerList() const +{ + return m_trackerList; +} + +PeerListWidget *PropertiesWidget::getPeerList() const +{ + return m_peerList; +} + QTreeView *PropertiesWidget::getFilesList() const { return m_ui->filesList; } +SpeedWidget *PropertiesWidget::getSpeedWidget() const +{ + return m_speedWidget; +} + void PropertiesWidget::updateSavePath(BitTorrent::TorrentHandle *const torrent) { - if (m_torrent == torrent) - m_ui->save_path->setText(Utils::Fs::toNativePath(m_torrent->savePath())); + if (torrent == m_torrent) + m_ui->labelSavePathVal->setText(Utils::Fs::toNativePath(m_torrent->savePath())); } void PropertiesWidget::loadTrackers(BitTorrent::TorrentHandle *const torrent) { if (torrent == m_torrent) - trackerList->loadTrackers(); + m_trackerList->loadTrackers(); } void PropertiesWidget::updateTorrentInfos(BitTorrent::TorrentHandle *const torrent) { - if (m_torrent == torrent) + if (torrent == m_torrent) loadTorrentInfos(m_torrent); } @@ -304,36 +317,36 @@ void PropertiesWidget::loadTorrentInfos(BitTorrent::TorrentHandle *const torrent { clear(); m_torrent = torrent; - downloaded_pieces->setTorrent(m_torrent); - pieces_availability->setTorrent(m_torrent); + m_downloadedPieces->setTorrent(m_torrent); + m_piecesAvailability->setTorrent(m_torrent); if (!m_torrent) return; // Save path updateSavePath(m_torrent); // Hash - m_ui->hash_lbl->setText(m_torrent->hash()); - PropListModel->model()->clear(); + m_ui->labelHashVal->setText(m_torrent->hash()); + m_propListModel->model()->clear(); if (m_torrent->hasMetadata()) { // Creation date - m_ui->lbl_creationDate->setText(m_torrent->creationDate().toString(Qt::DefaultLocaleShortDate)); + m_ui->labelCreatedOnVal->setText(m_torrent->creationDate().toString(Qt::DefaultLocaleShortDate)); - m_ui->label_total_size_val->setText(Utils::Misc::friendlyUnit(m_torrent->totalSize())); + m_ui->labelTotalSizeVal->setText(Utils::Misc::friendlyUnit(m_torrent->totalSize())); // Comment - m_ui->comment_text->setText(Utils::Misc::parseHtmlLinks(m_torrent->comment().toHtmlEscaped())); + m_ui->labelCommentVal->setText(Utils::Misc::parseHtmlLinks(m_torrent->comment().toHtmlEscaped())); // URL seeds loadUrlSeeds(); - m_ui->label_created_by_val->setText(m_torrent->creator().toHtmlEscaped()); + m_ui->labelCreatedByVal->setText(m_torrent->creator().toHtmlEscaped()); // List files in torrent - PropListModel->model()->setupModelData(m_torrent->info()); - if (PropListModel->model()->rowCount() == 1) - m_ui->filesList->setExpanded(PropListModel->index(0, 0), true); + m_propListModel->model()->setupModelData(m_torrent->info()); + if (m_propListModel->model()->rowCount() == 1) + m_ui->filesList->setExpanded(m_propListModel->index(0, 0), true); // Load file priorities - PropListModel->model()->updateFilesPriorities(m_torrent->filePriorities()); + m_propListModel->model()->updateFilesPriorities(m_torrent->filePriorities()); } // Load dynamic data loadDynamicData(); @@ -343,12 +356,12 @@ void PropertiesWidget::readSettings() { const Preferences *const pref = Preferences::instance(); // Restore splitter sizes - QStringList sizes_str = pref->getPropSplitterSizes().split(","); - if (sizes_str.size() == 2) { - slideSizes << sizes_str.first().toInt(); - slideSizes << sizes_str.last().toInt(); + QStringList sizesStr = pref->getPropSplitterSizes().split(","); + if (sizesStr.size() == 2) { + m_slideSizes << sizesStr.first().toInt(); + m_slideSizes << sizesStr.last().toInt(); QSplitter *hSplitter = static_cast(parentWidget()); - hSplitter->setSizes(slideSizes); + hSplitter->setSizes(m_slideSizes); } const int current_tab = pref->getPropCurTab(); const bool visible = pref->getPropVisible(); @@ -363,14 +376,14 @@ void PropertiesWidget::readSettings() void PropertiesWidget::saveSettings() { Preferences *const pref = Preferences::instance(); - pref->setPropVisible(state == VISIBLE); + pref->setPropVisible(m_state == VISIBLE); // Splitter sizes QSplitter *hSplitter = static_cast(parentWidget()); QList sizes; - if (state == VISIBLE) + if (m_state == VISIBLE) sizes = hSplitter->sizes(); else - sizes = slideSizes; + sizes = m_slideSizes; qDebug("Sizes: %d", sizes.size()); if (sizes.size() == 2) pref->setPropSplitterSizes(QString::number(sizes.first()) + ',' + QString::number(sizes.last())); @@ -382,118 +395,112 @@ void PropertiesWidget::saveSettings() void PropertiesWidget::reloadPreferences() { // Take program preferences into consideration - peersList->updatePeerHostNameResolutionState(); - peersList->updatePeerCountryResolutionState(); + m_peerList->updatePeerHostNameResolutionState(); + m_peerList->updatePeerCountryResolutionState(); } void PropertiesWidget::loadDynamicData() { - // Refresh only if the torrent handle is valid and if visible - if (!m_torrent || (main_window->currentTabWidget() != transferList) || (state != VISIBLE)) return; + // Refresh only if the torrent handle is valid and visible + if (!m_torrent || (m_mainWindow->currentTabWidget() != m_transferList) || (m_state != VISIBLE)) return; // Transfer infos switch (m_ui->stackedProperties->currentIndex()) { - case PropTabBar::MAIN_TAB: { - m_ui->wasted->setText(Utils::Misc::friendlyUnit(m_torrent->wastedSize())); + case PropTabBar::MainTab: { + m_ui->labelWastedVal->setText(Utils::Misc::friendlyUnit(m_torrent->wastedSize())); - m_ui->upTotal->setText(tr("%1 (%2 this session)").arg(Utils::Misc::friendlyUnit(m_torrent->totalUpload())) - .arg(Utils::Misc::friendlyUnit(m_torrent->totalPayloadUpload()))); + m_ui->labelUpTotalVal->setText(tr("%1 (%2 this session)").arg(Utils::Misc::friendlyUnit(m_torrent->totalUpload())) + .arg(Utils::Misc::friendlyUnit(m_torrent->totalPayloadUpload()))); - m_ui->dlTotal->setText(tr("%1 (%2 this session)").arg(Utils::Misc::friendlyUnit(m_torrent->totalDownload())) - .arg(Utils::Misc::friendlyUnit(m_torrent->totalPayloadDownload()))); + m_ui->labelDlTotalVal->setText(tr("%1 (%2 this session)").arg(Utils::Misc::friendlyUnit(m_torrent->totalDownload())) + .arg(Utils::Misc::friendlyUnit(m_torrent->totalPayloadDownload()))); - m_ui->lbl_uplimit->setText(m_torrent->uploadLimit() <= 0 ? QString::fromUtf8(C_INFINITY) : Utils::Misc::friendlyUnit(m_torrent->uploadLimit(), true)); + m_ui->labelUpLimitVal->setText(m_torrent->uploadLimit() <= 0 ? QString::fromUtf8(C_INFINITY) : Utils::Misc::friendlyUnit(m_torrent->uploadLimit(), true)); - m_ui->lbl_dllimit->setText(m_torrent->downloadLimit() <= 0 ? QString::fromUtf8(C_INFINITY) : Utils::Misc::friendlyUnit(m_torrent->downloadLimit(), true)); + m_ui->labelDlLimitVal->setText(m_torrent->downloadLimit() <= 0 ? QString::fromUtf8(C_INFINITY) : Utils::Misc::friendlyUnit(m_torrent->downloadLimit(), true)); - QString elapsed_txt; - if (m_torrent->isSeed()) - elapsed_txt = tr("%1 (seeded for %2)", "e.g. 4m39s (seeded for 3m10s)") - .arg(Utils::Misc::userFriendlyDuration(m_torrent->activeTime())) - .arg(Utils::Misc::userFriendlyDuration(m_torrent->seedingTime())); - else - elapsed_txt = Utils::Misc::userFriendlyDuration(m_torrent->activeTime()); - m_ui->lbl_elapsed->setText(elapsed_txt); + QString elapsedString; + if (m_torrent->isSeed()) + elapsedString = tr("%1 (seeded for %2)", "e.g. 4m39s (seeded for 3m10s)") + .arg(Utils::Misc::userFriendlyDuration(m_torrent->activeTime())) + .arg(Utils::Misc::userFriendlyDuration(m_torrent->seedingTime())); + else + elapsedString = Utils::Misc::userFriendlyDuration(m_torrent->activeTime()); + m_ui->labelElapsedVal->setText(elapsedString); - m_ui->lbl_connections->setText(tr("%1 (%2 max)", "%1 and %2 are numbers, e.g. 3 (10 max)") - .arg(m_torrent->connectionsCount()) - .arg(m_torrent->connectionsLimit() < 0 ? QString::fromUtf8(C_INFINITY) : QString::number(m_torrent->connectionsLimit()))); + m_ui->labelConnectionsVal->setText(tr("%1 (%2 max)", "%1 and %2 are numbers, e.g. 3 (10 max)") + .arg(m_torrent->connectionsCount()) + .arg(m_torrent->connectionsLimit() < 0 ? QString::fromUtf8(C_INFINITY) : QString::number(m_torrent->connectionsLimit()))); - m_ui->label_eta_val->setText(Utils::Misc::userFriendlyDuration(m_torrent->eta())); + m_ui->labelETAVal->setText(Utils::Misc::userFriendlyDuration(m_torrent->eta())); - // Update next announce time - m_ui->reannounce_lbl->setText(Utils::Misc::userFriendlyDuration(m_torrent->nextAnnounce())); + // Update next announce time + m_ui->labelReannounceInVal->setText(Utils::Misc::userFriendlyDuration(m_torrent->nextAnnounce())); - // Update ratio info - const qreal ratio = m_torrent->realRatio(); - m_ui->shareRatio->setText(ratio > BitTorrent::TorrentHandle::MAX_RATIO ? QString::fromUtf8(C_INFINITY) : Utils::String::fromDouble(ratio, 2)); + // Update ratio info + const qreal ratio = m_torrent->realRatio(); + m_ui->labelShareRatioVal->setText(ratio > BitTorrent::TorrentHandle::MAX_RATIO ? QString::fromUtf8(C_INFINITY) : Utils::String::fromDouble(ratio, 2)); - m_ui->label_seeds_val->setText(tr("%1 (%2 total)", "%1 and %2 are numbers, e.g. 3 (10 total)") - .arg(QString::number(m_torrent->seedsCount())) - .arg(QString::number(m_torrent->totalSeedsCount()))); + m_ui->labelSeedsVal->setText(tr("%1 (%2 total)", "%1 and %2 are numbers, e.g. 3 (10 total)") + .arg(QString::number(m_torrent->seedsCount())) + .arg(QString::number(m_torrent->totalSeedsCount()))); - m_ui->label_peers_val->setText(tr("%1 (%2 total)", "%1 and %2 are numbers, e.g. 3 (10 total)") - .arg(QString::number(m_torrent->leechsCount())) - .arg(QString::number(m_torrent->totalLeechersCount()))); + m_ui->labelPeersVal->setText(tr("%1 (%2 total)", "%1 and %2 are numbers, e.g. 3 (10 total)") + .arg(QString::number(m_torrent->leechsCount())) + .arg(QString::number(m_torrent->totalLeechersCount()))); - m_ui->label_dl_speed_val->setText(tr("%1 (%2 avg.)", "%1 and %2 are speed rates, e.g. 200KiB/s (100KiB/s avg.)") - .arg(Utils::Misc::friendlyUnit(m_torrent->downloadPayloadRate(), true)) - .arg(Utils::Misc::friendlyUnit(m_torrent->totalDownload() / (1 + m_torrent->activeTime() - m_torrent->finishedTime()), true))); + m_ui->labelDlSpeedVal->setText(tr("%1 (%2 avg.)", "%1 and %2 are speed rates, e.g. 200KiB/s (100KiB/s avg.)") + .arg(Utils::Misc::friendlyUnit(m_torrent->downloadPayloadRate(), true)) + .arg(Utils::Misc::friendlyUnit(m_torrent->totalDownload() / (1 + m_torrent->activeTime() - m_torrent->finishedTime()), true))); - m_ui->label_upload_speed_val->setText(tr("%1 (%2 avg.)", "%1 and %2 are speed rates, e.g. 200KiB/s (100KiB/s avg.)") - .arg(Utils::Misc::friendlyUnit(m_torrent->uploadPayloadRate(), true)) - .arg(Utils::Misc::friendlyUnit(m_torrent->totalUpload() / (1 + m_torrent->activeTime()), true))); + m_ui->labelUpSpeedVal->setText(tr("%1 (%2 avg.)", "%1 and %2 are speed rates, e.g. 200KiB/s (100KiB/s avg.)") + .arg(Utils::Misc::friendlyUnit(m_torrent->uploadPayloadRate(), true)) + .arg(Utils::Misc::friendlyUnit(m_torrent->totalUpload() / (1 + m_torrent->activeTime()), true))); - m_ui->label_last_complete_val->setText(m_torrent->lastSeenComplete().isValid() ? m_torrent->lastSeenComplete().toString(Qt::DefaultLocaleShortDate) : tr("Never")); + m_ui->labelLastSeenCompleteVal->setText(m_torrent->lastSeenComplete().isValid() ? m_torrent->lastSeenComplete().toString(Qt::DefaultLocaleShortDate) : tr("Never")); - m_ui->label_completed_on_val->setText(m_torrent->completedTime().isValid() ? m_torrent->completedTime().toString(Qt::DefaultLocaleShortDate) : ""); + m_ui->labelCompletedOnVal->setText(m_torrent->completedTime().isValid() ? m_torrent->completedTime().toString(Qt::DefaultLocaleShortDate) : ""); - m_ui->label_added_on_val->setText(m_torrent->addedTime().toString(Qt::DefaultLocaleShortDate)); + m_ui->labelAddedOnVal->setText(m_torrent->addedTime().toString(Qt::DefaultLocaleShortDate)); - if (m_torrent->hasMetadata()) { - m_ui->label_total_pieces_val->setText(tr("%1 x %2 (have %3)", "(torrent pieces) eg 152 x 4MB (have 25)").arg(m_torrent->piecesCount()).arg(Utils::Misc::friendlyUnit(m_torrent->pieceLength())).arg(m_torrent->piecesHave())); + if (m_torrent->hasMetadata()) { + m_ui->labelTotalPiecesVal->setText(tr("%1 x %2 (have %3)", "(torrent pieces) eg 152 x 4MB (have 25)").arg(m_torrent->piecesCount()).arg(Utils::Misc::friendlyUnit(m_torrent->pieceLength())).arg(m_torrent->piecesHave())); + + if (!m_torrent->isSeed() && !m_torrent->isPaused() && !m_torrent->isQueued() && !m_torrent->isChecking()) { + // Pieces availability + showPiecesAvailability(true); + m_piecesAvailability->setAvailability(m_torrent->pieceAvailability()); + m_ui->labelAverageAvailabilityVal->setText(Utils::String::fromDouble(m_torrent->distributedCopies(), 3)); + } + else { + showPiecesAvailability(false); + } - if (!m_torrent->isSeed() && !m_torrent->isPaused() && !m_torrent->isQueued() && !m_torrent->isChecking()) { - // Pieces availability - showPiecesAvailability(true); - pieces_availability->setAvailability(m_torrent->pieceAvailability()); - m_ui->avail_average_lbl->setText(Utils::String::fromDouble(m_torrent->distributedCopies(), 3)); + // Progress + qreal progress = m_torrent->progress() * 100.; + m_ui->labelProgressVal->setText(Utils::String::fromDouble(progress, 1) + "%"); + m_downloadedPieces->setProgress(m_torrent->pieces(), m_torrent->downloadingPieces()); } else { showPiecesAvailability(false); } - - // Progress - qreal progress = m_torrent->progress() * 100.; - m_ui->progress_lbl->setText(Utils::String::fromDouble(progress, 1) + "%"); - downloaded_pieces->setProgress(m_torrent->pieces(), m_torrent->downloadingPieces()); } - else { - showPiecesAvailability(false); - } - break; - } - - case PropTabBar::TRACKERS_TAB: { + case PropTabBar::TrackersTab: // Trackers - trackerList->loadTrackers(); + m_trackerList->loadTrackers(); break; - } - - case PropTabBar::PEERS_TAB: { + case PropTabBar::PeersTab: // Load peers - peersList->loadPeers(m_torrent); + m_peerList->loadPeers(m_torrent); break; - } - - case PropTabBar::FILES_TAB: { + case PropTabBar::FilesTab: // Files progress if (m_torrent->hasMetadata()) { qDebug("Updating priorities in files tab"); m_ui->filesList->setUpdatesEnabled(false); - PropListModel->model()->updateFilesProgress(m_torrent->filesProgress()); - PropListModel->model()->updateFilesAvailability(m_torrent->availableFileFractions()); + m_propListModel->model()->updateFilesProgress(m_torrent->filesProgress()); + m_propListModel->model()->updateFilesAvailability(m_torrent->availableFileFractions()); // XXX: We don't update file priorities regularly for performance // reasons. This means that priorities will not be updated if // set from the Web UI. @@ -501,8 +508,6 @@ void PropertiesWidget::loadDynamicData() m_ui->filesList->setUpdatesEnabled(true); } break; - } - default:; } } @@ -511,19 +516,19 @@ void PropertiesWidget::loadUrlSeeds() { m_ui->listWebSeeds->clear(); qDebug("Loading URL seeds"); - const QList hc_seeds = m_torrent->urlSeeds(); + const QList hcSeeds = m_torrent->urlSeeds(); // Add url seeds - foreach (const QUrl &hc_seed, hc_seeds) { - qDebug("Loading URL seed: %s", qUtf8Printable(hc_seed.toString())); - new QListWidgetItem(hc_seed.toString(), m_ui->listWebSeeds); + foreach (const QUrl &hcSeed, hcSeeds) { + qDebug("Loading URL seed: %s", qUtf8Printable(hcSeed.toString())); + new QListWidgetItem(hcSeed.toString(), m_ui->listWebSeeds); } } void PropertiesWidget::openDoubleClickedFile(const QModelIndex &index) { - if (!index.isValid()) return; - if (!m_torrent || !m_torrent->hasMetadata()) return; - if (PropListModel->itemType(index) == TorrentContentModelItem::FileType) + if (!index.isValid() || !m_torrent || !m_torrent->hasMetadata()) return; + + if (m_propListModel->itemType(index) == TorrentContentModelItem::FileType) openFile(index); else openFolder(index, false); @@ -531,48 +536,48 @@ void PropertiesWidget::openDoubleClickedFile(const QModelIndex &index) void PropertiesWidget::openFile(const QModelIndex &index) { - int i = PropListModel->getFileIndex(index); + int i = m_propListModel->getFileIndex(index); const QDir saveDir(m_torrent->savePath(true)); const QString filename = m_torrent->filePath(i); - const QString file_path = Utils::Fs::expandPath(saveDir.absoluteFilePath(filename)); - qDebug("Trying to open file at %s", qUtf8Printable(file_path)); + const QString filePath = Utils::Fs::expandPath(saveDir.absoluteFilePath(filename)); + qDebug("Trying to open file at %s", qUtf8Printable(filePath)); // Flush data m_torrent->flushCache(); - Utils::Misc::openPath(file_path); + Utils::Misc::openPath(filePath); } -void PropertiesWidget::openFolder(const QModelIndex &index, bool containing_folder) +void PropertiesWidget::openFolder(const QModelIndex &index, bool containingFolder) { - QString absolute_path; + QString absolutePath; // FOLDER - if (PropListModel->itemType(index) == TorrentContentModelItem::FolderType) { + if (m_propListModel->itemType(index) == TorrentContentModelItem::FolderType) { // Generate relative path to selected folder - QStringList path_items; - path_items << index.data().toString(); - QModelIndex parent = PropListModel->parent(index); + QStringList pathItems; + pathItems << index.data().toString(); + QModelIndex parent = m_propListModel->parent(index); while (parent.isValid()) { - path_items.prepend(parent.data().toString()); - parent = PropListModel->parent(parent); + pathItems.prepend(parent.data().toString()); + parent = m_propListModel->parent(parent); } - if (path_items.isEmpty()) + if (pathItems.isEmpty()) return; const QDir saveDir(m_torrent->savePath(true)); - const QString relative_path = path_items.join("/"); - absolute_path = Utils::Fs::expandPath(saveDir.absoluteFilePath(relative_path)); + const QString relativePath = pathItems.join("/"); + absolutePath = Utils::Fs::expandPath(saveDir.absoluteFilePath(relativePath)); } else { - int i = PropListModel->getFileIndex(index); + int i = m_propListModel->getFileIndex(index); const QDir saveDir(m_torrent->savePath(true)); - const QString relative_path = m_torrent->filePath(i); - absolute_path = Utils::Fs::expandPath(saveDir.absoluteFilePath(relative_path)); + const QString relativePath = m_torrent->filePath(i); + absolutePath = Utils::Fs::expandPath(saveDir.absoluteFilePath(relativePath)); } // Flush data m_torrent->flushCache(); - if (containing_folder) - Utils::Misc::openFolderSelect(absolute_path); + if (containingFolder) + Utils::Misc::openFolderSelect(absolutePath); else - Utils::Misc::openPath(absolute_path); + Utils::Misc::openPath(absolutePath); } void PropertiesWidget::displayFilesListMenu(const QPoint &) @@ -580,8 +585,8 @@ void PropertiesWidget::displayFilesListMenu(const QPoint &) if (!m_torrent) return; QModelIndexList selectedRows = m_ui->filesList->selectionModel()->selectedRows(0); - if (selectedRows.empty()) - return; + if (selectedRows.empty()) return; + QMenu myFilesLlistMenu; QAction *actOpen = nullptr; QAction *actOpenContainingFolder = nullptr; @@ -606,35 +611,33 @@ void PropertiesWidget::displayFilesListMenu(const QPoint &) // The selected torrent might have disappeared during exec() // from the current view thus leaving invalid indices. const QModelIndex index = *(selectedRows.begin()); - if (!index.isValid()) - return; - if (act) { - if (act == actOpen) { - openDoubleClickedFile(index); - } - else if (act == actOpenContainingFolder) { - openFolder(index, true); - } - else if (act == actRename) { - renameSelectedFile(); - } - else { - int prio = prio::NORMAL; - if (act == m_ui->actionHigh) - prio = prio::HIGH; - else if (act == m_ui->actionMaximum) - prio = prio::MAXIMUM; - else if (act == m_ui->actionNot_downloaded) - prio = prio::IGNORED; - - qDebug("Setting files priority"); - foreach (QModelIndex index, selectedRows) { - qDebug("Setting priority(%d) for file at row %d", prio, index.row()); - PropListModel->setData(PropListModel->index(index.row(), PRIORITY, index.parent()), prio); - } - // Save changes - filteredFilesChanged(); + if (!index.isValid() || !act) return; + + if (act == actOpen) { + openDoubleClickedFile(index); + } + else if (act == actOpenContainingFolder) { + openFolder(index, true); + } + else if (act == actRename) { + renameSelectedFile(); + } + else { + int prio = prio::NORMAL; + if (act == m_ui->actionHigh) + prio = prio::HIGH; + else if (act == m_ui->actionMaximum) + prio = prio::MAXIMUM; + else if (act == m_ui->actionNot_downloaded) + prio = prio::IGNORED; + + qDebug("Setting files priority"); + foreach (QModelIndex index, selectedRows) { + qDebug("Setting priority(%d) for file at row %d", prio, index.row()); + m_propListModel->setData(m_propListModel->index(index.row(), PRIORITY, index.parent()), prio); } + // Save changes + filteredFilesChanged(); } } @@ -657,16 +660,16 @@ void PropertiesWidget::displayWebSeedListMenu(const QPoint &) } const QAction *act = seedMenu.exec(QCursor::pos()); - if (act) { - if (act == actAdd) - askWebSeed(); - else if (act == actDel) - deleteSelectedUrlSeeds(); - else if (act == actCpy) - copySelectedWebSeedsToClipboard(); - else if (act == actEdit) - editWebSeed(); - } + if (!act) return; + + if (act == actAdd) + askWebSeed(); + else if (act == actDel) + deleteSelectedUrlSeeds(); + else if (act == actCpy) + copySelectedWebSeedsToClipboard(); + else if (act == actEdit) + editWebSeed(); } void PropertiesWidget::renameSelectedFile() @@ -692,9 +695,9 @@ void PropertiesWidget::renameSelectedFile() return; } - if (PropListModel->itemType(modelIndex) == TorrentContentModelItem::FileType) { + if (m_propListModel->itemType(modelIndex) == TorrentContentModelItem::FileType) { // renaming a file - const int fileIndex = PropListModel->getFileIndex(modelIndex); + const int fileIndex = m_propListModel->getFileIndex(modelIndex); if (newName.endsWith(QB_EXT)) newName.chop(QB_EXT.size()); @@ -722,16 +725,16 @@ void PropertiesWidget::renameSelectedFile() qDebug("Renaming %s to %s", qUtf8Printable(oldFilePath), qUtf8Printable(newFilePath)); m_torrent->renameFile(fileIndex, newFilePath); - PropListModel->setData(modelIndex, newName); + m_propListModel->setData(modelIndex, newName); } else { // renaming a folder QStringList pathItems; pathItems << modelIndex.data().toString(); - QModelIndex parent = PropListModel->parent(modelIndex); + QModelIndex parent = m_propListModel->parent(modelIndex); while (parent.isValid()) { pathItems.prepend(parent.data().toString()); - parent = PropListModel->parent(parent); + parent = m_propListModel->parent(parent); } const QString oldPath = pathItems.join("/"); pathItems.removeLast(); @@ -773,7 +776,7 @@ void PropertiesWidget::renameSelectedFile() // Force recheck if (forceRecheck) m_torrent->forceRecheck(); // Rename folder in torrent files model too - PropListModel->setData(modelIndex, newName); + m_propListModel->setData(modelIndex, newName); // Remove old folder const QDir oldFolder(m_torrent->savePath(true) + "/" + oldPath); int timeout = 10; @@ -830,52 +833,48 @@ void PropertiesWidget::deleteSelectedUrlSeeds() void PropertiesWidget::copySelectedWebSeedsToClipboard() const { - const QList selected_items = m_ui->listWebSeeds->selectedItems(); - if (selected_items.isEmpty()) - return; + const QList selectedItems = m_ui->listWebSeeds->selectedItems(); + if (selectedItems.isEmpty()) return; - QStringList urls_to_copy; - foreach (QListWidgetItem *item, selected_items) - urls_to_copy << item->text(); + QStringList urlsToCopy; + foreach (QListWidgetItem *item, selectedItems) + urlsToCopy << item->text(); - QApplication::clipboard()->setText(urls_to_copy.join("\n")); + QApplication::clipboard()->setText(urlsToCopy.join("\n")); } void PropertiesWidget::editWebSeed() { - const QList selected_items = m_ui->listWebSeeds->selectedItems(); - if (selected_items.size() != 1) - return; + const QList selectedItems = m_ui->listWebSeeds->selectedItems(); + if (selectedItems.size() != 1) return; - const QListWidgetItem *selected_item = selected_items.last(); - const QString old_seed = selected_item->text(); + const QListWidgetItem *selectedItem = selectedItems.last(); + const QString oldSeed = selectedItem->text(); bool result; - const QString new_seed = AutoExpandableDialog::getText(this, tr("Web seed editing"), + const QString newSeed = AutoExpandableDialog::getText(this, tr("Web seed editing"), tr("Web seed URL:"), QLineEdit::Normal, - old_seed, &result); - if (!result) - return; + oldSeed, &result); + if (!result) return; - if (!m_ui->listWebSeeds->findItems(new_seed, Qt::MatchFixedString).empty()) { + if (!m_ui->listWebSeeds->findItems(newSeed, Qt::MatchFixedString).empty()) { QMessageBox::warning(this, tr("qBittorrent"), tr("This URL seed is already in the list."), QMessageBox::Ok); return; } - m_torrent->removeUrlSeeds(QList() << old_seed); - m_torrent->addUrlSeeds(QList() << new_seed); + m_torrent->removeUrlSeeds(QList() << oldSeed); + m_torrent->addUrlSeeds(QList() << newSeed); loadUrlSeeds(); } -bool PropertiesWidget::applyPriorities() +void PropertiesWidget::applyPriorities() { qDebug("Saving files priorities"); - const QVector priorities = PropListModel->model()->getFilePriorities(); + const QVector priorities = m_propListModel->model()->getFilePriorities(); // Prioritize the files qDebug("prioritize files: %d", priorities[0]); m_torrent->prioritizeFiles(priorities); - return true; } void PropertiesWidget::filteredFilesChanged() @@ -886,10 +885,10 @@ void PropertiesWidget::filteredFilesChanged() void PropertiesWidget::filterText(const QString &filter) { - PropListModel->setFilterRegExp(QRegExp(filter, Qt::CaseInsensitive, QRegExp::WildcardUnix)); + m_propListModel->setFilterRegExp(QRegExp(filter, Qt::CaseInsensitive, QRegExp::WildcardUnix)); if (filter.isEmpty()) { m_ui->filesList->collapseAll(); - m_ui->filesList->expand(PropListModel->index(0, 0)); + m_ui->filesList->expand(m_propListModel->index(0, 0)); } else { m_ui->filesList->expandAll(); diff --git a/src/gui/properties/propertieswidget.h b/src/gui/properties/propertieswidget.h index 9bfefe10c..0685d90d6 100644 --- a/src/gui/properties/propertieswidget.h +++ b/src/gui/properties/propertieswidget.h @@ -1,6 +1,6 @@ /* - * Bittorrent Client using Qt4 and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Bittorrent Client using Qt and libtorrent. + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #ifndef PROPERTIESWIDGET_H @@ -36,32 +34,30 @@ #include "base/bittorrent/torrenthandle.h" -class TransferListWidget; -class TorrentContentFilterModel; -class PropListDelegate; -class torrent_file; -class PeerListWidget; -class TrackerList; -class SpeedWidget; -class MainWindow; -class DownloadedPiecesBar; -class PieceAvailabilityBar; -class PropTabBar; -class LineEdit; - -QT_BEGIN_NAMESPACE class QAction; class QPushButton; class QTimer; class QTreeView; -QT_END_NAMESPACE + +class DownloadedPiecesBar; +class LineEdit; +class MainWindow; +class PeerListWidget; +class PieceAvailabilityBar; +class PropListDelegate; +class PropTabBar; +class SpeedWidget; +class torrent_file; +class TorrentContentFilterModel; +class TrackerList; +class TransferListWidget; namespace Ui { class PropertiesWidget; } -class PropertiesWidget: public QWidget +class PropertiesWidget : public QWidget { Q_OBJECT Q_DISABLE_COPY(PropertiesWidget) @@ -73,13 +69,13 @@ public: VISIBLE }; - PropertiesWidget(QWidget *parent, MainWindow *main_window, TransferListWidget *transferList); + PropertiesWidget(QWidget *parent, MainWindow *mainWindow, TransferListWidget *transferList); ~PropertiesWidget(); BitTorrent::TorrentHandle *getCurrentTorrent() const; - TrackerList *getTrackerList() const { return trackerList; } - PeerListWidget *getPeerList() const { return peersList; } + TrackerList *getTrackerList() const; + PeerListWidget *getPeerList() const; QTreeView *getFilesList() const; - SpeedWidget *getSpeedWidget() const { return speedWidget; } + SpeedWidget *getSpeedWidget() const; public slots: void setVisibility(bool visible); @@ -93,7 +89,7 @@ public slots: protected: QPushButton *getButtonFromIndex(int index); - bool applyPriorities(); + void applyPriorities(); protected slots: void loadTorrentInfos(BitTorrent::TorrentHandle *const torrent); @@ -113,28 +109,28 @@ protected slots: private: void openFile(const QModelIndex &index); - void openFolder(const QModelIndex &index, bool containing_folder); + void openFolder(const QModelIndex &index, bool containingFolder); Ui::PropertiesWidget *m_ui; - TransferListWidget *transferList; - MainWindow *main_window; + TransferListWidget *m_transferList; + MainWindow *m_mainWindow; BitTorrent::TorrentHandle *m_torrent; - QTimer *refreshTimer; - SlideState state; - TorrentContentFilterModel *PropListModel; - PropListDelegate *PropDelegate; - PeerListWidget *peersList; - TrackerList *trackerList; - SpeedWidget *speedWidget; - QList slideSizes; - DownloadedPiecesBar *downloaded_pieces; - PieceAvailabilityBar *pieces_availability; + QTimer *m_refreshTimer; + SlideState m_state; + TorrentContentFilterModel *m_propListModel; + PropListDelegate *m_propListDelegate; + PeerListWidget *m_peerList; + TrackerList *m_trackerList; + SpeedWidget *m_speedWidget; + QList m_slideSizes; + DownloadedPiecesBar *m_downloadedPieces; + PieceAvailabilityBar *m_piecesAvailability; PropTabBar *m_tabBar; LineEdit *m_contentFilterLine; - QShortcut *editHotkeyFile; - QShortcut *editHotkeyWeb; - QShortcut *deleteHotkeyWeb; - QShortcut *openHotkeyFile; + QShortcut *m_editHotkeyFile; + QShortcut *m_editHotkeyWeb; + QShortcut *m_deleteHotkeyWeb; + QShortcut *m_openHotkeyFile; private slots: void filterText(const QString &filter); diff --git a/src/gui/properties/propertieswidget.ui b/src/gui/properties/propertieswidget.ui index 01d4e2faf..710d60310 100644 --- a/src/gui/properties/propertieswidget.ui +++ b/src/gui/properties/propertieswidget.ui @@ -67,7 +67,7 @@ 4 - + 0 @@ -83,7 +83,7 @@ - + 0 @@ -96,7 +96,7 @@ - + 0 @@ -112,7 +112,7 @@ - + 0 @@ -142,7 +142,7 @@ - + Qt::Horizontal @@ -161,7 +161,7 @@ 4 - + 0 @@ -174,7 +174,7 @@ - + 0 @@ -190,7 +190,7 @@ - + 0 @@ -203,7 +203,7 @@ - + 0 @@ -219,7 +219,7 @@ - + 0 @@ -235,7 +235,7 @@ - + 0 @@ -248,7 +248,7 @@ - + 0 @@ -261,7 +261,7 @@ - + 0 @@ -277,7 +277,7 @@ - + 0 @@ -293,7 +293,7 @@ - + 0 @@ -306,7 +306,7 @@ - + 0 @@ -319,7 +319,7 @@ - + 0 @@ -335,7 +335,7 @@ - + 0 @@ -351,7 +351,7 @@ - + 0 @@ -367,7 +367,7 @@ - + 0 @@ -380,7 +380,7 @@ - + 0 @@ -393,7 +393,7 @@ - + 0 @@ -409,7 +409,7 @@ - + 0 @@ -422,7 +422,7 @@ - + 0 @@ -438,7 +438,7 @@ - + 0 @@ -454,7 +454,7 @@ - + 0 @@ -467,7 +467,7 @@ - + 0 @@ -480,7 +480,7 @@ - + 0 @@ -493,7 +493,7 @@ - + 0 @@ -509,7 +509,7 @@ - + 0 @@ -522,7 +522,7 @@ - + 0 @@ -535,7 +535,7 @@ - + 0 @@ -551,7 +551,7 @@ - + 0 @@ -564,7 +564,7 @@ - + 0 @@ -580,7 +580,7 @@ - + 0 @@ -611,7 +611,7 @@ 2 - + 0 @@ -627,7 +627,7 @@ - + 0 @@ -640,7 +640,7 @@ - + 0 @@ -656,7 +656,7 @@ - + 0 @@ -669,7 +669,7 @@ - + 0 @@ -685,7 +685,7 @@ - + 0 @@ -698,7 +698,7 @@ - + 0 @@ -714,7 +714,7 @@ - + 0 @@ -727,7 +727,7 @@ - + 0 @@ -743,7 +743,7 @@ - + 0 @@ -756,7 +756,7 @@ - + 0 @@ -772,7 +772,7 @@ - + 0 @@ -785,7 +785,7 @@ - + 0 @@ -801,7 +801,7 @@ - + 0 @@ -817,7 +817,7 @@ - + 0 @@ -833,7 +833,7 @@ - + 0 @@ -852,7 +852,7 @@ - + 0 @@ -868,7 +868,7 @@ - + 0 @@ -1062,7 +1062,7 @@ - + 0 diff --git a/src/gui/properties/proplistdelegate.cpp b/src/gui/properties/proplistdelegate.cpp index b1b1b3645..075e617b8 100644 --- a/src/gui/properties/proplistdelegate.cpp +++ b/src/gui/properties/proplistdelegate.cpp @@ -1,6 +1,6 @@ /* * Bittorrent Client using Qt and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #include "proplistdelegate.h" @@ -83,53 +81,53 @@ void PropListDelegate::paint(QPainter *painter, const QStyleOptionViewItem &opti QItemDelegate::drawDisplay(painter, opt, option.rect, Utils::Misc::friendlyUnit(index.data().toLongLong())); break; case PROGRESS: { - if (index.data().toDouble() < 0) - break; - - QStyleOptionProgressBar newopt; - qreal progress = index.data().toDouble() * 100.; - newopt.rect = opt.rect; - newopt.text = ((progress == 100.0) ? QString("100%") : Utils::String::fromDouble(progress, 1) + "%"); - newopt.progress = int(progress); - newopt.maximum = 100; - newopt.minimum = 0; - newopt.textVisible = true; - if (index.sibling(index.row(), PRIORITY).data().toInt() == prio::IGNORED) { - newopt.state &= ~QStyle::State_Enabled; - newopt.palette = progressBarDisabledPalette(); - } - else { - newopt.state |= QStyle::State_Enabled; - } + if (index.data().toDouble() < 0) + break; + + QStyleOptionProgressBar newopt; + qreal progress = index.data().toDouble() * 100.; + newopt.rect = opt.rect; + newopt.text = ((progress == 100.0) ? QString("100%") : Utils::String::fromDouble(progress, 1) + "%"); + newopt.progress = int(progress); + newopt.maximum = 100; + newopt.minimum = 0; + newopt.textVisible = true; + if (index.sibling(index.row(), PRIORITY).data().toInt() == prio::IGNORED) { + newopt.state &= ~QStyle::State_Enabled; + newopt.palette = progressBarDisabledPalette(); + } + else { + newopt.state |= QStyle::State_Enabled; + } #ifndef Q_OS_WIN - QApplication::style()->drawControl(QStyle::CE_ProgressBar, &newopt, painter); + QApplication::style()->drawControl(QStyle::CE_ProgressBar, &newopt, painter); #else - // XXX: To avoid having the progress text on the right of the bar - QProxyStyle("fusion").drawControl(QStyle::CE_ProgressBar, &newopt, painter, 0); + // XXX: To avoid having the progress text on the right of the bar + QProxyStyle("fusion").drawControl(QStyle::CE_ProgressBar, &newopt, painter, 0); #endif - } - break; - case PRIORITY: { - QString text = ""; - switch (index.data().toInt()) { - case prio::MIXED: - text = tr("Mixed", "Mixed (priorities"); - break; - case prio::IGNORED: - text = tr("Not downloaded"); - break; - case prio::HIGH: - text = tr("High", "High (priority)"); - break; - case prio::MAXIMUM: - text = tr("Maximum", "Maximum (priority)"); - break; - default: - text = tr("Normal", "Normal (priority)"); - break; } - QItemDelegate::drawDisplay(painter, opt, option.rect, text); + break; + case PRIORITY: { + QString text = ""; + switch (index.data().toInt()) { + case prio::MIXED: + text = tr("Mixed", "Mixed (priorities"); + break; + case prio::IGNORED: + text = tr("Not downloaded"); + break; + case prio::HIGH: + text = tr("High", "High (priority)"); + break; + case prio::MAXIMUM: + text = tr("Maximum", "Maximum (priority)"); + break; + default: + text = tr("Normal", "Normal (priority)"); + break; + } + QItemDelegate::drawDisplay(painter, opt, option.rect, text); } break; case AVAILABILITY: { @@ -174,16 +172,16 @@ void PropListDelegate::setEditorData(QWidget *editor, const QModelIndex &index) QWidget *PropListDelegate::createEditor(QWidget *parent, const QStyleOptionViewItem &, const QModelIndex &index) const { - if (index.column() != PRIORITY) return 0; + if (index.column() != PRIORITY) return nullptr; if (m_properties) { BitTorrent::TorrentHandle *const torrent = m_properties->getCurrentTorrent(); if (!torrent || !torrent->hasMetadata() || torrent->isSeed()) - return 0; + return nullptr; } if (index.data().toInt() == prio::MIXED) - return 0; + return nullptr; QComboBox *editor = new QComboBox(parent); editor->setFocusPolicy(Qt::StrongFocus); diff --git a/src/gui/properties/proplistdelegate.h b/src/gui/properties/proplistdelegate.h index ed9035349..2f465644c 100644 --- a/src/gui/properties/proplistdelegate.h +++ b/src/gui/properties/proplistdelegate.h @@ -1,6 +1,6 @@ /* * Bittorrent Client using Qt and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #ifndef PROPLISTDELEGATE_H @@ -33,10 +31,10 @@ #include -class QPainter; +class QAbstractItemModel; class QModelIndex; +class QPainter; class QStyleOptionViewItem; -class QAbstractItemModel; class PropertiesWidget; // Defines for properties list columns @@ -50,7 +48,7 @@ enum PropColumn AVAILABILITY }; -class PropListDelegate: public QItemDelegate +class PropListDelegate : public QItemDelegate { Q_OBJECT @@ -72,5 +70,4 @@ private: PropertiesWidget *m_properties; }; -#endif - +#endif // PROPLISTDELEGATE_H diff --git a/src/gui/properties/proptabbar.cpp b/src/gui/properties/proptabbar.cpp index b2edf10f3..0418a345f 100644 --- a/src/gui/properties/proptabbar.cpp +++ b/src/gui/properties/proptabbar.cpp @@ -1,6 +1,6 @@ /* - * Bittorrent Client using Qt4 and libtorrent. - * Copyright (C) 2010 Christophe Dumez + * Bittorrent Client using Qt and libtorrent. + * Copyright (C) 2010 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,120 +24,121 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ +#include "proptabbar.h" + #include +#include #include #include -#include -#include "proptabbar.h" #include "guiiconprovider.h" -PropTabBar::PropTabBar(QWidget *parent) : - QHBoxLayout(parent), m_currentIndex(-1) +PropTabBar::PropTabBar(QWidget *parent) + : QHBoxLayout(parent) + , m_currentIndex(-1) { - setAlignment(Qt::AlignLeft | Qt::AlignCenter); - setSpacing(3); - m_btnGroup = new QButtonGroup(this); - // General tab - QPushButton *main_infos_button = new QPushButton( + setAlignment(Qt::AlignLeft | Qt::AlignCenter); + setSpacing(3); + m_btnGroup = new QButtonGroup(this); + // General tab + QPushButton *mainInfosButton = new QPushButton( #ifndef Q_OS_MAC - GuiIconProvider::instance()->getIcon("document-properties"), + GuiIconProvider::instance()->getIcon("document-properties"), #endif - tr("General"), parent); - main_infos_button->setShortcut(Qt::ALT + Qt::Key_G); - addWidget(main_infos_button); - m_btnGroup->addButton(main_infos_button, MAIN_TAB); - // Trackers tab - QPushButton *trackers_button = new QPushButton( + tr("General"), parent); + mainInfosButton->setShortcut(Qt::ALT + Qt::Key_G); + addWidget(mainInfosButton); + m_btnGroup->addButton(mainInfosButton, MainTab); + // Trackers tab + QPushButton *trackersButton = new QPushButton( #ifndef Q_OS_MAC - GuiIconProvider::instance()->getIcon("network-server"), + GuiIconProvider::instance()->getIcon("network-server"), #endif - tr("Trackers"), parent); - trackers_button->setShortcut(Qt::ALT + Qt::Key_C); - addWidget(trackers_button); - m_btnGroup->addButton(trackers_button, TRACKERS_TAB); - // Peers tab - QPushButton *peers_button = new QPushButton( + tr("Trackers"), parent); + trackersButton->setShortcut(Qt::ALT + Qt::Key_C); + addWidget(trackersButton); + m_btnGroup->addButton(trackersButton, TrackersTab); + // Peers tab + QPushButton *peersButton = new QPushButton( #ifndef Q_OS_MAC - GuiIconProvider::instance()->getIcon("edit-find-user"), + GuiIconProvider::instance()->getIcon("edit-find-user"), #endif - tr("Peers"), parent); - peers_button->setShortcut(Qt::ALT + Qt::Key_R); - addWidget(peers_button); - m_btnGroup->addButton(peers_button, PEERS_TAB); - // URL seeds tab - QPushButton *urlseeds_button = new QPushButton( + tr("Peers"), parent); + peersButton->setShortcut(Qt::ALT + Qt::Key_R); + addWidget(peersButton); + m_btnGroup->addButton(peersButton, PeersTab); + // URL seeds tab + QPushButton *URLSeedsButton = new QPushButton( #ifndef Q_OS_MAC - GuiIconProvider::instance()->getIcon("network-server"), + GuiIconProvider::instance()->getIcon("network-server"), #endif - tr("HTTP Sources"), parent); - urlseeds_button->setShortcut(Qt::ALT + Qt::Key_B); - addWidget(urlseeds_button); - m_btnGroup->addButton(urlseeds_button, URLSEEDS_TAB); - // Files tab - QPushButton *files_button = new QPushButton( + tr("HTTP Sources"), parent); + URLSeedsButton->setShortcut(Qt::ALT + Qt::Key_B); + addWidget(URLSeedsButton); + m_btnGroup->addButton(URLSeedsButton, URLSeedsTab); + // Files tab + QPushButton *filesButton = new QPushButton( #ifndef Q_OS_MAC - GuiIconProvider::instance()->getIcon("inode-directory"), + GuiIconProvider::instance()->getIcon("inode-directory"), #endif - tr("Content"), parent); - files_button->setShortcut(Qt::ALT + Qt::Key_Z); - addWidget(files_button); - m_btnGroup->addButton(files_button, FILES_TAB); - // Spacer - addItem(new QSpacerItem(0, 0, QSizePolicy::Expanding, QSizePolicy::Fixed)); - // Speed tab - QPushButton *speed_button = new QPushButton( + tr("Content"), parent); + filesButton->setShortcut(Qt::ALT + Qt::Key_Z); + addWidget(filesButton); + m_btnGroup->addButton(filesButton, FilesTab); + // Spacer + addItem(new QSpacerItem(0, 0, QSizePolicy::Expanding, QSizePolicy::Fixed)); + // Speed tab + QPushButton *speedButton = new QPushButton( #ifndef Q_OS_MAC - GuiIconProvider::instance()->getIcon("office-chart-line"), + GuiIconProvider::instance()->getIcon("office-chart-line"), #endif - tr("Speed"), parent); - speed_button->setShortcut(Qt::ALT + Qt::Key_D); - addWidget(speed_button); - m_btnGroup->addButton(speed_button, SPEED_TAB); - // SIGNAL/SLOT - connect(m_btnGroup, SIGNAL(buttonClicked(int)), SLOT(setCurrentIndex(int))); - // Disable buttons focus - foreach (QAbstractButton *btn, m_btnGroup->buttons()) { - btn->setFocusPolicy(Qt::NoFocus); - } + tr("Speed"), parent); + speedButton->setShortcut(Qt::ALT + Qt::Key_D); + addWidget(speedButton); + m_btnGroup->addButton(speedButton, SpeedTab); + // SIGNAL/SLOT + connect(m_btnGroup, SIGNAL(buttonClicked(int)), SLOT(setCurrentIndex(int))); + // Disable buttons focus + foreach (QAbstractButton *btn, m_btnGroup->buttons()) + btn->setFocusPolicy(Qt::NoFocus); } -PropTabBar::~PropTabBar() { - delete m_btnGroup; +PropTabBar::~PropTabBar() +{ + delete m_btnGroup; } int PropTabBar::currentIndex() const { - return m_currentIndex; + return m_currentIndex; } void PropTabBar::setCurrentIndex(int index) { - if (index >= m_btnGroup->buttons().size()) + if (index >= m_btnGroup->buttons().size()) index = 0; - // If asked to hide or if the currently selected tab is clicked - if (index < 0 || m_currentIndex == index) { + // If asked to hide or if the currently selected tab is clicked + if (index < 0 || m_currentIndex == index) { + if (m_currentIndex >= 0) { + m_btnGroup->button(m_currentIndex)->setDown(false); + m_currentIndex = -1; + emit visibilityToggled(false); + } + return; + } + // Unselect previous tab if (m_currentIndex >= 0) { - m_btnGroup->button(m_currentIndex)->setDown(false); - m_currentIndex = -1; - emit visibilityToggled(false); + m_btnGroup->button(m_currentIndex)->setDown(false); + } + else { + // Nothing was selected, show! + emit visibilityToggled(true); } - return; - } - // Unselect previous tab - if (m_currentIndex >= 0) { - m_btnGroup->button(m_currentIndex)->setDown(false); - } else { - // Nothing was selected, show! - emit visibilityToggled(true); - } - // Select the new button - m_btnGroup->button(index)->setDown(true); - m_currentIndex = index; - // Emit the signal - emit tabChanged(index); + // Select the new button + m_btnGroup->button(index)->setDown(true); + m_currentIndex = index; + // Emit the signal + emit tabChanged(index); } diff --git a/src/gui/properties/proptabbar.h b/src/gui/properties/proptabbar.h index 85fffe9d2..aa73c51f4 100644 --- a/src/gui/properties/proptabbar.h +++ b/src/gui/properties/proptabbar.h @@ -1,6 +1,6 @@ /* - * Bittorrent Client using Qt4 and libtorrent. - * Copyright (C) 2010 Christophe Dumez + * Bittorrent Client using Qt and libtorrent. + * Copyright (C) 2010 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #ifndef PROPTABBAR_H @@ -33,9 +31,7 @@ #include -QT_BEGIN_NAMESPACE class QButtonGroup; -QT_END_NAMESPACE class PropTabBar : public QHBoxLayout { @@ -43,24 +39,30 @@ class PropTabBar : public QHBoxLayout Q_DISABLE_COPY(PropTabBar) public: - enum PropertyTab {MAIN_TAB, TRACKERS_TAB, PEERS_TAB, URLSEEDS_TAB, FILES_TAB, SPEED_TAB}; + enum PropertyTab + { + MainTab, + TrackersTab, + PeersTab, + URLSeedsTab, + FilesTab, + SpeedTab + }; -public: - explicit PropTabBar(QWidget *parent = 0); - ~PropTabBar(); - int currentIndex() const; + explicit PropTabBar(QWidget *parent = nullptr); + ~PropTabBar(); + int currentIndex() const; signals: - void tabChanged(int index); - void visibilityToggled(bool visible); + void tabChanged(int index); + void visibilityToggled(bool visible); public slots: - void setCurrentIndex(int index); + void setCurrentIndex(int index); private: - QButtonGroup *m_btnGroup; - int m_currentIndex; - + QButtonGroup *m_btnGroup; + int m_currentIndex; }; #endif // PROPTABBAR_H diff --git a/src/gui/properties/speedplotview.cpp b/src/gui/properties/speedplotview.cpp index d22ae99a0..c7e4aceca 100644 --- a/src/gui/properties/speedplotview.cpp +++ b/src/gui/properties/speedplotview.cpp @@ -191,20 +191,20 @@ void SpeedPlotView::paintEvent(QPaintEvent *) Utils::Misc::friendlyUnit(0, true) }; - int yAxeWidth = 0; + int yAxisWidth = 0; for (const QString &label : speedLabels) - if (fontMetrics.width(label) > yAxeWidth) - yAxeWidth = fontMetrics.width(label); + if (fontMetrics.width(label) > yAxisWidth) + yAxisWidth = fontMetrics.width(label); int i = 0; for (const QString &label : speedLabels) { - QRectF labelRect(rect.topLeft() + QPointF(-yAxeWidth, (i++) * 0.25 * rect.height() - fontMetrics.height()), - QSizeF(2 * yAxeWidth, fontMetrics.height())); + QRectF labelRect(rect.topLeft() + QPointF(-yAxisWidth, (i++) * 0.25 * rect.height() - fontMetrics.height()), + QSizeF(2 * yAxisWidth, fontMetrics.height())); painter.drawText(labelRect, label, Qt::AlignRight | Qt::AlignTop); } // draw grid lines - rect.adjust(yAxeWidth + 4, 0, 0, 0); + rect.adjust(yAxisWidth + 4, 0, 0, 0); QPen gridPen; gridPen.setStyle(Qt::DashLine); @@ -236,18 +236,16 @@ void SpeedPlotView::paintEvent(QPaintEvent *) boost::circular_buffer &queue = getCurrentData(); for (int id = UP; id < NB_GRAPHS; ++id) { - if (!m_properties[static_cast(id)].enable) continue; QVector points; - for (int i = int(queue.size()) - 1, j = 0; i >= 0 && j <= m_viewablePointsCount; --i, ++j) { - int new_x = rect.right() - j * xTickSize; - int new_y = rect.bottom() - queue[i].y[id] * yMultiplier; + int newX = rect.right() - j * xTickSize; + int newY = rect.bottom() - queue[i].y[id] * yMultiplier; - points.push_back(QPoint(new_x, new_y)); + points.push_back(QPoint(newX, newY)); } painter.setPen(m_properties[static_cast(id)].pen); @@ -260,7 +258,6 @@ void SpeedPlotView::paintEvent(QPaintEvent *) double legendHeight = 0; int legendWidth = 0; for (const auto &property : m_properties) { - if (!property.enable) continue; @@ -276,7 +273,6 @@ void SpeedPlotView::paintEvent(QPaintEvent *) i = 0; for (const auto &property : m_properties) { - if (!property.enable) continue; @@ -293,10 +289,12 @@ void SpeedPlotView::paintEvent(QPaintEvent *) SpeedPlotView::GraphProperties::GraphProperties() : enable(false) -{} +{ +} SpeedPlotView::GraphProperties::GraphProperties(const QString &name, const QPen &pen, bool enable) : name(name) , pen(pen) , enable(enable) -{} +{ +} diff --git a/src/gui/properties/speedplotview.h b/src/gui/properties/speedplotview.h index 71fcdd19a..6c92166fc 100644 --- a/src/gui/properties/speedplotview.h +++ b/src/gui/properties/speedplotview.h @@ -55,6 +55,7 @@ public: DHT_DOWN, TRACKER_UP, TRACKER_DOWN, + NB_GRAPHS }; @@ -82,7 +83,7 @@ public: void replot(); protected: - virtual void paintEvent(QPaintEvent *event); + void paintEvent(QPaintEvent *event) override; private: enum PeriodInSeconds @@ -110,6 +111,9 @@ private: bool enable; }; + int maxYValue(); + boost::circular_buffer &getCurrentData(); + boost::circular_buffer m_data5Min; boost::circular_buffer m_data30Min; boost::circular_buffer m_data6Hour; @@ -120,10 +124,6 @@ private: int m_counter30Min; int m_counter6Hour; - - int maxYValue(); - - boost::circular_buffer &getCurrentData(); }; #endif // SPEEDPLOTVIEW_H diff --git a/src/gui/properties/speedwidget.cpp b/src/gui/properties/speedwidget.cpp index 1d4f71b16..3f6910c5a 100644 --- a/src/gui/properties/speedwidget.cpp +++ b/src/gui/properties/speedwidget.cpp @@ -38,10 +38,10 @@ #include -#include "propertieswidget.h" #include "base/bittorrent/session.h" #include "base/bittorrent/sessionstatus.h" #include "base/preferences.h" +#include "propertieswidget.h" ComboBoxMenuButton::ComboBoxMenuButton(QWidget *parent, QMenu *menu) : QComboBox(parent) diff --git a/src/gui/properties/speedwidget.h b/src/gui/properties/speedwidget.h index 222f802ba..b82177042 100644 --- a/src/gui/properties/speedwidget.h +++ b/src/gui/properties/speedwidget.h @@ -29,8 +29,8 @@ #ifndef SPEEDWIDGET_H #define SPEEDWIDGET_H -#include #include +#include #include "speedplotview.h" @@ -44,6 +44,7 @@ class PropertiesWidget; class ComboBoxMenuButton : public QComboBox { Q_OBJECT + public: ComboBoxMenuButton(QWidget *parent, QMenu *menu); virtual void showPopup(); @@ -56,6 +57,7 @@ private: class SpeedWidget : public QWidget { Q_OBJECT + public: SpeedWidget(PropertiesWidget *parent); ~SpeedWidget(); diff --git a/src/gui/properties/trackerlist.cpp b/src/gui/properties/trackerlist.cpp index 3110a103e..b0d2d0d80 100644 --- a/src/gui/properties/trackerlist.cpp +++ b/src/gui/properties/trackerlist.cpp @@ -399,13 +399,13 @@ void TrackerList::copyTrackerUrl() QList selectedTrackerItems = getSelectedTrackerItems(); if (selectedTrackerItems.isEmpty()) return; - QStringList URLsToCopy; + QStringList urlsToCopy; foreach (QTreeWidgetItem *item, selectedTrackerItems) { QString trackerURL = item->data(COL_URL, Qt::DisplayRole).toString(); qDebug() << QString("Copy: ") + trackerURL; - URLsToCopy << trackerURL; + urlsToCopy << trackerURL; } - QApplication::clipboard()->setText(URLsToCopy.join("\n")); + QApplication::clipboard()->setText(urlsToCopy.join("\n")); } @@ -420,10 +420,10 @@ void TrackerList::deleteSelectedTrackers() QList selectedTrackerItems = getSelectedTrackerItems(); if (selectedTrackerItems.isEmpty()) return; - QStringList URLsToRemove; + QStringList urlsToRemove; foreach (QTreeWidgetItem *item, selectedTrackerItems) { QString trackerURL = item->data(COL_URL, Qt::DisplayRole).toString(); - URLsToRemove << trackerURL; + urlsToRemove << trackerURL; m_trackerItems.remove(trackerURL); delete item; } @@ -432,7 +432,7 @@ void TrackerList::deleteSelectedTrackers() QList remainingTrackers; QList trackers = torrent->trackers(); foreach (const BitTorrent::TrackerEntry &entry, trackers) { - if (!URLsToRemove.contains(entry.url())) + if (!urlsToRemove.contains(entry.url())) remainingTrackers.push_back(entry); } diff --git a/src/gui/properties/trackersadditiondlg.cpp b/src/gui/properties/trackersadditiondlg.cpp index 5a63f9fd7..34252a96e 100644 --- a/src/gui/properties/trackersadditiondlg.cpp +++ b/src/gui/properties/trackersadditiondlg.cpp @@ -1,6 +1,6 @@ /* * Bittorrent Client using Qt and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,22 +24,20 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #include "trackersadditiondlg.h" -#include -#include #include +#include +#include #include -#include "base/utils/misc.h" -#include "base/utils/fs.h" -#include "base/net/downloadmanager.h" -#include "base/net/downloadhandler.h" -#include "base/bittorrent/trackerentry.h" #include "base/bittorrent/torrenthandle.h" +#include "base/bittorrent/trackerentry.h" +#include "base/net/downloadhandler.h" +#include "base/net/downloadmanager.h" +#include "base/utils/fs.h" +#include "base/utils/misc.h" #include "guiiconprovider.h" #include "ui_trackersadditiondlg.h" @@ -75,14 +73,14 @@ void TrackersAdditionDlg::on_uTorrentListButton_clicked() Net::DownloadHandler *handler = Net::DownloadManager::instance()->downloadUrl(m_ui->list_url->text(), true); connect(handler, SIGNAL(downloadFinished(QString, QString)), this, SLOT(parseUTorrentList(QString, QString))); connect(handler, SIGNAL(downloadFailed(QString, QString)), this, SLOT(getTrackerError(QString, QString))); - //Just to show that it takes times + // Just to show that it takes times setCursor(Qt::WaitCursor); } void TrackersAdditionDlg::parseUTorrentList(const QString &, const QString &path) { - QFile list_file(path); - if (!list_file.open(QFile::ReadOnly)) { + QFile listFile(path); + if (!listFile.open(QFile::ReadOnly)) { QMessageBox::warning(this, tr("I/O Error"), tr("Error while trying to open the downloaded file."), QMessageBox::Ok); setCursor(Qt::ArrowCursor); m_ui->uTorrentListButton->setEnabled(true); @@ -94,8 +92,8 @@ void TrackersAdditionDlg::parseUTorrentList(const QString &, const QString &path QList existingTrackers = m_torrent->trackers(); // Load from current user list QStringList tmp = m_ui->trackers_list->toPlainText().split("\n"); - foreach (const QString &user_url, tmp) { - BitTorrent::TrackerEntry userTracker(user_url); + foreach (const QString &userURL, tmp) { + BitTorrent::TrackerEntry userTracker(userURL); if (!existingTrackers.contains(userTracker)) existingTrackers << userTracker; } @@ -104,8 +102,8 @@ void TrackersAdditionDlg::parseUTorrentList(const QString &, const QString &path if (!m_ui->trackers_list->toPlainText().isEmpty() && !m_ui->trackers_list->toPlainText().endsWith("\n")) m_ui->trackers_list->insertPlainText("\n"); int nb = 0; - while (!list_file.atEnd()) { - const QString line = list_file.readLine().trimmed(); + while (!listFile.atEnd()) { + const QString line = listFile.readLine().trimmed(); if (line.isEmpty()) continue; BitTorrent::TrackerEntry newTracker(line); if (!existingTrackers.contains(newTracker)) { @@ -114,7 +112,7 @@ void TrackersAdditionDlg::parseUTorrentList(const QString &, const QString &path } } // Clean up - list_file.close(); + listFile.close(); Utils::Fs::forceRemove(path); //To restore the cursor ... setCursor(Qt::ArrowCursor); diff --git a/src/gui/properties/trackersadditiondlg.h b/src/gui/properties/trackersadditiondlg.h index fc355acea..0d3ac6bfd 100644 --- a/src/gui/properties/trackersadditiondlg.h +++ b/src/gui/properties/trackersadditiondlg.h @@ -1,6 +1,6 @@ /* * Bittorrent Client using Qt and libtorrent. - * Copyright (C) 2006 Christophe Dumez + * Copyright (C) 2006 Christophe Dumez * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -24,8 +24,6 @@ * modify file(s), you may extend this exception to your version of the file(s), * but you are not obligated to do so. If you do not wish to do so, delete this * exception statement from your version. - * - * Contact : chris@qbittorrent.org */ #ifndef TRACKERSADDITION_H @@ -67,4 +65,4 @@ private: BitTorrent::TorrentHandle *const m_torrent; }; -#endif +#endif // TRACKERSADDITION_H