d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-02-03 10:25:02 +00:00
Code Issues Projects Releases Wiki Activity

Fix singleton class ownership

Browse Source 
We shouldn't allow Qt parent ownership in here.
This commit is contained in:
Chocobo1 2020-02-07 15:19:23 +08:00
parent fa43dab3a2
commit a6cdba17f0
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
3 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/application.cpp
View File

@ -550,7 +550,7 @@ int Application::exec(const QStringList &params)
#ifndef DISABLE_COUNTRIES_RESOLUTION #ifndef DISABLE_COUNTRIES_RESOLUTION
Net::GeoIPManager::initInstance(); Net::GeoIPManager::initInstance();
#endif #endif
ScanFoldersModel::initInstance(this); ScanFoldersModel::initInstance();
#ifndef DISABLE_WEBUI #ifndef DISABLE_WEBUI
m_webui = new WebUI; m_webui = new WebUI;

10
src/base/scanfoldersmodel.cpp
View File

@ -57,14 +57,10 @@ struct ScanFoldersModel::PathData
ScanFoldersModel *ScanFoldersModel::m_instance = nullptr; ScanFoldersModel *ScanFoldersModel::m_instance = nullptr;
bool ScanFoldersModel::initInstance(QObject *parent) void ScanFoldersModel::initInstance()
{ {
if (!m_instance) { if (!m_instance)
m_instance = new ScanFoldersModel(parent); m_instance = new ScanFoldersModel;
return true;
}
return false;
} }
void ScanFoldersModel::freeInstance() void ScanFoldersModel::freeInstance()

2
src/base/scanfoldersmodel.h
View File

@ -65,7 +65,7 @@ public:
CUSTOM_LOCATION CUSTOM_LOCATION
}; };
static bool initInstance(QObject *parent = nullptr); static void initInstance();
static void freeInstance(); static void freeInstance();
static ScanFoldersModel *instance(); static ScanFoldersModel *instance();