Browse Source

Fix unchecked dynamic_cast

Replace some unnecessary (and slow) dynamic_cast with static_cast.
adaptive-webui-19844
Vladimir Golovnev (Glassez) 9 years ago
parent
commit
a35cbdc4a9
  1. 9
      src/gui/torrentcontentmodel.cpp
  2. 2
      src/gui/transferlistsortmodel.cpp

9
src/gui/torrentcontentmodel.cpp

@ -167,9 +167,12 @@ TorrentContentModelItem::ItemType TorrentContentModel::itemType(const QModelInde @@ -167,9 +167,12 @@ TorrentContentModelItem::ItemType TorrentContentModel::itemType(const QModelInde
int TorrentContentModel::getFileIndex(const QModelIndex& index)
{
TorrentContentModelFile* item = dynamic_cast<TorrentContentModelFile*>(static_cast<TorrentContentModelItem*>(index.internalPointer()));
Q_ASSERT(item);
return item->fileIndex();
TorrentContentModelItem *item = static_cast<TorrentContentModelItem*>(index.internalPointer());
if (item->itemType() == TorrentContentModelItem::FileType)
return static_cast<TorrentContentModelFile*>(item)->fileIndex();
Q_ASSERT(item->itemType() == TorrentContentModelItem::FileType);
return -1;
}
QVariant TorrentContentModel::data(const QModelIndex& index, int role) const

2
src/gui/transferlistsortmodel.cpp

@ -191,7 +191,7 @@ bool TransferListSortModel::lessThan(const QModelIndex &left, const QModelIndex @@ -191,7 +191,7 @@ bool TransferListSortModel::lessThan(const QModelIndex &left, const QModelIndex
bool TransferListSortModel::lowerPositionThan(const QModelIndex &left, const QModelIndex &right) const
{
const TorrentModel *model = dynamic_cast<TorrentModel*>(sourceModel());
const TorrentModel *model = static_cast<TorrentModel*>(sourceModel());
// Sort according to TR_PRIORITY
const int queueL = model->data(model->index(left.row(), TorrentModel::TR_PRIORITY)).toInt();

Loading…
Cancel
Save