d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-11 15:27:54 +00:00
Code Issues Projects Releases Wiki Activity

Use QSet for tracking server connections

Browse Source 
We don't need to maintain order between connections so QSet would be more suitable.
This commit is contained in:
Chocobo1 2019-04-15 21:22:11 +08:00
parent a35b6cc8dd
commit a2a669572c
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/base/http/server.cpp
View File

@ -107,19 +107,19 @@ void Server::incomingConnection(const qintptr socketDescriptor)
}
auto *c = new Connection(serverSocket, m_requestHandler, this);
m_connections.append(c);
m_connections.insert(c);
connect(serverSocket, &QAbstractSocket::disconnected, this, [c, this]() { removeConnection(c); });
}
void Server::removeConnection(Connection *connection)
{
m_connections.removeOne(connection);
m_connections.remove(connection);
connection->deleteLater();
}
void Server::dropTimedOutConnection()
{
QMutableListIterator<Connection *> i(m_connections);
QMutableSetIterator<Connection *> i(m_connections);
while (i.hasNext()) {
Connection *connection = i.next();
if (connection->hasExpired(KEEP_ALIVE_DURATION)) {

3
src/base/http/server.h
View File

@ -31,6 +31,7 @@
#ifndef HTTP_SERVER_H
#define HTTP_SERVER_H
#include <QSet>
#include <QSslCertificate>
#include <QSslKey>
#include <QTcpServer>
@ -59,7 +60,7 @@ namespace Http
void removeConnection(Connection *connection);
IRequestHandler *m_requestHandler;
QList<Connection *> m_connections; // for tracking persistent connections
QSet<Connection *> m_connections; // for tracking persistent connections
bool m_https;
QList<QSslCertificate> m_certificates;