Browse Source

WebAPI: fix validating wrong header field. Closes #7311.

X-Forwarded-Host is a foreign proxy setting, it isn't the same as
qbt's local setting and thus it makes no sense to verify it.
adaptive-webui-19844
Chocobo1 7 years ago
parent
commit
9ef1e32327
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
  1. 3
      src/webui/abstractwebapplication.cpp

3
src/webui/abstractwebapplication.cpp

@ -420,8 +420,7 @@ bool AbstractWebApplication::isCrossSiteRequest(const Http::Request &request) co @@ -420,8 +420,7 @@ bool AbstractWebApplication::isCrossSiteRequest(const Http::Request &request) co
bool AbstractWebApplication::validateHostHeader(const Http::Request &request, const Http::Environment &env, const QStringList &domains) const
{
const QUrl hostHeader = QUrl::fromUserInput(
request.headers.value(Http::HEADER_X_FORWARDED_HOST, request.headers.value(Http::HEADER_HOST)));
const QUrl hostHeader = QUrl::fromUserInput(request.headers.value(Http::HEADER_HOST));
// (if present) try matching host header's port with local port
const int requestPort = hostHeader.port();

Loading…
Cancel
Save