From 935b30b17ab410c401b58974b45c74ee10c8486a Mon Sep 17 00:00:00 2001
From: Tim Delaney <timothy.c.delaney@gmail.com>
Date: Sun, 6 Nov 2016 16:53:06 +1100
Subject: [PATCH] RSS use red text to indicate invalid filter. Closes #6165.

--HG--
branch : magao-dev
---
 src/gui/rss/automatedrssdownloader.cpp | 19 ++++++++++++++++---
 src/gui/rss/automatedrssdownloader.h   |  2 +-
 src/gui/rss/automatedrssdownloader.ui  | 10 ++++++++++
 3 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/src/gui/rss/automatedrssdownloader.cpp b/src/gui/rss/automatedrssdownloader.cpp
index cd253f849..6288f4397 100644
--- a/src/gui/rss/automatedrssdownloader.cpp
+++ b/src/gui/rss/automatedrssdownloader.cpp
@@ -73,8 +73,6 @@ AutomatedRssDownloader::AutomatedRssDownloader(const QWeakPointer<Rss::Manager>
     m_editableRuleList = new Rss::DownloadRuleList; // Read rule list from disk
     m_episodeRegex = new QRegExp("^(^[1-9]{1,1}\\d{0,3}x([1-9]{1,1}\\d{0,3}(-([1-9]{1,1}\\d{0,3})?)?;){1,}){1,1}",
                                  Qt::CaseInsensitive);
-    m_episodeValidator = new QRegExpValidator(*m_episodeRegex, ui->lineEFilter);
-    ui->lineEFilter->setValidator(m_episodeValidator);
     QString tip = "<p>" + tr("Matches articles based on episode filter.") + "</p><p><b>" + tr("Example: ")
                   + "1x2;8-15;5;30-;</b>" + tr(" will match 2, 5, 8 through 15, 30 and onward episodes of season one", "example X will match") + "</p>";
     tip += "<p>" + tr("Episode filter rules: ") + "</p><ul><li>" + tr("Season number is a mandatory non-zero value") + "</li>"
@@ -103,6 +101,8 @@ AutomatedRssDownloader::AutomatedRssDownloader(const QWeakPointer<Rss::Manager>
     Q_ASSERT(ok);
     ok = connect(ui->lineNotContains, SIGNAL(textEdited(QString)), SLOT(updateMustNotLineValidity()));
     Q_ASSERT(ok);
+    ok = connect(ui->lineEFilter, SIGNAL(textEdited(QString)), SLOT(updateEpisodeFilterValidity()));
+    Q_ASSERT(ok);
     ok = connect(ui->checkRegex, SIGNAL(stateChanged(int)), SLOT(updateMatchingArticles()));
     Q_ASSERT(ok);
     ok = connect(ui->checkRegex, SIGNAL(stateChanged(int)), SLOT(updateMustLineValidity()));
@@ -132,7 +132,6 @@ AutomatedRssDownloader::~AutomatedRssDownloader()
     delete deleteHotkey;
     delete ui;
     delete m_editableRuleList;
-    delete m_episodeValidator;
     delete m_episodeRegex;
 }
 
@@ -642,6 +641,20 @@ void AutomatedRssDownloader::updateMustNotLineValidity()
     }
 }
 
+void AutomatedRssDownloader::updateEpisodeFilterValidity()
+{
+    const QString text = ui->lineEFilter->text();
+    bool valid = m_episodeRegex->indexIn(text) != -1;
+    if (valid) {
+        ui->lineEFilter->setStyleSheet("");
+        ui->lbl_epfilter_stat->setPixmap(QPixmap());
+    }
+    else {
+        ui->lineEFilter->setStyleSheet("QLineEdit { color: #ff0000; }");
+        ui->lbl_epfilter_stat->setPixmap(GuiIconProvider::instance()->getIcon("task-attention").pixmap(16, 16));
+    }
+}
+
 void AutomatedRssDownloader::onFinished(int result)
 {
     Q_UNUSED(result);
diff --git a/src/gui/rss/automatedrssdownloader.h b/src/gui/rss/automatedrssdownloader.h
index 54f474048..20cc19354 100644
--- a/src/gui/rss/automatedrssdownloader.h
+++ b/src/gui/rss/automatedrssdownloader.h
@@ -86,6 +86,7 @@ private slots:
     void updateFieldsToolTips(bool regex);
     void updateMustLineValidity();
     void updateMustNotLineValidity();
+    void updateEpisodeFilterValidity();
     void onFinished(int result);
 
 private:
@@ -100,7 +101,6 @@ private:
     Rss::DownloadRuleList *m_ruleList;
     Rss::DownloadRuleList *m_editableRuleList;
     QRegExp *m_episodeRegex;
-    QRegExpValidator *m_episodeValidator;
     QShortcut *editHotkey;
     QShortcut *deleteHotkey;
 };
diff --git a/src/gui/rss/automatedrssdownloader.ui b/src/gui/rss/automatedrssdownloader.ui
index 39034604d..0338419cd 100644
--- a/src/gui/rss/automatedrssdownloader.ui
+++ b/src/gui/rss/automatedrssdownloader.ui
@@ -151,6 +151,16 @@
               </property>
              </widget>
             </item>
+            <item row="2" column="2">
+             <widget class="QLabel" name="lbl_epfilter_stat">
+              <property name="maximumSize">
+               <size>
+                <width>18</width>
+                <height>18</height>
+               </size>
+              </property>
+             </widget>
+            </item>
             <item row="1" column="1">
              <widget class="QLineEdit" name="lineNotContains"/>
             </item>