d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-02-03 10:25:02 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #9092 from hannsen/patch-1

Browse Source 
PEP 8 compliant version comments in search plugins
This commit is contained in:
Mike Tzou 2018-06-18 00:56:28 +08:00 committed by GitHub
commit 8f6e066332
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/base/search/searchpluginmanager.cpp
View File

@ -554,19 +554,17 @@ PluginVersion SearchPluginManager::getPluginVersion(QString filePath)
PluginVersion version; PluginVersion version;
while (!plugin.atEnd()) { while (!plugin.atEnd()) {
QByteArray line = plugin.readLine(); const QString line = QString(plugin.readLine()).remove(' ');
if (line.startsWith("#VERSION: ")) { if (!line.startsWith("#VERSION:", Qt::CaseInsensitive)) continue;
line = line.split(' ').last().trimmed();
version = PluginVersion::tryParse(line, invalidVersion); const QString versionStr = line.mid(9);
if (version == invalidVersion) { version = PluginVersion::tryParse(versionStr, invalidVersion);
LogMsg(tr("Search plugin '%1' contains invalid version string ('%2')") if (version == invalidVersion) {
.arg(Utils::Fs::fileName(filePath), QString::fromUtf8(line)), Log::MsgType::WARNING); LogMsg(tr("Search plugin '%1' contains invalid version string ('%2')")
} .arg(Utils::Fs::fileName(filePath), line), Log::MsgType::WARNING);
else {
qDebug() << "plugin" << filePath << "version: " << version;
}
break;
} }
break;
} }
return version; return version;
} }