Merge pull request #9092 from hannsen/patch-1

PEP 8 compliant version comments in search plugins

src/base/search/searchpluginmanager.cpp

@@ -554,19 +554,17 @@ PluginVersion SearchPluginManager::getPluginVersion(QString filePath)
 
     PluginVersion version;
     while (!plugin.atEnd()) {
-        QByteArray line = plugin.readLine();
+        const QString line = QString(plugin.readLine()).remove(' ');
-        if (line.startsWith("#VERSION: ")) {
+        if (!line.startsWith("#VERSION:", Qt::CaseInsensitive)) continue;
-            line = line.split(' ').last().trimmed();
+
-            version = PluginVersion::tryParse(line, invalidVersion);
+        const QString versionStr = line.mid(9);
-            if (version == invalidVersion) {
+        version = PluginVersion::tryParse(versionStr, invalidVersion);
-                LogMsg(tr("Search plugin '%1' contains invalid version string ('%2')")
+        if (version == invalidVersion) {
-                    .arg(Utils::Fs::fileName(filePath), QString::fromUtf8(line)), Log::MsgType::WARNING);
+            LogMsg(tr("Search plugin '%1' contains invalid version string ('%2')")
-            }
+                .arg(Utils::Fs::fileName(filePath), line), Log::MsgType::WARNING);
-            else {
-                qDebug() << "plugin" << filePath << "version: " << version;
-            }
-            break;
         }
+
+        break;
     }
     return version;
 }