Perform settings upgrade for existing user only

src/app/main.cpp

@@ -168,22 +168,25 @@ int main(int argc, char *argv[])
         if (!qputenv("QBITTORRENT", QBT_VERSION))
             fprintf(stderr, "Couldn't set environment variable...\n");
 
+        const bool firstTimeUser = !Preferences::instance()->getAcceptedLegal();
+        if (firstTimeUser) {
 #ifndef DISABLE_GUI
-        if (!userAgreesWithLegalNotice())
+            if (!userAgreesWithLegalNotice())
-            return EXIT_SUCCESS;
+                return EXIT_SUCCESS;
 
 #elif defined(Q_OS_WIN)
-        if (_isatty(_fileno(stdin))
+            if (_isatty(_fileno(stdin))
-            && _isatty(_fileno(stdout))
+                && _isatty(_fileno(stdout))
-            && !userAgreesWithLegalNotice())
+                && !userAgreesWithLegalNotice())
-            return EXIT_SUCCESS;
+                return EXIT_SUCCESS;
 #else
-        if (!params.shouldDaemonize
+            if (!params.shouldDaemonize
-            && isatty(fileno(stdin))
+                && isatty(fileno(stdin))
-            && isatty(fileno(stdout))
+                && isatty(fileno(stdout))
-            && !userAgreesWithLegalNotice())
+                && !userAgreesWithLegalNotice())
-            return EXIT_SUCCESS;
+                return EXIT_SUCCESS;
 #endif
+        }
 
         // Check if qBittorrent is already running for this user
         if (app->isRunning()) {
@@ -233,16 +236,18 @@ int main(int argc, char *argv[])
         app->setAttribute(Qt::AA_DontShowIconsInMenus);
 #endif
 
+        if (!firstTimeUser) {
 #ifndef DISABLE_GUI
-        if (!upgrade()) return EXIT_FAILURE;
+            if (!upgrade()) return EXIT_FAILURE;
 #elif defined(Q_OS_WIN)
-        if (!upgrade(_isatty(_fileno(stdin))
+            if (!upgrade(_isatty(_fileno(stdin))
-                     && _isatty(_fileno(stdout)))) return EXIT_FAILURE;
+                         && _isatty(_fileno(stdout)))) return EXIT_FAILURE;
 #else
-        if (!upgrade(!params.shouldDaemonize
+            if (!upgrade(!params.shouldDaemonize
-                     && isatty(fileno(stdin))
+                         && isatty(fileno(stdin))
-                     && isatty(fileno(stdout)))) return EXIT_FAILURE;
+                         && isatty(fileno(stdout)))) return EXIT_FAILURE;
 #endif
+        }
 #if defined(DISABLE_GUI) && !defined(Q_OS_WIN)
         if (params.shouldDaemonize) {
             app.reset(); // Destroy current application
@@ -378,8 +383,7 @@ void displayBadArgMessage(const QString &message)
 bool userAgreesWithLegalNotice()
 {
     Preferences *const pref = Preferences::instance();
-    if (pref->getAcceptedLegal()) // Already accepted once
+    Q_ASSERT(!pref->getAcceptedLegal());
-        return true;
 
 #ifdef DISABLE_GUI
     const QString eula = QString("\n*** %1 ***\n").arg(QObject::tr("Legal Notice"))