Merge pull request #10941 from Piccirello/fix-webui-magnet-trackers

Fix WebUI removing parameters from magnet links

src/webui/www/private/download.html

@@ -142,9 +142,8 @@
 
         const encodedUrls = new URI().getData('urls');
         if (encodedUrls) {
-            const urls = [];
+            const urls = encodedUrls.split('|').map(function(url) {
-            encodedUrls.split('|').each(function(url) {
+                return decodeURIComponent(url);
-                urls.push(decodeURIComponent(url));
             });
 
             if (urls.length)

src/webui/www/private/scripts/client.js

@@ -967,18 +967,13 @@ function registerMagnetHandler() {
 
 function handleDownloadParam() {
     // Extract torrent URL from download param in WebUI URL hash
-    const hashParams = getHashParamsFromUrl();
+    const downloadHash = "#download=";
-    const url = hashParams.download;
+    if (location.hash.indexOf(downloadHash) !== 0)
-    if (!url)
         return;
 
-    // Remove the download param from WebUI URL hash
+    const url = location.hash.substring(downloadHash.length);
-    delete hashParams.download;
+    // Remove the processed hash from the URL
-    let newHash = Object.toQueryString(hashParams);
+    history.replaceState('', document.title, (location.pathname + location.search));
-    newHash = newHash ? ('#' + newHash) : '';
-    history.replaceState('', document.title,
-        (location.pathname + location.search + newHash));
-
     showDownloadPage([url]);
 }
 

src/webui/www/private/scripts/mocha-init.js

@@ -135,8 +135,11 @@ const initializeWindows = function() {
     showDownloadPage = function(urls) {
         const id = 'downloadPage';
         let contentUrl = 'download.html';
-        if (urls && urls.length)
+        if (urls && (urls.length > 0)) {
-            contentUrl += '?urls=' + urls.join("|");
+            contentUrl += ('?urls=' + urls.map(function(url) {
+                return encodeURIComponent(url);
+            }).join("|"));
+        }
 
         new MochaUI.Window({
             id: id,