d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-11 15:27:54 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #11259 from Chocobo1/tristate

Browse Source 
Revise TriStateBool class
This commit is contained in:
Mike Tzou 2019-09-25 09:52:41 +08:00 committed by GitHub
commit 7c7963f93f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/base/rss/rss_autodownloadrule.cpp
View File

@ -64,7 +64,7 @@ namespace
QJsonValue triStateBoolToJsonValue(const TriStateBool &triStateBool)
{
switch (static_cast<int>(triStateBool)) {
switch (static_cast<signed char>(triStateBool)) {
case 0: return false;
case 1: return true;
default: return {};
@ -82,7 +82,7 @@ namespace
int triStateBoolToAddPausedLegacy(const TriStateBool &triStateBool)
{
switch (static_cast<int>(triStateBool)) {
switch (static_cast<signed char>(triStateBool)) {
case 0: return 2; // never
case 1: return 1; // always
default: return 0; // default

15
src/base/tristatebool.h
View File

@ -38,24 +38,29 @@ public:
constexpr TriStateBool() = default;
constexpr TriStateBool(const TriStateBool &other) = default;
explicit constexpr TriStateBool(int value)
: m_value(value < 0 ? -1 : (value > 0 ? 1 : 0))
explicit constexpr TriStateBool(const bool boolean)
{
*this = boolean ? True : False;
}
explicit constexpr operator int() const
TriStateBool &operator=(const TriStateBool &other) = default; // TODO: add constexpr when using C++17
explicit constexpr operator signed char() const
{
return m_value;
}
TriStateBool &operator=(const TriStateBool &other) = default; // add constexpr when using C++17
constexpr friend bool operator==(const TriStateBool &left, const TriStateBool &right)
{
return (left.m_value == right.m_value);
}
private:
explicit constexpr TriStateBool(const int value)
: m_value((value < 0) ? -1 : ((value > 0) ? 1 : 0))
{
}
signed char m_value = -1; // Undefined by default
};