From 77aea3c59ec22cb02d0611ecc38f3c201a1aa3aa Mon Sep 17 00:00:00 2001 From: thalieht Date: Fri, 22 Feb 2019 04:24:22 +0200 Subject: [PATCH] Add const to a few pointer arguments --- src/base/net/downloadmanager.cpp | 2 +- src/base/net/downloadmanager.h | 2 +- src/base/net/smtp.cpp | 2 +- src/base/net/smtp.h | 2 +- src/base/rss/rss_article.cpp | 2 +- src/base/rss/rss_article.h | 2 +- src/base/rss/rss_autodownloader.cpp | 4 ++-- src/base/rss/rss_autodownloader.h | 4 ++-- src/gui/properties/piecesbar.cpp | 2 +- src/gui/properties/piecesbar.h | 2 +- 10 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/base/net/downloadmanager.cpp b/src/base/net/downloadmanager.cpp index 71923b946..680d2e233 100644 --- a/src/base/net/downloadmanager.cpp +++ b/src/base/net/downloadmanager.cpp @@ -253,7 +253,7 @@ void Net::DownloadManager::applyProxySettings() m_networkManager.setProxy(proxy); } -void Net::DownloadManager::handleReplyFinished(QNetworkReply *reply) +void Net::DownloadManager::handleReplyFinished(const QNetworkReply *reply) { const ServiceID id = ServiceID::fromURL(reply->url()); const auto waitingJobsIter = m_waitingJobs.find(id); diff --git a/src/base/net/downloadmanager.h b/src/base/net/downloadmanager.h index a04701c89..3e83dbc3f 100644 --- a/src/base/net/downloadmanager.h +++ b/src/base/net/downloadmanager.h @@ -115,7 +115,7 @@ namespace Net explicit DownloadManager(QObject *parent = nullptr); void applyProxySettings(); - void handleReplyFinished(QNetworkReply *reply); + void handleReplyFinished(const QNetworkReply *reply); static DownloadManager *m_instance; QNetworkAccessManager m_networkManager; diff --git a/src/base/net/smtp.cpp b/src/base/net/smtp.cpp index 8f23aa237..4cffa215c 100644 --- a/src/base/net/smtp.cpp +++ b/src/base/net/smtp.cpp @@ -285,7 +285,7 @@ void Smtp::readyRead() } } -QByteArray Smtp::encodeMimeHeader(const QString &key, const QString &value, QTextCodec *latin1, const QByteArray &prefix) +QByteArray Smtp::encodeMimeHeader(const QString &key, const QString &value, const QTextCodec *latin1, const QByteArray &prefix) { QByteArray rv = ""; QByteArray line = key.toLatin1() + ": "; diff --git a/src/base/net/smtp.h b/src/base/net/smtp.h index 415aa3a72..b8775f895 100644 --- a/src/base/net/smtp.h +++ b/src/base/net/smtp.h @@ -90,7 +90,7 @@ namespace Net AuthCramMD5 }; - QByteArray encodeMimeHeader(const QString &key, const QString &value, QTextCodec *latin1, const QByteArray &prefix = {}); + QByteArray encodeMimeHeader(const QString &key, const QString &value, const QTextCodec *latin1, const QByteArray &prefix = {}); void ehlo(); void helo(); void parseEhloResponse(const QByteArray &code, bool continued, const QString &line); diff --git a/src/base/rss/rss_article.cpp b/src/base/rss/rss_article.cpp index 11ced4e4b..9e88adc3b 100644 --- a/src/base/rss/rss_article.cpp +++ b/src/base/rss/rss_article.cpp @@ -142,7 +142,7 @@ QJsonObject Article::toJsonObject() const return jsonObj; } -bool Article::articleDateRecentThan(Article *article, const QDateTime &date) +bool Article::articleDateRecentThan(const Article *article, const QDateTime &date) { return article->date() > date; } diff --git a/src/base/rss/rss_article.h b/src/base/rss/rss_article.h index 681b1dfa2..e070f0850 100644 --- a/src/base/rss/rss_article.h +++ b/src/base/rss/rss_article.h @@ -74,7 +74,7 @@ namespace RSS QJsonObject toJsonObject() const; - static bool articleDateRecentThan(Article *article, const QDateTime &date); + static bool articleDateRecentThan(const Article *article, const QDateTime &date); signals: void read(Article *article = nullptr); diff --git a/src/base/rss/rss_autodownloader.cpp b/src/base/rss/rss_autodownloader.cpp index 2e452e337..4a8609b3f 100644 --- a/src/base/rss/rss_autodownloader.cpp +++ b/src/base/rss/rss_autodownloader.cpp @@ -347,7 +347,7 @@ void AutoDownloader::handleTorrentDownloadFailed(const QString &url) // TODO: Re-schedule job here. } -void AutoDownloader::handleNewArticle(Article *article) +void AutoDownloader::handleNewArticle(const Article *article) { if (!article->isRead() && !article->torrentUrl().isEmpty()) addJobForArticle(article); @@ -358,7 +358,7 @@ void AutoDownloader::setRule_impl(const AutoDownloadRule &rule) m_rules.insert(rule.name(), rule); } -void AutoDownloader::addJobForArticle(Article *article) +void AutoDownloader::addJobForArticle(const Article *article) { const QString torrentURL = article->torrentUrl(); if (m_waitingJobs.contains(torrentURL)) return; diff --git a/src/base/rss/rss_autodownloader.h b/src/base/rss/rss_autodownloader.h index 43b908730..91dfe424c 100644 --- a/src/base/rss/rss_autodownloader.h +++ b/src/base/rss/rss_autodownloader.h @@ -110,14 +110,14 @@ namespace RSS void process(); void handleTorrentDownloadFinished(const QString &url); void handleTorrentDownloadFailed(const QString &url); - void handleNewArticle(Article *article); + void handleNewArticle(const Article *article); private: void timerEvent(QTimerEvent *event) override; void setRule_impl(const AutoDownloadRule &rule); void resetProcessingQueue(); void startProcessing(); - void addJobForArticle(Article *article); + void addJobForArticle(const Article *article); void processJob(const QSharedPointer &job); void load(); void loadRules(const QByteArray &data); diff --git a/src/gui/properties/piecesbar.cpp b/src/gui/properties/piecesbar.cpp index 2836923ca..276261111 100644 --- a/src/gui/properties/piecesbar.cpp +++ b/src/gui/properties/piecesbar.cpp @@ -118,7 +118,7 @@ PiecesBar::PiecesBar(QWidget *parent) setMouseTracking(true); } -void PiecesBar::setTorrent(BitTorrent::TorrentHandle *torrent) +void PiecesBar::setTorrent(const BitTorrent::TorrentHandle *torrent) { m_torrent = torrent; if (!m_torrent) diff --git a/src/gui/properties/piecesbar.h b/src/gui/properties/piecesbar.h index ac0575a16..0e7a335fc 100644 --- a/src/gui/properties/piecesbar.h +++ b/src/gui/properties/piecesbar.h @@ -50,7 +50,7 @@ class PiecesBar : public QWidget public: explicit PiecesBar(QWidget *parent = nullptr); - void setTorrent(BitTorrent::TorrentHandle *torrent); + void setTorrent(const BitTorrent::TorrentHandle *torrent); void setColors(const QColor &background, const QColor &border, const QColor &complete); virtual void clear();