Browse Source

Prevent precise timers from being used when unnecessary

The implementation of QTimer::singleShot() uses Qt::PreciseTimer if interval is less than 2 seconds. This isn't mentioned in the docs.
Qt::PreciseTimer increases the system's timer resolution which negatively affects power consumption.

PR #18555.
Closes #18350.
adaptive-webui-19844
Vladimir Golovnev 2 years ago committed by GitHub
parent
commit
7600f59f3a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      src/app/main.cpp
  2. 2
      src/base/bittorrent/sessionimpl.cpp
  3. 2
      src/base/torrentfileswatcher.cpp
  4. 2
      src/webui/api/appcontroller.cpp

2
src/app/main.cpp

@ -283,7 +283,7 @@ void showSplashScreen() @@ -283,7 +283,7 @@ void showSplashScreen()
painter.drawText(224 - painter.fontMetrics().horizontalAdvance(version), 270, version);
QSplashScreen *splash = new QSplashScreen(splashImg);
splash->show();
QTimer::singleShot(1500ms, splash, &QObject::deleteLater);
QTimer::singleShot(1500ms, Qt::CoarseTimer, splash, &QObject::deleteLater);
qApp->processEvents();
}
#endif // DISABLE_GUI

2
src/base/bittorrent/sessionimpl.cpp

@ -5064,7 +5064,7 @@ void SessionImpl::enqueueRefresh() @@ -5064,7 +5064,7 @@ void SessionImpl::enqueueRefresh()
{
Q_ASSERT(!m_refreshEnqueued);
QTimer::singleShot(refreshInterval(), this, [this] ()
QTimer::singleShot(refreshInterval(), Qt::CoarseTimer, this, [this]
{
m_nativeSession->post_torrent_updates();
m_nativeSession->post_session_stats();

2
src/base/torrentfileswatcher.cpp

@ -502,7 +502,7 @@ void TorrentFilesWatcher::Worker::removeWatchedFolder(const Path &path) @@ -502,7 +502,7 @@ void TorrentFilesWatcher::Worker::removeWatchedFolder(const Path &path)
void TorrentFilesWatcher::Worker::scheduleWatchedFolderProcessing(const Path &path)
{
QTimer::singleShot(2s, this, [this, path]()
QTimer::singleShot(2s, Qt::CoarseTimer, this, [this, path]
{
processWatchedFolder(path);
});

2
src/webui/api/appcontroller.cpp

@ -94,7 +94,7 @@ void AppController::shutdownAction() @@ -94,7 +94,7 @@ void AppController::shutdownAction()
// Special handling for shutdown, we
// need to reply to the Web UI before
// actually shutting down.
QTimer::singleShot(100ms, qApp, []()
QTimer::singleShot(100ms, Qt::CoarseTimer, qApp, []
{
QCoreApplication::exit();
});

Loading…
Cancel
Save