d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-01-22 20:44:15 +00:00
Code Issues Projects Releases Wiki Activity

Fix dangerous usage of vector iterator (Thanks cgreco)

Browse Source
This commit is contained in:
Christophe Dumez 2010-12-16 20:34:37 +00:00
parent 493499cded
commit 7294cdafbf
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/properties/trackerlist.cpp
View File

@ -321,18 +321,15 @@ void TrackerList::deleteSelectedTrackers(){
delete item; delete item;
} }
// Iterate of trackers and remove selected ones // Iterate of trackers and remove selected ones
std::vector<announce_entry> remaining_trackers;
std::vector<announce_entry> trackers = h.trackers(); std::vector<announce_entry> trackers = h.trackers();
std::vector<announce_entry>::iterator it = trackers.begin(); std::vector<announce_entry>::iterator it;
while(it != trackers.end()) { for(it = trackers.begin(); it != trackers.end(); it++) {
int index = urls_to_remove.indexOf(misc::toQString((*it).url)); if(!urls_to_remove.contains(misc::toQString((*it).url))) {
if(index >= 0) { remaining_trackers.push_back(*it);
trackers.erase(it);
urls_to_remove.removeAt(index);
} else {
it++;
} }
} }
h.replace_trackers(trackers); h.replace_trackers(remaining_trackers);
h.force_reannounce(); h.force_reannounce();
// Reload Trackers // Reload Trackers
loadTrackers(); loadTrackers();