diff --git a/.github/pull_request_template.yml b/.github/PULL_REQUEST_TEMPLATE.md similarity index 100% rename from .github/pull_request_template.yml rename to .github/PULL_REQUEST_TEMPLATE.md diff --git a/src/gui/transferlistsortmodel.cpp b/src/gui/transferlistsortmodel.cpp index fcf9e31fd..2f442d13a 100644 --- a/src/gui/transferlistsortmodel.cpp +++ b/src/gui/transferlistsortmodel.cpp @@ -51,10 +51,8 @@ namespace const bool isLeftValid = left.isValid(); const bool isRightValid = right.isValid(); - if (isLeftValid && isRightValid) + if (isLeftValid == isRightValid) return threeWayCompare(left, right); - if (!isLeftValid && !isRightValid) - return 0; return isLeftValid ? -1 : 1; } diff --git a/src/webui/api/torrentscontroller.cpp b/src/webui/api/torrentscontroller.cpp index 771cddf0e..65b579c67 100644 --- a/src/webui/api/torrentscontroller.cpp +++ b/src/webui/api/torrentscontroller.cpp @@ -176,7 +176,7 @@ namespace const QJsonObject dht { {KEY_TRACKER_URL, "** [DHT] **"}, - {KEY_TRACKER_TIER, ""}, + {KEY_TRACKER_TIER, -1}, {KEY_TRACKER_MSG, (isTorrentPrivate ? privateMsg : "")}, {KEY_TRACKER_STATUS, ((BitTorrent::Session::instance()->isDHTEnabled() && !isTorrentPrivate) ? working : disabled)}, {KEY_TRACKER_PEERS_COUNT, 0}, @@ -188,7 +188,7 @@ namespace const QJsonObject pex { {KEY_TRACKER_URL, "** [PeX] **"}, - {KEY_TRACKER_TIER, ""}, + {KEY_TRACKER_TIER, -1}, {KEY_TRACKER_MSG, (isTorrentPrivate ? privateMsg : "")}, {KEY_TRACKER_STATUS, ((BitTorrent::Session::instance()->isPeXEnabled() && !isTorrentPrivate) ? working : disabled)}, {KEY_TRACKER_PEERS_COUNT, 0}, @@ -200,7 +200,7 @@ namespace const QJsonObject lsd { {KEY_TRACKER_URL, "** [LSD] **"}, - {KEY_TRACKER_TIER, ""}, + {KEY_TRACKER_TIER, -1}, {KEY_TRACKER_MSG, (isTorrentPrivate ? privateMsg : "")}, {KEY_TRACKER_STATUS, ((BitTorrent::Session::instance()->isLSDEnabled() && !isTorrentPrivate) ? working : disabled)}, {KEY_TRACKER_PEERS_COUNT, 0}, diff --git a/src/webui/www/private/scripts/prop-trackers.js b/src/webui/www/private/scripts/prop-trackers.js index 985449c04..718d170ba 100644 --- a/src/webui/www/private/scripts/prop-trackers.js +++ b/src/webui/www/private/scripts/prop-trackers.js @@ -97,7 +97,7 @@ window.qBittorrent.PropTrackers = (function() { const row = { rowId: tracker.url, - tier: tracker.tier, + tier: (tracker.tier >= 0) ? tracker.tier : "", url: tracker.url, status: status, peers: tracker.num_peers,