From 6fd522472cc554642284c74dcd0741e3a8281eca Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Sun, 12 Mar 2023 04:58:04 +0800 Subject: [PATCH] GHA CI: drop needless syntax https://docs.github.com/en/actions/learn-github-actions/expressions#about-expressions >When you use expressions in an if conditional, you may omit the >expression syntax (${{ }}) because GitHub automatically evaluates the if conditional as an expression. --- .github/workflows/ci_macos.yaml | 4 ++-- .github/workflows/ci_ubuntu.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci_macos.yaml b/.github/workflows/ci_macos.yaml index 181331069..5f660bce8 100644 --- a/.github/workflows/ci_macos.yaml +++ b/.github/workflows/ci_macos.yaml @@ -84,7 +84,7 @@ jobs: sudo cmake --install build - name: Build qBittorrent (Qt5) - if: ${{ startsWith(matrix.qt_version, 5) }} + if: startsWith(matrix.qt_version, 5) run: | CXXFLAGS="$CXXFLAGS -Werror -Wno-error=deprecated-declarations" \ LDFLAGS="$LDFLAGS -gz" \ @@ -103,7 +103,7 @@ jobs: cmake --build build --target check - name: Build qBittorrent (Qt6) - if: ${{ startsWith(matrix.qt_version, 6) }} + if: startsWith(matrix.qt_version, 6) run: | CXXFLAGS="$CXXFLAGS -Wno-gnu-zero-variadic-macro-arguments -Werror -Wno-error=deprecated-declarations" \ LDFLAGS="$LDFLAGS -gz" \ diff --git a/.github/workflows/ci_ubuntu.yaml b/.github/workflows/ci_ubuntu.yaml index 168b8a7b3..8d2fbbe68 100644 --- a/.github/workflows/ci_ubuntu.yaml +++ b/.github/workflows/ci_ubuntu.yaml @@ -75,7 +75,7 @@ jobs: languages: cpp - name: Build qBittorrent (Qt5) - if: ${{ startsWith(matrix.qt_version, 5) }} + if: startsWith(matrix.qt_version, 5) run: | CXXFLAGS="$CXXFLAGS -Werror -Wno-error=deprecated-declarations" \ LDFLAGS="$LDFLAGS -gz" \ @@ -94,7 +94,7 @@ jobs: DESTDIR="qbittorrent" cmake --install build - name: Build qBittorrent (Qt6) - if: ${{ startsWith(matrix.qt_version, 6) }} + if: startsWith(matrix.qt_version, 6) run: | CXXFLAGS="$CXXFLAGS -Werror" \ LDFLAGS="$LDFLAGS -gz" \